All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Usyskin, Alexander" <alexander.usyskin@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Chen, Yu C" <yu.c.chen@intel.com>
Subject: RE: [char-misc for 4.10-rc4] mei: bus: enable OS version only for SPT and newer
Date: Tue, 10 Jan 2017 18:12:06 +0000	[thread overview]
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B543797E5@hasmsx108.ger.corp.intel.com> (raw)
In-Reply-To: <20170110165310.GA15679@kroah.com>

> 
> On Mon, Jan 09, 2017 at 06:15:29PM +0200, Tomas Winkler wrote:
> > From: Alexander Usyskin <alexander.usyskin@intel.com>
> >
> > Sending OS version for support of TPM2_ChangeEPS() is required only
> > for SPT FW (HMB version 2.0) and newer.
> > On older platforms the command should be just ignored by the firmware
> > but some older platforms misbehave so it's safer to send the command
> > only if required.
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=192051
> > Fixes: 94a621b0b8aa (mei: send OS type to the FW)
> 
> That's not a valid sha1 :(
> 
> Please fix it up and resend, after figuring out where you got that odd number
> from.

Sorry for that, the sha1 is form our internal branch. 
Will need to add some script that checks that before sending, as that happened in the past already.

Thanks
Tomas

      reply	other threads:[~2017-01-10 18:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 16:15 [char-misc for 4.10-rc4] mei: bus: enable OS version only for SPT and newer Tomas Winkler
2017-01-10 16:53 ` Greg Kroah-Hartman
2017-01-10 18:12   ` Winkler, Tomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B8DA87D05A7694D9FA63FD143655C1B543797E5@hasmsx108.ger.corp.intel.com \
    --to=tomas.winkler@intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.