From: "Winkler, Tomas" <tomas.winkler@intel.com> To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, "Javier Martinez Canillas" <javierm@redhat.com> Cc: Jason Gunthorpe <jgg@ziepe.ca>, "Usyskin, Alexander" <alexander.usyskin@intel.com>, "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>, "linux-security-module@vger.kernel.org" <linux-security-module@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 0/5 V2] tpm: timeouts revamp Date: Tue, 6 Mar 2018 15:05:44 +0000 [thread overview] Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422F491@hasmsx108.ger.corp.intel.com> (raw) In-Reply-To: <20180306140256.GC5700@linux.intel.com> > On Tue, Mar 06, 2018 at 01:39:49PM +0100, Javier Martinez Canillas wrote: > > On 03/06/2018 01:17 PM, Jarkko Sakkinen wrote: > > > On Tue, 2018-03-06 at 11:24 +0200, Tomas Winkler wrote: > > >> This series cleans up tpm timeouts setting and handling. > > >> > > >> First motivation was to fix failures coming from too short timeouts > > >> for commands that creates keys. > > >> Key generation may take significant time depending on the > > >> underlying hardware. Rather than increasing default timeout a new > > >> constant is added, to not stall too long on regular commands failures. > > >> > > >> Second is to define timeouts for new tpm2 commands defined in TCG > > >> 1.36 spec. > > > > > > > Probably a typo, since the latest TCG spec version is the 1.38 [0]. > > > > > Where can we get that specification? I don't have that new version > > > and couldn't find it from the public internet. > > > > > > /Jarkko > > > > > > > [0]: https://trustedcomputinggroup.org/tpm-library-specification/ > > I already have that version of the specifications but I thought that we were > speaking about PC Client Platform spefication, which is at version 1.30. TCG > spec is an ambiguous term so that is where the confusion started from. > TCG spec doesn't define timeouts just new commands > The only spec I've seen some timeouts is the PC Client Specification but I > guess I've then missed the list in TPM 2.0 spefication. Where are they listed? > I worked with Will Arthur durations based on PC Client Specification when > TPM 2.0 support was first implemented. That's correct, this PTP spec. It defines the timeouts for the commands, this is stated in the patch comments. Need to cross reference these two specs. Thanks Tomas
WARNING: multiple messages have this Message-ID (diff)
From: tomas.winkler@intel.com (Winkler, Tomas) To: linux-security-module@vger.kernel.org Subject: [PATCH 0/5 V2] tpm: timeouts revamp Date: Tue, 6 Mar 2018 15:05:44 +0000 [thread overview] Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422F491@hasmsx108.ger.corp.intel.com> (raw) In-Reply-To: <20180306140256.GC5700@linux.intel.com> > On Tue, Mar 06, 2018 at 01:39:49PM +0100, Javier Martinez Canillas wrote: > > On 03/06/2018 01:17 PM, Jarkko Sakkinen wrote: > > > On Tue, 2018-03-06 at 11:24 +0200, Tomas Winkler wrote: > > >> This series cleans up tpm timeouts setting and handling. > > >> > > >> First motivation was to fix failures coming from too short timeouts > > >> for commands that creates keys. > > >> Key generation may take significant time depending on the > > >> underlying hardware. Rather than increasing default timeout a new > > >> constant is added, to not stall too long on regular commands failures. > > >> > > >> Second is to define timeouts for new tpm2 commands defined in TCG > > >> 1.36 spec. > > > > > > > Probably a typo, since the latest TCG spec version is the 1.38 [0]. > > > > > Where can we get that specification? I don't have that new version > > > and couldn't find it from the public internet. > > > > > > /Jarkko > > > > > > > [0]: https://trustedcomputinggroup.org/tpm-library-specification/ > > I already have that version of the specifications but I thought that we were > speaking about PC Client Platform spefication, which is at version 1.30. TCG > spec is an ambiguous term so that is where the confusion started from. > TCG spec doesn't define timeouts just new commands > The only spec I've seen some timeouts is the PC Client Specification but I > guess I've then missed the list in TPM 2.0 spefication. Where are they listed? > I worked with Will Arthur durations based on PC Client Specification when > TPM 2.0 support was first implemented. That's correct, this PTP spec. It defines the timeouts for the commands, this is stated in the patch comments. Need to cross reference these two specs. Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-06 15:05 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-06 9:24 [PATCH 0/5 V2] tpm: timeouts revamp Tomas Winkler 2018-03-06 9:24 ` Tomas Winkler 2018-03-06 9:24 ` [PATCH 1/5 V2] tpm: sort objects in the Makefile Tomas Winkler 2018-03-06 9:24 ` Tomas Winkler 2018-03-06 9:25 ` [PATCH 2/5 V2] tpm: factor out tpm 1.2 duration calculation to tpm1-cmd.c Tomas Winkler 2018-03-06 9:25 ` Tomas Winkler 2018-03-06 9:25 ` [PATCH 3/5 V2] tpm2: add longer timeouts for creation commands Tomas Winkler 2018-03-06 9:25 ` Tomas Winkler 2018-03-06 12:23 ` Jarkko Sakkinen 2018-03-06 12:23 ` Jarkko Sakkinen 2018-03-06 15:19 ` Winkler, Tomas 2018-03-06 15:19 ` Winkler, Tomas 2018-03-06 15:19 ` Winkler, Tomas 2018-03-10 11:21 ` Jarkko Sakkinen 2018-03-10 11:21 ` Jarkko Sakkinen 2018-03-06 9:25 ` [PATCH 4/5 V2] tpm2: add new tpm2 commands according to TCG 1.36 Tomas Winkler 2018-03-06 9:25 ` Tomas Winkler 2018-03-06 9:25 ` [PATCH 5/5 V2] tmp: factor out tpm_get_timeouts Tomas Winkler 2018-03-06 9:25 ` Tomas Winkler 2018-03-06 12:17 ` [PATCH 0/5 V2] tpm: timeouts revamp Jarkko Sakkinen 2018-03-06 12:17 ` Jarkko Sakkinen 2018-03-06 12:39 ` Javier Martinez Canillas 2018-03-06 12:39 ` Javier Martinez Canillas 2018-03-06 14:02 ` Jarkko Sakkinen 2018-03-06 14:02 ` Jarkko Sakkinen 2018-03-06 15:05 ` Winkler, Tomas [this message] 2018-03-06 15:05 ` Winkler, Tomas 2018-04-08 20:04 ` Ken Goldman 2018-03-06 15:01 ` Winkler, Tomas 2018-03-06 15:01 ` Winkler, Tomas 2018-04-08 20:01 ` Ken Goldman 2018-04-08 20:01 ` Ken Goldman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5B8DA87D05A7694D9FA63FD143655C1B9422F491@hasmsx108.ger.corp.intel.com \ --to=tomas.winkler@intel.com \ --cc=alexander.usyskin@intel.com \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=javierm@redhat.com \ --cc=jgg@ziepe.ca \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.