All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhong jiang <zhongjiang@huawei.com>
To: <shawnguo@kernel.org>, <airlied@linux.ie>, <noralf@tronnes.org>,
	<daniel.vetter@intel.com>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpu: do not double put device node in zx_drm_probe
Date: Thu, 6 Sep 2018 22:51:30 +0800	[thread overview]
Message-ID: <5B913EF2.1010209@huawei.com> (raw)
In-Reply-To: <1534472646-10368-1-git-send-email-zhongjiang@huawei.com>

+to maintainer.
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>gg
> ---
>  drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	for_each_available_child_of_node(parent, child) {
> +	for_each_available_child_of_node(parent, child)
>  		component_match_add(dev, &match, compare_of, child);
> -		of_node_put(child);
> -	}
>  
>  	return component_master_add_with_match(dev, &zx_drm_master_ops, match);
>  }



WARNING: multiple messages have this Message-ID (diff)
From: zhong jiang <zhongjiang@huawei.com>
To: shawnguo@kernel.org, airlied@linux.ie, noralf@tronnes.org,
	daniel.vetter@intel.com
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpu: do not double put device node in zx_drm_probe
Date: Thu, 6 Sep 2018 22:51:30 +0800	[thread overview]
Message-ID: <5B913EF2.1010209@huawei.com> (raw)
In-Reply-To: <1534472646-10368-1-git-send-email-zhongjiang@huawei.com>

+to maintainer.
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>gg
> ---
>  drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	for_each_available_child_of_node(parent, child) {
> +	for_each_available_child_of_node(parent, child)
>  		component_match_add(dev, &match, compare_of, child);
> -		of_node_put(child);
> -	}
>  
>  	return component_master_add_with_match(dev, &zx_drm_master_ops, match);
>  }

  parent reply	other threads:[~2018-09-06 14:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17  2:24 [PATCH] gpu: do not double put device node in zx_drm_probe zhong jiang
2018-08-17  2:24 ` zhong jiang
2018-08-23 11:41 ` zhong jiang
2018-08-23 11:41   ` zhong jiang
2018-08-27  7:18 ` Shawn Guo
2018-09-18 15:19   ` Daniel Vetter
2018-09-18 15:19     ` Daniel Vetter
2018-09-19 21:32     ` Shawn Guo
2018-09-06 14:51 ` zhong jiang [this message]
2018-09-06 14:51   ` zhong jiang
2018-09-18 14:59 ` zhong jiang
2018-09-18 14:59   ` zhong jiang
2018-09-18 15:02   ` Greg KH
2018-09-18 15:02     ` Greg KH
2018-09-18 15:18     ` zhong jiang
2018-09-18 15:18       ` zhong jiang
2018-09-18 15:20     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B913EF2.1010209@huawei.com \
    --to=zhongjiang@huawei.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.