All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhong jiang <zhongjiang@huawei.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: <airlied@linux.ie>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: sun4i: Fix a uninitialized variable warning.
Date: Wed, 19 Sep 2018 17:01:32 +0800	[thread overview]
Message-ID: <5BA2106C.2080007@huawei.com> (raw)
In-Reply-To: <20180919084719.6ymf6h4eftomfab3@flea>

On 2018/9/19 16:47, Maxime Ripard wrote:
> On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may be used uninitialized in this function [-Wmaybe-uninitialized]
>> bool has_lvds_rst, has_lvds_alt, can_lvds;
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> I can't see any code path that would lead to an uninitialized usage of
> that variable.
>
> Which compiler produced that warning? I tried building it today with
> gcc 8.1.1, and I don't see that warning either.
>
> Maxime
>
I indeed  hit the issue.  the gcc version is
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609

Thanks,
zhong jiang


WARNING: multiple messages have this Message-ID (diff)
From: zhongjiang@huawei.com (zhong jiang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm: sun4i: Fix a uninitialized variable warning.
Date: Wed, 19 Sep 2018 17:01:32 +0800	[thread overview]
Message-ID: <5BA2106C.2080007@huawei.com> (raw)
In-Reply-To: <20180919084719.6ymf6h4eftomfab3@flea>

On 2018/9/19 16:47, Maxime Ripard wrote:
> On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may be used uninitialized in this function [-Wmaybe-uninitialized]
>> bool has_lvds_rst, has_lvds_alt, can_lvds;
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> I can't see any code path that would lead to an uninitialized usage of
> that variable.
>
> Which compiler produced that warning? I tried building it today with
> gcc 8.1.1, and I don't see that warning either.
>
> Maxime
>
I indeed  hit the issue.  the gcc version is
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609

Thanks,
zhong jiang

  reply	other threads:[~2018-09-19  9:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18  7:25 [PATCH] drm: sun4i: Fix a uninitialized variable warning zhong jiang
2018-09-18  7:25 ` zhong jiang
2018-09-19  8:47 ` Maxime Ripard
2018-09-19  8:47   ` Maxime Ripard
2018-09-19  9:01   ` zhong jiang [this message]
2018-09-19  9:01     ` zhong jiang
2018-09-21 14:26     ` Maxime Ripard
2018-09-21 14:26       ` Maxime Ripard
2018-09-21 14:49       ` zhong jiang
2018-09-21 14:49         ` zhong jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BA2106C.2080007@huawei.com \
    --to=zhongjiang@huawei.com \
    --cc=airlied@linux.ie \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.