Re: [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config()

From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config()
Date: Mon, 08 Oct 2018 07:45:47 -0600	[thread overview]
Message-ID: <5BBB5F8B02000078001EF9C9@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <1538751289-1109-4-git-send-email-andrew.cooper3@citrix.com>

>>> On 05.10.18 at 16:54, <andrew.cooper3@citrix.com> wrote:
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -601,6 +601,8 @@ void vcpu_switch_to_aarch64_mode(struct vcpu *v)
>  
>  int arch_check_domain_config(struct xen_domctl_createdomain *config)
>  {
> +    unsigned int max_vcpus = 0;

Is the initializer really needed here considering ...

> @@ -619,6 +621,22 @@ int arch_check_domain_config(struct xen_domctl_createdomain *config)
>          }
>      }
>  
> +    /* Calculate the maximum number of vcpus from the selected GIC version... */
> +    switch ( config->arch.gic_version )
> +    {
> +    case GIC_V2: max_vcpus = 8;   break;
> +    case GIC_V3: max_vcpus = 255; break;
> +
> +    default:
> +        return -EOPNOTSUPP;

... this?

> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -297,6 +297,9 @@ static int check_domain_config(struct xen_domctl_createdomain *config)
>                             XEN_DOMCTL_CDF_xs_domain) )
>          return -EINVAL;
>  
> +    if ( config->max_vcpus < 1 )
> +        return -EINVAL;
> +
>      return arch_check_domain_config(config);
>  }

Any reason you don't remove the now redundant check from
domain_create(), which would allow ditching altogether x86's
domain_max_vcpus()?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel