From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config()
Date: Mon, 12 Nov 2018 01:21:00 -0700 [thread overview]
Message-ID: <5BE937EC02000078001FAB54@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <3d04b7cf-bf72-40dc-70e7-054367a40d0f@citrix.com>
>>> On 09.11.18 at 19:44, <andrew.cooper3@citrix.com> wrote:
> On 08/10/18 14:45, Jan Beulich wrote:
>>
>>> --- a/xen/common/domain.c
>>> +++ b/xen/common/domain.c
>>> @@ -297,6 +297,9 @@ static int check_domain_config(struct
> xen_domctl_createdomain *config)
>>> XEN_DOMCTL_CDF_xs_domain) )
>>> return -EINVAL;
>>>
>>> + if ( config->max_vcpus < 1 )
>>> + return -EINVAL;
>>> +
>>> return arch_check_domain_config(config);
>>> }
>> Any reason you don't remove the now redundant check from
>> domain_create(), which would allow ditching altogether x86's
>> domain_max_vcpus()?
>
> That's done in the next patch, to simplify this one.
Yeah, I had noticed this once I got there. Half a sentence in the
description to explain the now possible cleanup is deferred
intentionally would have helped, but that's fine in any event.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-12 8:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 14:54 [PATCH RFC 0/5] xen/domain: Allocate d->vcpu[] earlier during domain construction Andrew Cooper
2018-10-05 14:54 ` [PATCH 1/5] xen/domain: Introduce a new check_domain_config() helper Andrew Cooper
2018-10-08 13:37 ` Jan Beulich
2018-10-05 14:54 ` [PATCH 2/5] xen/domain: Introduce a new arch_check_domain_config() helper Andrew Cooper
2018-10-08 13:39 ` Jan Beulich
2018-10-09 10:57 ` Julien Grall
2018-10-05 14:54 ` [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config() Andrew Cooper
2018-10-08 6:44 ` Alan Robinson
2018-10-08 13:45 ` Jan Beulich
2018-11-09 18:44 ` Andrew Cooper
2018-11-12 8:21 ` Jan Beulich [this message]
2018-10-09 11:23 ` Julien Grall
2018-11-09 18:43 ` Andrew Cooper
2018-11-12 11:43 ` Julien Grall
2018-11-12 11:45 ` Andrew Cooper
2018-10-05 14:54 ` [PATCH 4/5] xen/domain: Allocate d->vcpu[] earlier during domain_create() Andrew Cooper
2018-10-08 13:51 ` Jan Beulich
2018-10-08 17:39 ` Andrew Cooper
2018-10-09 6:06 ` Jan Beulich
2018-10-05 14:54 ` [PATCH 5/5] Revert "xen/arm: vgic-v3: Delay the initialization of the domain information" Andrew Cooper
2018-10-09 11:25 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BE937EC02000078001FAB54@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.