Re: [meta-arm] [PATCH] [arm-autonomy] arm-autonomy-host-image-minimal: Abort on copy fail

Re: [meta-arm] [PATCH] [arm-autonomy] arm-autonomy-host-image-minimal: Abort on copy fail

[Bertrand Marquis]

> On 7 May 2020, at 12:17, Bertrand Marquis via lists.yoctoproject.org <bertrand.marquis=arm.com@lists.yoctoproject.org> wrote:
> 
> From: Diego Sueiro <diego.sueiro@arm.com>
> 
> If the guest image copy fails we need to abort the do_image execution.
> 
> Change-Id: I3785a0828e271ed27eb7f9212804b5b9b39f79ac
> Issue-Id: SCM-990
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

> ---
> .../recipes-core/images/arm-autonomy-host-image-minimal.bb     | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb b/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
> index 3859f52..5b20fa0 100644
> --- a/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
> +++ b/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
> @@ -112,7 +112,8 @@ python add_extern_guests () {
>             # Add file extension if not there
>             if not dstname.endswith('.xenguest'):
>                 dstname += '.xenguest'
> -            bb.utils.copyfile(path, guestdir + '/' + dstname)
> +            if not bb.utils.copyfile(path, guestdir + '/' + dstname):
> +                bb.fatal("Fail to copy Guest file " + path)
> }
> 
> IMAGE_PREPROCESS_COMMAND += "add_extern_guests; "
> -- 
> 2.17.1
> 
> 

Re: [meta-arm] [PATCH] [arm-autonomy] arm-autonomy-host-image-minimal: Abort on copy fail

[Jon Mason]

On Thu, May 07, 2020 at 12:17:22PM +0100, Bertrand Marquis wrote:
> From: Diego Sueiro <diego.sueiro@arm.com>
> 
> If the guest image copy fails we need to abort the do_image execution.
> 
> Change-Id: I3785a0828e271ed27eb7f9212804b5b9b39f79ac
> Issue-Id: SCM-990
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>

Pulled into the master branch.

Thanks,
Jon

> ---
>  .../recipes-core/images/arm-autonomy-host-image-minimal.bb     | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb b/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
> index 3859f52..5b20fa0 100644
> --- a/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
> +++ b/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
> @@ -112,7 +112,8 @@ python add_extern_guests () {
>              # Add file extension if not there
>              if not dstname.endswith('.xenguest'):
>                  dstname += '.xenguest'
> -            bb.utils.copyfile(path, guestdir + '/' + dstname)
> +            if not bb.utils.copyfile(path, guestdir + '/' + dstname):
> +                bb.fatal("Fail to copy Guest file " + path)
>  }
>  
>  IMAGE_PREPROCESS_COMMAND += "add_extern_guests; "
> -- 
> 2.17.1
> 

>