* [PATCH] x86/time: Identify the platform timer before attempting to probe it
@ 2018-11-15 16:22 Andrew Cooper
2018-11-15 16:28 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2018-11-15 16:22 UTC (permalink / raw)
To: Xen-devel
Cc: Andrew Cooper, Wei Liu, Brian Woods, Jan Beulich, Roger Pau Monné
When platform timer initialisation fails due to missing interrupts, hardware
tends to livelock without identifying the timer in use.
Leave a trace around to help debugging.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Brian Woods <brian.woods@amd.com>
---
xen/arch/x86/time.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index 24d4c27..992540a 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -795,6 +795,7 @@ static u64 __init init_platform_timer(void)
for ( i = 0; i < ARRAY_SIZE(plt_timers); i++ )
{
pts = plt_timers[i];
+ printk(XENLOG_DEBUG "Probing platform timer %s\n", pts->name);
if ( (rc = try_platform_timer(pts)) > 0 )
break;
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/time: Identify the platform timer before attempting to probe it
2018-11-15 16:22 [PATCH] x86/time: Identify the platform timer before attempting to probe it Andrew Cooper
@ 2018-11-15 16:28 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2018-11-15 16:28 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Wei Liu, Xen-devel, Brian Woods, Roger Pau Monne
>>> On 15.11.18 at 17:22, <andrew.cooper3@citrix.com> wrote:
> When platform timer initialisation fails due to missing interrupts, hardware
> tends to livelock without identifying the timer in use.
Have you observed this on non-flawed hardware? Is there
anything that needs fixing?
> Leave a trace around to help debugging.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-15 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 16:22 [PATCH] x86/time: Identify the platform timer before attempting to probe it Andrew Cooper
2018-11-15 16:28 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.