From: "Jan Beulich" <JBeulich@suse.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1] Increase framebuffer size to todays standards
Date: Mon, 26 Nov 2018 03:31:27 -0700 [thread overview]
Message-ID: <5BFBCB7F02000078001FFD9B@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20181125191405.3028-1-olaf@aepfle.de>
>>> On 25.11.18 at 20:14, <olaf@aepfle.de> wrote:
> My notebook reports a display size of 1920x1080:
>
> (XEN) vesafb: framebuffer at 0xd0000000, mapped to 0xffff82c000201000, using 8128k, total 8128k
> (XEN) vesafb: mode is 1920x1080x32, linelength=7680, font 8x16
> (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:16:8:0
>
> The hardcoded values feel arbitrary, so just bump them to fix my system.
> The filters for notebooks at https://geizhals.eu/ indicate the upper
> limit could be even larger, like 3840x2160.
And I think a change like this should (a) address the more general
case rather than just your laptop (or laptops in general) and (b)
actually add some headroom. Hence at the very least I'd see us
go to 4096x3072. WHUXGA would even call for 7680x4800.
> Fixes commit e7cb35e8b1b8f872d906800c72f92f10d701f79c ("xen: introduce a
> generic framebuffer driver")
I don't think this is appropriate here. Once further bumping turns
out necessary, would that then be a fix to your change here? A
proper "fix" would imo only be to get rid of the hard coded upper
bounds. Bumping the bounds every once in a while is an expected
action.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-26 10:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 19:14 [PATCH v1] Increase framebuffer size to todays standards Olaf Hering
2018-11-26 10:31 ` Jan Beulich [this message]
2018-11-26 16:03 ` Olaf Hering
2018-11-26 16:15 ` Jan Beulich
2018-11-27 9:26 ` Julien Grall
2018-11-27 9:44 ` Jan Beulich
2018-11-27 18:17 ` Julien Grall
2018-11-28 10:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BFBCB7F02000078001FFD9B@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=olaf@aepfle.de \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.