From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>, Olaf Hering <olaf@aepfle.de>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1] Increase framebuffer size to todays standards
Date: Tue, 27 Nov 2018 09:26:59 +0000 [thread overview]
Message-ID: <ce1163a4-35fb-c0a2-4deb-97fa2f348692@arm.com> (raw)
In-Reply-To: <5BFC1C3A02000078002001EA@prv1-mh.provo.novell.com>
Hi Jan,
On 11/26/18 4:15 PM, Jan Beulich wrote:
>>>> On 26.11.18 at 17:03, <olaf@aepfle.de> wrote:
>> Am Mon, 26 Nov 2018 03:31:27 -0700
>> schrieb "Jan Beulich" <JBeulich@suse.com>:
>>
>>> And I think a change like this should (a) address the more general
>>> case rather than just your laptop (or laptops in general) and (b)
>>> actually add some headroom. Hence at the very least I'd see us
>>> go to 4096x3072. WHUXGA would even call for 7680x4800.
>>
>> So should I resend this patch with higher values, or should I remove
>> the bounds check entirely? Not sure what it is trying to achieve, the
>> framebuffer may fail either way if the BIOS provides bogus values.
>
> I have to forward this question: Stefano introduced all five MAX_*
> values here when splitting out the LFB code in commit e7cb35e8b1
> ("xen: introduce a generic framebuffer driver"). I apparently didn't
> even notice back then that three of them are entirely unused, and
> the two dimension ones had no upper bound before.
>
> Stefano: Why were all of these introduced (there's no explanation
> in the description) and what were the values derived from? Will
> anything break if we remove them?
FWIW, looking at the logs, this was introduced to cater arm framebuffer
driver. However, we dropped the only driver a few months ago as it was
not maintained. So x86 is the only user of that code today.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-27 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 19:14 [PATCH v1] Increase framebuffer size to todays standards Olaf Hering
2018-11-26 10:31 ` Jan Beulich
2018-11-26 16:03 ` Olaf Hering
2018-11-26 16:15 ` Jan Beulich
2018-11-27 9:26 ` Julien Grall [this message]
2018-11-27 9:44 ` Jan Beulich
2018-11-27 18:17 ` Julien Grall
2018-11-28 10:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1163a4-35fb-c0a2-4deb-97fa2f348692@arm.com \
--to=julien.grall@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=olaf@aepfle.de \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.