* [PATCH] vhost: correct the related warning message
@ 2018-12-13 1:10 wangyan
2018-12-13 2:03 ` Michael S. Tsirkin
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: wangyan @ 2018-12-13 1:10 UTC (permalink / raw)
To: mst, jasowang; +Cc: kvm, virtualization, netdev, piaojun, hch, viro
Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Signed-off-by: Yan Wang <wangyan122@huawei.com>
Reviewed-by: Jun Piao <piaojun@huawei.com>
---
drivers/vhost/scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 50dffe8..b459b69 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
&vc->out_iter))) {
- vq_err(vq, "Faulted on copy_from_iter\n");
+ vq_err(vq, "Faulted on copy_from_iter_full\n");
} else if (unlikely(*vc->lunp != 1)) {
/* virtio-scsi spec requires byte 0 of the lun to be 1 */
vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);
@@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
se_tpg = &tpg->se_tpg;
ret = target_depend_item(&se_tpg->tpg_group.cg_item);
if (ret) {
- pr_warn("configfs_depend_item() failed: %d\n", ret);
+ pr_warn("target_depend_item() failed: %d\n", ret);
kfree(vs_tpg);
mutex_unlock(&tpg->tv_tpg_mutex);
goto out;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] vhost: correct the related warning message
2018-12-13 1:10 [PATCH] vhost: correct the related warning message wangyan
2018-12-13 2:03 ` Michael S. Tsirkin
@ 2018-12-13 2:03 ` Michael S. Tsirkin
2018-12-13 9:05 ` Sergei Shtylyov
2 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2018-12-13 2:03 UTC (permalink / raw)
To: wangyan; +Cc: jasowang, kvm, virtualization, netdev, piaojun, hch, viro
On Thu, Dec 13, 2018 at 09:10:14AM +0800, wangyan wrote:
> Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
> 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
>
> Signed-off-by: Yan Wang <wangyan122@huawei.com>
> Reviewed-by: Jun Piao <piaojun@huawei.com>
Applied, thanks!
> ---
> drivers/vhost/scsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 50dffe8..b459b69 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
>
> if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
> &vc->out_iter))) {
> - vq_err(vq, "Faulted on copy_from_iter\n");
> + vq_err(vq, "Faulted on copy_from_iter_full\n");
> } else if (unlikely(*vc->lunp != 1)) {
> /* virtio-scsi spec requires byte 0 of the lun to be 1 */
> vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);
> @@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
> se_tpg = &tpg->se_tpg;
> ret = target_depend_item(&se_tpg->tpg_group.cg_item);
> if (ret) {
> - pr_warn("configfs_depend_item() failed: %d\n", ret);
> + pr_warn("target_depend_item() failed: %d\n", ret);
> kfree(vs_tpg);
> mutex_unlock(&tpg->tv_tpg_mutex);
> goto out;
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] vhost: correct the related warning message
2018-12-13 1:10 [PATCH] vhost: correct the related warning message wangyan
@ 2018-12-13 2:03 ` Michael S. Tsirkin
2018-12-13 2:03 ` Michael S. Tsirkin
2018-12-13 9:05 ` Sergei Shtylyov
2 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2018-12-13 2:03 UTC (permalink / raw)
To: wangyan; +Cc: kvm, netdev, virtualization, piaojun, viro, hch
On Thu, Dec 13, 2018 at 09:10:14AM +0800, wangyan wrote:
> Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
> 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
>
> Signed-off-by: Yan Wang <wangyan122@huawei.com>
> Reviewed-by: Jun Piao <piaojun@huawei.com>
Applied, thanks!
> ---
> drivers/vhost/scsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 50dffe8..b459b69 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
>
> if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
> &vc->out_iter))) {
> - vq_err(vq, "Faulted on copy_from_iter\n");
> + vq_err(vq, "Faulted on copy_from_iter_full\n");
> } else if (unlikely(*vc->lunp != 1)) {
> /* virtio-scsi spec requires byte 0 of the lun to be 1 */
> vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);
> @@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
> se_tpg = &tpg->se_tpg;
> ret = target_depend_item(&se_tpg->tpg_group.cg_item);
> if (ret) {
> - pr_warn("configfs_depend_item() failed: %d\n", ret);
> + pr_warn("target_depend_item() failed: %d\n", ret);
> kfree(vs_tpg);
> mutex_unlock(&tpg->tv_tpg_mutex);
> goto out;
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] vhost: correct the related warning message
2018-12-13 1:10 [PATCH] vhost: correct the related warning message wangyan
2018-12-13 2:03 ` Michael S. Tsirkin
2018-12-13 2:03 ` Michael S. Tsirkin
@ 2018-12-13 9:05 ` Sergei Shtylyov
2018-12-13 15:21 ` Michael S. Tsirkin
2018-12-13 15:21 ` Michael S. Tsirkin
2 siblings, 2 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2018-12-13 9:05 UTC (permalink / raw)
To: wangyan, mst, jasowang; +Cc: kvm, netdev, virtualization, piaojun, viro, hch
On 13.12.2018 4:10, wangyan wrote:
> Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
> 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Fixes: d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
tf_subsystem")
Fixes: cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
friends")
But no line wrapping allowed (can't find how to turn it off in my mailer).
> Signed-off-by: Yan Wang <wangyan122@huawei.com>
> Reviewed-by: Jun Piao <piaojun@huawei.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] vhost: correct the related warning message
2018-12-13 9:05 ` Sergei Shtylyov
2018-12-13 15:21 ` Michael S. Tsirkin
@ 2018-12-13 15:21 ` Michael S. Tsirkin
2018-12-13 20:06 ` Sergei Shtylyov
2018-12-13 20:06 ` Sergei Shtylyov
1 sibling, 2 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2018-12-13 15:21 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: wangyan, jasowang, kvm, virtualization, netdev, piaojun, hch, viro
On Thu, Dec 13, 2018 at 12:05:31PM +0300, Sergei Shtylyov wrote:
> On 13.12.2018 4:10, wangyan wrote:
>
> > Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
> > 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
>
> Fixes: d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
> tf_subsystem")
> Fixes: cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
> friends")
>
> But no line wrapping allowed (can't find how to turn it off in my mailer).
Well is the standard really sane if people can't find a way to
follow it without being forced to use a specific mailer?
> > Signed-off-by: Yan Wang <wangyan122@huawei.com>
> > Reviewed-by: Jun Piao <piaojun@huawei.com>
> [...]
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] vhost: correct the related warning message
2018-12-13 9:05 ` Sergei Shtylyov
@ 2018-12-13 15:21 ` Michael S. Tsirkin
2018-12-13 15:21 ` Michael S. Tsirkin
1 sibling, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2018-12-13 15:21 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: kvm, netdev, virtualization, piaojun, viro, hch, wangyan
On Thu, Dec 13, 2018 at 12:05:31PM +0300, Sergei Shtylyov wrote:
> On 13.12.2018 4:10, wangyan wrote:
>
> > Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
> > 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
>
> Fixes: d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
> tf_subsystem")
> Fixes: cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
> friends")
>
> But no line wrapping allowed (can't find how to turn it off in my mailer).
Well is the standard really sane if people can't find a way to
follow it without being forced to use a specific mailer?
> > Signed-off-by: Yan Wang <wangyan122@huawei.com>
> > Reviewed-by: Jun Piao <piaojun@huawei.com>
> [...]
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] vhost: correct the related warning message
2018-12-13 15:21 ` Michael S. Tsirkin
2018-12-13 20:06 ` Sergei Shtylyov
@ 2018-12-13 20:06 ` Sergei Shtylyov
1 sibling, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2018-12-13 20:06 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: wangyan, jasowang, kvm, virtualization, netdev, piaojun, hch, viro
On 12/13/2018 06:21 PM, Michael S. Tsirkin wrote:
>>> Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
>>> 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
>>
>> Fixes: d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
>> tf_subsystem")
>> Fixes: cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
>> friends")
>>
>> But no line wrapping allowed (can't find how to turn it off in my mailer).
>
> Well is the standard really sane if people can't find a way to
> follow it without being forced to use a specific mailer?
Hum, my mail looked correct, although I wasn't able to get the editor to NOT
wrap my lines. Go figure... :-)
>>> Signed-off-by: Yan Wang <wangyan122@huawei.com>
>>> Reviewed-by: Jun Piao <piaojun@huawei.com>
>> [...]
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] vhost: correct the related warning message
2018-12-13 15:21 ` Michael S. Tsirkin
@ 2018-12-13 20:06 ` Sergei Shtylyov
2018-12-13 20:06 ` Sergei Shtylyov
1 sibling, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2018-12-13 20:06 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: kvm, netdev, virtualization, piaojun, viro, hch, wangyan
On 12/13/2018 06:21 PM, Michael S. Tsirkin wrote:
>>> Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
>>> 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
>>
>> Fixes: d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
>> tf_subsystem")
>> Fixes: cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
>> friends")
>>
>> But no line wrapping allowed (can't find how to turn it off in my mailer).
>
> Well is the standard really sane if people can't find a way to
> follow it without being forced to use a specific mailer?
Hum, my mail looked correct, although I wasn't able to get the editor to NOT
wrap my lines. Go figure... :-)
>>> Signed-off-by: Yan Wang <wangyan122@huawei.com>
>>> Reviewed-by: Jun Piao <piaojun@huawei.com>
>> [...]
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-12-13 20:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 1:10 [PATCH] vhost: correct the related warning message wangyan
2018-12-13 2:03 ` Michael S. Tsirkin
2018-12-13 2:03 ` Michael S. Tsirkin
2018-12-13 9:05 ` Sergei Shtylyov
2018-12-13 15:21 ` Michael S. Tsirkin
2018-12-13 15:21 ` Michael S. Tsirkin
2018-12-13 20:06 ` Sergei Shtylyov
2018-12-13 20:06 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.