All of lore.kernel.org
 help / color / mirror / Atom feed
* [Printing-architecture] Bug in ippfind
@ 2013-07-19 21:59 Till Kamppeter
  2013-07-22 11:30 ` Michael Sweet
  0 siblings, 1 reply; 4+ messages in thread
From: Till Kamppeter @ 2013-07-19 21:59 UTC (permalink / raw)
  To: Michael Sweet; +Cc: Open Printing

Hi,

I have packaged CUPS 1.7.0 RC1 for Ubuntu Raring (13.04) and Saucy
(13.10) and uploaded them to my PPA
(https://launchpad.net/~till-kamppeter/+archive/ppa).

Then I have tested the new ippfind on Saucy by simply running

ippfind

The result is

ipp://till-lenovo.local:30466/printers/Berlin
ipp://till-lenovo.local:30466/printers/Berlin
ipp://till-lenovo.local:30466/printers/Berlin
ipp://till-lenovo.local:30466/printers/Budapest
ipp://till-lenovo.local:30466/printers/LaBoheme
ipp://till-lenovo.local:30466/printers/LaTraviata
ipp://till-lenovo.local:30466/printers/Mailand
ipp://till-lenovo.local:30466/printers/Marrakech
ipp://HPOccam.local:30466/ipp/printer
ipp://till-lenovo.local:30466/printers/Paris
ipp://till-lenovo.local:30466/printers/SanFrancisco
ipp://till-lenovo.local:30466/printers/SanFranciscoFax
ipp://till-lenovo.local:30466/printers/Santorini
ipp://till-lenovo.local:30466/printers/Singapur
ipp://till-lenovo.local:30466/printers/Tokyo
ipp://till-lenovo.local:30466/printers/Wien
ipp://NPI90E6C1.local:30466/NPI90E6C1

It should be port 631 and not 30466. Looks like an endian problem or so.
I tested on an x86_64 system running Ubuntu Saucy.

   Till

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Printing-architecture] Bug in ippfind
  2013-07-19 21:59 [Printing-architecture] Bug in ippfind Till Kamppeter
@ 2013-07-22 11:30 ` Michael Sweet
  2013-07-22 14:58   ` Michael Sweet
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Sweet @ 2013-07-22 11:30 UTC (permalink / raw)
  To: Till Kamppeter; +Cc: Open Printing

Till,

Filed the following Apple bug to track this:

    <rdar://problem/14508324> cups.org: ippfind endian issue on Linux/Avahi

I think this *is* just an endian issue, and it is limited to Avahi (strange I didn't notice it when I tested, but an easy fix)

On 2013-07-19, at 5:59 PM, Till Kamppeter <till.kamppeter@gmail.com> wrote:

> Hi,
> 
> I have packaged CUPS 1.7.0 RC1 for Ubuntu Raring (13.04) and Saucy
> (13.10) and uploaded them to my PPA
> (https://launchpad.net/~till-kamppeter/+archive/ppa).
> 
> Then I have tested the new ippfind on Saucy by simply running
> 
> ippfind
> 
> The result is
> 
> ipp://till-lenovo.local:30466/printers/Berlin
> ipp://till-lenovo.local:30466/printers/Berlin
> ipp://till-lenovo.local:30466/printers/Berlin
> ipp://till-lenovo.local:30466/printers/Budapest
> ipp://till-lenovo.local:30466/printers/LaBoheme
> ipp://till-lenovo.local:30466/printers/LaTraviata
> ipp://till-lenovo.local:30466/printers/Mailand
> ipp://till-lenovo.local:30466/printers/Marrakech
> ipp://HPOccam.local:30466/ipp/printer
> ipp://till-lenovo.local:30466/printers/Paris
> ipp://till-lenovo.local:30466/printers/SanFrancisco
> ipp://till-lenovo.local:30466/printers/SanFranciscoFax
> ipp://till-lenovo.local:30466/printers/Santorini
> ipp://till-lenovo.local:30466/printers/Singapur
> ipp://till-lenovo.local:30466/printers/Tokyo
> ipp://till-lenovo.local:30466/printers/Wien
> ipp://NPI90E6C1.local:30466/NPI90E6C1
> 
> It should be port 631 and not 30466. Looks like an endian problem or so.
> I tested on an x86_64 system running Ubuntu Saucy.
> 
>   Till

_________________________________________________________
Michael Sweet, Senior Printing System Engineer, PWG Chair


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Printing-architecture] Bug in ippfind
  2013-07-22 11:30 ` Michael Sweet
@ 2013-07-22 14:58   ` Michael Sweet
  2013-07-22 16:46     ` Till Kamppeter
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Sweet @ 2013-07-22 14:58 UTC (permalink / raw)
  To: Till Kamppeter; +Cc: Open Printing

[-- Attachment #1: Type: text/plain, Size: 14 bytes --]

And the fix:


[-- Attachment #2: rdar14508324.patch --]
[-- Type: application/octet-stream, Size: 407 bytes --]

Index: test/ippfind.c
===================================================================
--- test/ippfind.c	(revision 11163)
+++ test/ippfind.c	(working copy)
@@ -2618,7 +2618,7 @@
 
   service->is_resolved = 1;
   service->host        = strdup(hostTarget);
-  service->port        = ntohs(port);
+  service->port        = port;
 
  /*
   * Loop through the TXT key/value pairs and add them to an array...

[-- Attachment #3: Type: text/plain, Size: 2158 bytes --]


On 2013-07-22, at 7:30 AM, Michael Sweet <msweet@apple.com> wrote:

> Till,
> 
> Filed the following Apple bug to track this:
> 
>    <rdar://problem/14508324> cups.org: ippfind endian issue on Linux/Avahi
> 
> I think this *is* just an endian issue, and it is limited to Avahi (strange I didn't notice it when I tested, but an easy fix)
> 
> On 2013-07-19, at 5:59 PM, Till Kamppeter <till.kamppeter@gmail.com> wrote:
> 
>> Hi,
>> 
>> I have packaged CUPS 1.7.0 RC1 for Ubuntu Raring (13.04) and Saucy
>> (13.10) and uploaded them to my PPA
>> (https://launchpad.net/~till-kamppeter/+archive/ppa).
>> 
>> Then I have tested the new ippfind on Saucy by simply running
>> 
>> ippfind
>> 
>> The result is
>> 
>> ipp://till-lenovo.local:30466/printers/Berlin
>> ipp://till-lenovo.local:30466/printers/Berlin
>> ipp://till-lenovo.local:30466/printers/Berlin
>> ipp://till-lenovo.local:30466/printers/Budapest
>> ipp://till-lenovo.local:30466/printers/LaBoheme
>> ipp://till-lenovo.local:30466/printers/LaTraviata
>> ipp://till-lenovo.local:30466/printers/Mailand
>> ipp://till-lenovo.local:30466/printers/Marrakech
>> ipp://HPOccam.local:30466/ipp/printer
>> ipp://till-lenovo.local:30466/printers/Paris
>> ipp://till-lenovo.local:30466/printers/SanFrancisco
>> ipp://till-lenovo.local:30466/printers/SanFranciscoFax
>> ipp://till-lenovo.local:30466/printers/Santorini
>> ipp://till-lenovo.local:30466/printers/Singapur
>> ipp://till-lenovo.local:30466/printers/Tokyo
>> ipp://till-lenovo.local:30466/printers/Wien
>> ipp://NPI90E6C1.local:30466/NPI90E6C1
>> 
>> It should be port 631 and not 30466. Looks like an endian problem or so.
>> I tested on an x86_64 system running Ubuntu Saucy.
>> 
>>  Till
> 
> _________________________________________________________
> Michael Sweet, Senior Printing System Engineer, PWG Chair
> 
> _______________________________________________
> Printing-architecture mailing list
> Printing-architecture@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/printing-architecture

_________________________________________________________
Michael Sweet, Senior Printing System Engineer, PWG Chair


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Printing-architecture] Bug in ippfind
  2013-07-22 14:58   ` Michael Sweet
@ 2013-07-22 16:46     ` Till Kamppeter
  0 siblings, 0 replies; 4+ messages in thread
From: Till Kamppeter @ 2013-07-22 16:46 UTC (permalink / raw)
  To: Michael Sweet; +Cc: Open Printing

Thank you very much. I have applied the patch and it works.

   Till



On 07/22/2013 04:58 PM, Michael Sweet wrote:
> And the fix:
> 
> 
> 
> 
> On 2013-07-22, at 7:30 AM, Michael Sweet <msweet@apple.com> wrote:
> 
>> Till,
>>
>> Filed the following Apple bug to track this:
>>
>>    <rdar://problem/14508324> cups.org: ippfind endian issue on Linux/Avahi
>>
>> I think this *is* just an endian issue, and it is limited to Avahi (strange I didn't notice it when I tested, but an easy fix)
>>
>> On 2013-07-19, at 5:59 PM, Till Kamppeter <till.kamppeter@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> I have packaged CUPS 1.7.0 RC1 for Ubuntu Raring (13.04) and Saucy
>>> (13.10) and uploaded them to my PPA
>>> (https://launchpad.net/~till-kamppeter/+archive/ppa).
>>>
>>> Then I have tested the new ippfind on Saucy by simply running
>>>
>>> ippfind
>>>
>>> The result is
>>>
>>> ipp://till-lenovo.local:30466/printers/Berlin
>>> ipp://till-lenovo.local:30466/printers/Berlin
>>> ipp://till-lenovo.local:30466/printers/Berlin
>>> ipp://till-lenovo.local:30466/printers/Budapest
>>> ipp://till-lenovo.local:30466/printers/LaBoheme
>>> ipp://till-lenovo.local:30466/printers/LaTraviata
>>> ipp://till-lenovo.local:30466/printers/Mailand
>>> ipp://till-lenovo.local:30466/printers/Marrakech
>>> ipp://HPOccam.local:30466/ipp/printer
>>> ipp://till-lenovo.local:30466/printers/Paris
>>> ipp://till-lenovo.local:30466/printers/SanFrancisco
>>> ipp://till-lenovo.local:30466/printers/SanFranciscoFax
>>> ipp://till-lenovo.local:30466/printers/Santorini
>>> ipp://till-lenovo.local:30466/printers/Singapur
>>> ipp://till-lenovo.local:30466/printers/Tokyo
>>> ipp://till-lenovo.local:30466/printers/Wien
>>> ipp://NPI90E6C1.local:30466/NPI90E6C1
>>>
>>> It should be port 631 and not 30466. Looks like an endian problem or so.
>>> I tested on an x86_64 system running Ubuntu Saucy.
>>>
>>>  Till
>>
>> _________________________________________________________
>> Michael Sweet, Senior Printing System Engineer, PWG Chair
>>
>> _______________________________________________
>> Printing-architecture mailing list
>> Printing-architecture@lists.linux-foundation.org
>> https://lists.linuxfoundation.org/mailman/listinfo/printing-architecture
> 
> _________________________________________________________
> Michael Sweet, Senior Printing System Engineer, PWG Chair
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-07-22 16:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-19 21:59 [Printing-architecture] Bug in ippfind Till Kamppeter
2013-07-22 11:30 ` Michael Sweet
2013-07-22 14:58   ` Michael Sweet
2013-07-22 16:46     ` Till Kamppeter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.