* [PATCH 0/4] Disentangle PCI from IOMMU maintainership
@ 2019-01-04 10:33 Roger Pau Monne
2019-01-04 10:33 ` [PATCH 1/4] maintainers: always use hard tabs Roger Pau Monne
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Roger Pau Monne @ 2019-01-04 10:33 UTC (permalink / raw)
To: xen-devel; +Cc: Roger Pau Monne
Hello,
Current arrangement of the PCI code puts it under vendor agnostic IOMMU
maintainership, which is IMO not very accurate. The aim of this series
is to add a new maintainership section containing the PCI code in Xen,
and add myself as reviewer.
Due to my work on PVH Dom0, which makes heavy use of the HVM
pci-passthrough infrastructure, I've become acquainted with the PCI code
and I think I can help with reviews.
Roger Pau Monne (4):
maintainers: always use hard tabs
x86/passthrough: move io.c to the x86 subfolder
x86/passthrough: put the x86 folder under x86 maintainership
pci: add a pci section to the maintainers file
MAINTAINERS | 77 +++++++++++++++-----------
xen/drivers/passthrough/Makefile | 3 -
xen/drivers/passthrough/x86/Makefile | 1 +
xen/drivers/passthrough/{ => x86}/io.c | 0
4 files changed, 45 insertions(+), 36 deletions(-)
rename xen/drivers/passthrough/{ => x86}/io.c (100%)
--
2.17.2 (Apple Git-113)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] maintainers: always use hard tabs
2019-01-04 10:33 [PATCH 0/4] Disentangle PCI from IOMMU maintainership Roger Pau Monne
@ 2019-01-04 10:33 ` Roger Pau Monne
2019-01-04 17:00 ` Jan Beulich
2019-01-04 10:33 ` [PATCH 2/4] x86/passthrough: move io.c to the x86 subfolder Roger Pau Monne
` (2 subsequent siblings)
3 siblings, 1 reply; 14+ messages in thread
From: Roger Pau Monne @ 2019-01-04 10:33 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, Jan Beulich, Roger Pau Monne
As that seems to be the prevailing style.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
---
MAINTAINERS | 66 ++++++++++++++++++++++++++---------------------------
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 96a0518f49..e99d39eb47 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -215,13 +215,13 @@ F: xen/include/xen/device_tree.h
F: xen/drivers/passthrough/device_tree.c
EFI
-M: Jan Beulich <jbeulich@suse.com>
-S: Supported
-F: xen/arch/x86/efi/
-F: xen/common/efi/
-F: xen/include/efi/
-F: xen/include/asm-x86/efi*.h
-F: xen/include/asm-x86/x86_*/efi*.h
+M: Jan Beulich <jbeulich@suse.com>
+S: Supported
+F: xen/arch/x86/efi/
+F: xen/common/efi/
+F: xen/include/efi/
+F: xen/include/asm-x86/efi*.h
+F: xen/include/asm-x86/x86_*/efi*.h
GDBSX DEBUGGER
M: Elena Ufimtseva <elena.ufimtseva@oracle.com>
@@ -272,25 +272,25 @@ S: Odd Fixes
F: tools/debugger/kdd/
KEXEC
-M: Andrew Cooper <andrew.cooper3@citrix.com>
-S: Supported
-F: xen/common/{kexec,kimage}.c
-F: xen/include/{kexec,kimage}.h
-F: xen/arch/x86/machine_kexec.c
-F: xen/arch/x86/x86_64/kexec_reloc.S
+M: Andrew Cooper <andrew.cooper3@citrix.com>
+S: Supported
+F: xen/common/{kexec,kimage}.c
+F: xen/include/{kexec,kimage}.h
+F: xen/arch/x86/machine_kexec.c
+F: xen/arch/x86/x86_64/kexec_reloc.S
LIVEPATCH
-M: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
-M: Ross Lagerwall <ross.lagerwall@citrix.com>
-S: Supported
-F: docs/misc/livepatch.markdown
-F: tools/misc/xen-livepatch.c
-F: xen/arch/*/livepatch*
-F: xen/arch/*/*/livepatch*
-F: xen/common/livepatch*
-F: xen/include/asm-*/livepatch.h
-F: xen/include/xen/livepatch*
-F: xen/test/livepatch/*
+M: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
+M: Ross Lagerwall <ross.lagerwall@citrix.com>
+S: Supported
+F: docs/misc/livepatch.markdown
+F: tools/misc/xen-livepatch.c
+F: xen/arch/*/livepatch*
+F: xen/arch/*/*/livepatch*
+F: xen/common/livepatch*
+F: xen/include/asm-*/livepatch.h
+F: xen/include/xen/livepatch*
+F: xen/test/livepatch/*
MINI-OS
M: Samuel Thibault <samuel.thibault@ens-lyon.org>
@@ -321,9 +321,9 @@ F: xen/drivers/cpufreq/
F: xen/include/acpi/cpufreq/
PUBLIC I/O INTERFACES AND PV DRIVERS DESIGNS
-M: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
-S: Supported
-F: xen/include/public/io/
+M: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
+S: Supported
+F: xen/include/public/io/
PYTHON BINDINGS
M: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
@@ -498,12 +498,12 @@ F: tools/xentrace/
F: xen/common/trace.c
XSM/FLASK
-M: Daniel De Graaf <dgdegra@tycho.nsa.gov>
-S: Supported
-F: tools/flask/
-F: xen/include/xsm/
-F: xen/xsm/
-F: docs/misc/xsm-flask.txt
+M: Daniel De Graaf <dgdegra@tycho.nsa.gov>
+S: Supported
+F: tools/flask/
+F: xen/include/xsm/
+F: xen/xsm/
+F: docs/misc/xsm-flask.txt
THE REST
M: Andrew Cooper <andrew.cooper3@citrix.com>
--
2.17.2 (Apple Git-113)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/4] x86/passthrough: move io.c to the x86 subfolder
2019-01-04 10:33 [PATCH 0/4] Disentangle PCI from IOMMU maintainership Roger Pau Monne
2019-01-04 10:33 ` [PATCH 1/4] maintainers: always use hard tabs Roger Pau Monne
@ 2019-01-04 10:33 ` Roger Pau Monne
2019-01-04 17:03 ` Jan Beulich
2019-01-04 10:33 ` [PATCH 3/4] x86/passthrough: put the x86 folder under x86 maintainership Roger Pau Monne
2019-01-04 10:33 ` [PATCH 4/4] pci: add a pci section to the maintainers file Roger Pau Monne
3 siblings, 1 reply; 14+ messages in thread
From: Roger Pau Monne @ 2019-01-04 10:33 UTC (permalink / raw)
To: xen-devel; +Cc: Jan Beulich, Roger Pau Monne
It makes no sense for io.c to be on the top level passthrough
directory, since it's x86 specific.
No functional change.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
---
xen/drivers/passthrough/Makefile | 3 ---
xen/drivers/passthrough/x86/Makefile | 1 +
xen/drivers/passthrough/{ => x86}/io.c | 0
3 files changed, 1 insertion(+), 3 deletions(-)
rename xen/drivers/passthrough/{ => x86}/io.c (100%)
diff --git a/xen/drivers/passthrough/Makefile b/xen/drivers/passthrough/Makefile
index d50ab188c8..bcfea66d05 100644
--- a/xen/drivers/passthrough/Makefile
+++ b/xen/drivers/passthrough/Makefile
@@ -6,6 +6,3 @@ subdir-$(CONFIG_ARM) += arm
obj-y += iommu.o
obj-$(CONFIG_HAS_PCI) += pci.o
obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o
-
-x86-$(CONFIG_HVM) := io.o
-obj-$(CONFIG_X86) += $(x86-y)
diff --git a/xen/drivers/passthrough/x86/Makefile b/xen/drivers/passthrough/x86/Makefile
index a70cf9460d..0715ffbc00 100644
--- a/xen/drivers/passthrough/x86/Makefile
+++ b/xen/drivers/passthrough/x86/Makefile
@@ -1,2 +1,3 @@
obj-y += ats.o
obj-y += iommu.o
+obj-$(CONFIG_HVM) += io.o
diff --git a/xen/drivers/passthrough/io.c b/xen/drivers/passthrough/x86/io.c
similarity index 100%
rename from xen/drivers/passthrough/io.c
rename to xen/drivers/passthrough/x86/io.c
--
2.17.2 (Apple Git-113)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/4] x86/passthrough: put the x86 folder under x86 maintainership
2019-01-04 10:33 [PATCH 0/4] Disentangle PCI from IOMMU maintainership Roger Pau Monne
2019-01-04 10:33 ` [PATCH 1/4] maintainers: always use hard tabs Roger Pau Monne
2019-01-04 10:33 ` [PATCH 2/4] x86/passthrough: move io.c to the x86 subfolder Roger Pau Monne
@ 2019-01-04 10:33 ` Roger Pau Monne
2019-01-07 9:51 ` Jan Beulich
2019-01-04 10:33 ` [PATCH 4/4] pci: add a pci section to the maintainers file Roger Pau Monne
3 siblings, 1 reply; 14+ messages in thread
From: Roger Pau Monne @ 2019-01-04 10:33 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, Jan Beulich, Roger Pau Monne
passthrough/x86 is tied to the x86 code, and as such put it under x86
maintainership.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e99d39eb47..a40fa61eb2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -257,6 +257,7 @@ F: xen/drivers/passthrough/
X: xen/drivers/passthrough/amd/
X: xen/drivers/passthrough/arm/
X: xen/drivers/passthrough/vtd/
+X: xen/drivers/passthrough/x86/
X: xen/drivers/passthrough/device_tree.c
F: xen/include/xen/iommu.h
@@ -445,6 +446,7 @@ R: Roger Pau Monné <roger.pau@citrix.com>
S: Supported
L: xen-devel@lists.xenproject.org
F: xen/arch/x86/
+F: xen/drivers/passthrough/x86/
F: xen/include/asm-x86/
F: xen/include/public/arch-x86/
F: tools/firmware/hvmloader/
--
2.17.2 (Apple Git-113)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/4] pci: add a pci section to the maintainers file
2019-01-04 10:33 [PATCH 0/4] Disentangle PCI from IOMMU maintainership Roger Pau Monne
` (2 preceding siblings ...)
2019-01-04 10:33 ` [PATCH 3/4] x86/passthrough: put the x86 folder under x86 maintainership Roger Pau Monne
@ 2019-01-04 10:33 ` Roger Pau Monne
2019-01-07 9:56 ` Jan Beulich
3 siblings, 1 reply; 14+ messages in thread
From: Roger Pau Monne @ 2019-01-04 10:33 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, Jan Beulich, Roger Pau Monne
And add myself as reviewer.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
---
MAINTAINERS | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a40fa61eb2..8326f55a31 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -259,6 +259,7 @@ X: xen/drivers/passthrough/arm/
X: xen/drivers/passthrough/vtd/
X: xen/drivers/passthrough/x86/
X: xen/drivers/passthrough/device_tree.c
+X: xen/drivers/passthrough/pci.c
F: xen/include/xen/iommu.h
KCONFIG
@@ -312,6 +313,14 @@ M: Wei Liu <wei.liu2@citrix.com>
S: Supported
T: git https://xenbits.xenproject.org/git-http/ovmf.git
+PCI
+M: Jan Beulich <jbeulich@suse.com>
+R: Roger Pau Monné <roger.pau@citrix.com>
+S: Supported
+F: xen/drivers/passthrough/pci.c
+F: xen/drivers/pci/
+F: xen/include/xen/pci*
+
POWER MANAGEMENT
M: Jan Beulich <jbeulich@suse.com>
S: Supported
--
2.17.2 (Apple Git-113)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] maintainers: always use hard tabs
2019-01-04 10:33 ` [PATCH 1/4] maintainers: always use hard tabs Roger Pau Monne
@ 2019-01-04 17:00 ` Jan Beulich
0 siblings, 0 replies; 14+ messages in thread
From: Jan Beulich @ 2019-01-04 17:00 UTC (permalink / raw)
To: Roger Pau Monne
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, xen-devel
>>> On 04.01.19 at 11:33, <roger.pau@citrix.com> wrote:
> As that seems to be the prevailing style.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Thanks for doing this; I too have been meaning to.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/4] x86/passthrough: move io.c to the x86 subfolder
2019-01-04 10:33 ` [PATCH 2/4] x86/passthrough: move io.c to the x86 subfolder Roger Pau Monne
@ 2019-01-04 17:03 ` Jan Beulich
2019-01-07 12:11 ` Roger Pau Monné
0 siblings, 1 reply; 14+ messages in thread
From: Jan Beulich @ 2019-01-04 17:03 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Julien Grall, Stefano Stabellini
>>> On 04.01.19 at 11:33, <roger.pau@citrix.com> wrote:
> It makes no sense for io.c to be on the top level passthrough
> directory, since it's x86 specific.
I'm not sure it really is. It's largely about interrupt arrangements
for guests, which (being PCI-related) may or may not be re-
usable by Arm once they get to support PCI. I'd like to have an
Arm maintainer's view on this before giving an ack here. And
once moving it around, changing its name to something more
suitable should also be considered.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/4] x86/passthrough: put the x86 folder under x86 maintainership
2019-01-04 10:33 ` [PATCH 3/4] x86/passthrough: put the x86 folder under x86 maintainership Roger Pau Monne
@ 2019-01-07 9:51 ` Jan Beulich
2019-01-07 12:14 ` Roger Pau Monné
0 siblings, 1 reply; 14+ messages in thread
From: Jan Beulich @ 2019-01-07 9:51 UTC (permalink / raw)
To: Roger Pau Monne
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, xen-devel
>>> On 04.01.19 at 11:33, <roger.pau@citrix.com> wrote:
> passthrough/x86 is tied to the x86 code, and as such put it under x86
> maintainership.
It is tied to both, so at the very least I object to ...
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -257,6 +257,7 @@ F: xen/drivers/passthrough/
> X: xen/drivers/passthrough/amd/
> X: xen/drivers/passthrough/arm/
> X: xen/drivers/passthrough/vtd/
> +X: xen/drivers/passthrough/x86/
... this; the Arm entry here is questionable too, imo.
> @@ -445,6 +446,7 @@ R: Roger Pau Monné <roger.pau@citrix.com>
> S: Supported
> L: xen-devel@lists.xenproject.org
> F: xen/arch/x86/
> +F: xen/drivers/passthrough/x86/
This one's debatable.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] pci: add a pci section to the maintainers file
2019-01-04 10:33 ` [PATCH 4/4] pci: add a pci section to the maintainers file Roger Pau Monne
@ 2019-01-07 9:56 ` Jan Beulich
2019-01-07 12:35 ` Roger Pau Monné
0 siblings, 1 reply; 14+ messages in thread
From: Jan Beulich @ 2019-01-07 9:56 UTC (permalink / raw)
To: Roger Pau Monne
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, xen-devel
>>> On 04.01.19 at 11:33, <roger.pau@citrix.com> wrote:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -259,6 +259,7 @@ X: xen/drivers/passthrough/arm/
> X: xen/drivers/passthrough/vtd/
> X: xen/drivers/passthrough/x86/
> X: xen/drivers/passthrough/device_tree.c
> +X: xen/drivers/passthrough/pci.c
Much like for patch 3, I'm not convinced this is appropriate.
> @@ -312,6 +313,14 @@ M: Wei Liu <wei.liu2@citrix.com>
> S: Supported
> T: git https://xenbits.xenproject.org/git-http/ovmf.git
>
> +PCI
> +M: Jan Beulich <jbeulich@suse.com>
> +R: Roger Pau Monné <roger.pau@citrix.com>
> +S: Supported
> +F: xen/drivers/passthrough/pci.c
> +F: xen/drivers/pci/
> +F: xen/include/xen/pci*
I'm fine with the last two, but I think truly IOMMU-independent
code would better be moved from the file named first to a file in
the directory named second.
The whole situation arises from the origin of this code, which
back then was needed solely for the purposes of IOMMU
management.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/4] x86/passthrough: move io.c to the x86 subfolder
2019-01-04 17:03 ` Jan Beulich
@ 2019-01-07 12:11 ` Roger Pau Monné
2019-01-07 12:45 ` Jan Beulich
0 siblings, 1 reply; 14+ messages in thread
From: Roger Pau Monné @ 2019-01-07 12:11 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Julien Grall, Stefano Stabellini
On Fri, Jan 04, 2019 at 10:03:21AM -0700, Jan Beulich wrote:
> >>> On 04.01.19 at 11:33, <roger.pau@citrix.com> wrote:
> > It makes no sense for io.c to be on the top level passthrough
> > directory, since it's x86 specific.
>
> I'm not sure it really is. It's largely about interrupt arrangements
> for guests, which (being PCI-related) may or may not be re-
> usable by Arm once they get to support PCI.
The file makes heavy usage of x86 only constructs, like
hvm_pirq_dpci, hvm_irq_dpci and a lot of x86 specific HVM functions.
This could indeed be used by ARM in the future if such functions and
structures are implemented on ARM, but it would certainly require
a non-trivial amount of changes to this file and other code.
As it stands now this code is x86 specific, and as such it makes more
sense IMO to reside in the x86 sub-folder.
I agree it makes sense to rename, maybe x86/irq.c or x86/interrupt.c?
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/4] x86/passthrough: put the x86 folder under x86 maintainership
2019-01-07 9:51 ` Jan Beulich
@ 2019-01-07 12:14 ` Roger Pau Monné
2019-01-07 12:46 ` Jan Beulich
0 siblings, 1 reply; 14+ messages in thread
From: Roger Pau Monné @ 2019-01-07 12:14 UTC (permalink / raw)
To: Jan Beulich
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, xen-devel
On Mon, Jan 07, 2019 at 02:51:54AM -0700, Jan Beulich wrote:
> >>> On 04.01.19 at 11:33, <roger.pau@citrix.com> wrote:
> > passthrough/x86 is tied to the x86 code, and as such put it under x86
> > maintainership.
>
> It is tied to both, so at the very least I object to ...
>
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -257,6 +257,7 @@ F: xen/drivers/passthrough/
> > X: xen/drivers/passthrough/amd/
> > X: xen/drivers/passthrough/arm/
> > X: xen/drivers/passthrough/vtd/
> > +X: xen/drivers/passthrough/x86/
>
> ... this; the Arm entry here is questionable too, imo.
>
> > @@ -445,6 +446,7 @@ R: Roger Pau Monné <roger.pau@citrix.com>
> > S: Supported
> > L: xen-devel@lists.xenproject.org
> > F: xen/arch/x86/
> > +F: xen/drivers/passthrough/x86/
>
> This one's debatable.
So you would agree to adding xen/drivers/passthrough/x86/ under x86
maintainership as long as it's also left under the generic IOMMU
support entry?
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] pci: add a pci section to the maintainers file
2019-01-07 9:56 ` Jan Beulich
@ 2019-01-07 12:35 ` Roger Pau Monné
0 siblings, 0 replies; 14+ messages in thread
From: Roger Pau Monné @ 2019-01-07 12:35 UTC (permalink / raw)
To: Jan Beulich
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, xen-devel
On Mon, Jan 07, 2019 at 02:56:23AM -0700, Jan Beulich wrote:
> >>> On 04.01.19 at 11:33, <roger.pau@citrix.com> wrote:
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -259,6 +259,7 @@ X: xen/drivers/passthrough/arm/
> > X: xen/drivers/passthrough/vtd/
> > X: xen/drivers/passthrough/x86/
> > X: xen/drivers/passthrough/device_tree.c
> > +X: xen/drivers/passthrough/pci.c
>
> Much like for patch 3, I'm not convinced this is appropriate.
>
> > @@ -312,6 +313,14 @@ M: Wei Liu <wei.liu2@citrix.com>
> > S: Supported
> > T: git https://xenbits.xenproject.org/git-http/ovmf.git
> >
> > +PCI
> > +M: Jan Beulich <jbeulich@suse.com>
> > +R: Roger Pau Monné <roger.pau@citrix.com>
> > +S: Supported
> > +F: xen/drivers/passthrough/pci.c
> > +F: xen/drivers/pci/
> > +F: xen/include/xen/pci*
>
> I'm fine with the last two, but I think truly IOMMU-independent
> code would better be moved from the file named first to a file in
> the directory named second.
Let me see if I can find a way to do such movement, I'm not sure how
entangled the code is.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/4] x86/passthrough: move io.c to the x86 subfolder
2019-01-07 12:11 ` Roger Pau Monné
@ 2019-01-07 12:45 ` Jan Beulich
0 siblings, 0 replies; 14+ messages in thread
From: Jan Beulich @ 2019-01-07 12:45 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Julien Grall, Stefano Stabellini
>>> On 07.01.19 at 13:11, <roger.pau@citrix.com> wrote:
> On Fri, Jan 04, 2019 at 10:03:21AM -0700, Jan Beulich wrote:
>> >>> On 04.01.19 at 11:33, <roger.pau@citrix.com> wrote:
>> > It makes no sense for io.c to be on the top level passthrough
>> > directory, since it's x86 specific.
>>
>> I'm not sure it really is. It's largely about interrupt arrangements
>> for guests, which (being PCI-related) may or may not be re-
>> usable by Arm once they get to support PCI.
>
> The file makes heavy usage of x86 only constructs, like
> hvm_pirq_dpci, hvm_irq_dpci and a lot of x86 specific HVM functions.
>
> This could indeed be used by ARM in the future if such functions and
> structures are implemented on ARM, but it would certainly require
> a non-trivial amount of changes to this file and other code.
>
> As it stands now this code is x86 specific, and as such it makes more
> sense IMO to reside in the x86 sub-folder.
Well, as said - I'd like to hear an Arm side opinion first.
> I agree it makes sense to rename, maybe x86/irq.c or x86/interrupt.c?
I have a slight preference for the former.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/4] x86/passthrough: put the x86 folder under x86 maintainership
2019-01-07 12:14 ` Roger Pau Monné
@ 2019-01-07 12:46 ` Jan Beulich
0 siblings, 0 replies; 14+ messages in thread
From: Jan Beulich @ 2019-01-07 12:46 UTC (permalink / raw)
To: Roger Pau Monne
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, xen-devel
>>> On 07.01.19 at 13:14, <roger.pau@citrix.com> wrote:
> On Mon, Jan 07, 2019 at 02:51:54AM -0700, Jan Beulich wrote:
>> >>> On 04.01.19 at 11:33, <roger.pau@citrix.com> wrote:
>> > passthrough/x86 is tied to the x86 code, and as such put it under x86
>> > maintainership.
>>
>> It is tied to both, so at the very least I object to ...
>>
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -257,6 +257,7 @@ F: xen/drivers/passthrough/
>> > X: xen/drivers/passthrough/amd/
>> > X: xen/drivers/passthrough/arm/
>> > X: xen/drivers/passthrough/vtd/
>> > +X: xen/drivers/passthrough/x86/
>>
>> ... this; the Arm entry here is questionable too, imo.
>>
>> > @@ -445,6 +446,7 @@ R: Roger Pau Monné <roger.pau@citrix.com>
>> > S: Supported
>> > L: xen-devel@lists.xenproject.org
>> > F: xen/arch/x86/
>> > +F: xen/drivers/passthrough/x86/
>>
>> This one's debatable.
>
> So you would agree to adding xen/drivers/passthrough/x86/ under x86
> maintainership as long as it's also left under the generic IOMMU
> support entry?
"Agree" goes to far; I think this is worth considering. I'm also not
opposed to leaving things as they are.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-01-07 12:47 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 10:33 [PATCH 0/4] Disentangle PCI from IOMMU maintainership Roger Pau Monne
2019-01-04 10:33 ` [PATCH 1/4] maintainers: always use hard tabs Roger Pau Monne
2019-01-04 17:00 ` Jan Beulich
2019-01-04 10:33 ` [PATCH 2/4] x86/passthrough: move io.c to the x86 subfolder Roger Pau Monne
2019-01-04 17:03 ` Jan Beulich
2019-01-07 12:11 ` Roger Pau Monné
2019-01-07 12:45 ` Jan Beulich
2019-01-04 10:33 ` [PATCH 3/4] x86/passthrough: put the x86 folder under x86 maintainership Roger Pau Monne
2019-01-07 9:51 ` Jan Beulich
2019-01-07 12:14 ` Roger Pau Monné
2019-01-07 12:46 ` Jan Beulich
2019-01-04 10:33 ` [PATCH 4/4] pci: add a pci section to the maintainers file Roger Pau Monne
2019-01-07 9:56 ` Jan Beulich
2019-01-07 12:35 ` Roger Pau Monné
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.