* [PATCH] sched/credit2: remove stale comment
@ 2019-01-09 12:34 Juergen Gross
2019-01-09 13:59 ` Dario Faggioli
0 siblings, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2019-01-09 12:34 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, George Dunlap, Dario Faggioli
With being the default scheduler now the comment in sched_credit2
stating it being experimental should be removed.
While at it remove the "TODO" comments already addressed.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
xen/common/sched_credit2.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index 623a325ceb..543dc3664d 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -59,19 +59,13 @@
#define TRC_CSCHED2_RUNQ_CAND_CHECK TRC_SCHED_CLASS_EVT(CSCHED2, 23)
/*
- * WARNING: This is still in an experimental phase. Status and work can be found at the
- * credit2 wiki page:
- * http://wiki.xen.org/wiki/Credit2_Scheduler_Development
- *
* TODO:
* + Hyperthreading
- * - Look for non-busy core if possible
* - "Discount" time run on a thread with busy siblings
* + Algorithm:
* - "Mixed work" problem: if a VM is playing audio (5%) but also burning cpu (e.g.,
* a flash animation in the background) can we schedule it with low enough latency
* so that audio doesn't skip?
- * - Cap and reservation: How to implement with the current system?
* + Optimizing
* - Profiling, making new algorithms, making math more efficient (no long division)
*/
--
2.16.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sched/credit2: remove stale comment
2019-01-09 12:34 [PATCH] sched/credit2: remove stale comment Juergen Gross
@ 2019-01-09 13:59 ` Dario Faggioli
2019-01-09 14:27 ` Jan Beulich
[not found] ` <5C3604D9020000780020BCF6@suse.com>
0 siblings, 2 replies; 4+ messages in thread
From: Dario Faggioli @ 2019-01-09 13:59 UTC (permalink / raw)
To: Juergen Gross, xen-devel; +Cc: George Dunlap
[-- Attachment #1.1: Type: text/plain, Size: 606 bytes --]
On Wed, 2019-01-09 at 13:34 +0100, Juergen Gross wrote:
> With being the default scheduler now the comment in sched_credit2
> stating it being experimental should be removed.
>
> While at it remove the "TODO" comments already addressed.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
>
Acked-by: Dario Faggioli <dfaggioli@suse.com>
Thanks,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sched/credit2: remove stale comment
2019-01-09 13:59 ` Dario Faggioli
@ 2019-01-09 14:27 ` Jan Beulich
[not found] ` <5C3604D9020000780020BCF6@suse.com>
1 sibling, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2019-01-09 14:27 UTC (permalink / raw)
To: Juergen Gross; +Cc: George Dunlap, xen-devel, Dario Faggioli
>>> On 09.01.19 at 14:59, <dfaggioli@suse.com> wrote:
> On Wed, 2019-01-09 at 13:34 +0100, Juergen Gross wrote:
>> With being the default scheduler now the comment in sched_credit2
>> stating it being experimental should be removed.
>>
>> While at it remove the "TODO" comments already addressed.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>
> Acked-by: Dario Faggioli <dfaggioli@suse.com>
And I guess this is fine to put in for 4.12?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <5C3604D9020000780020BCF6@suse.com>]
* Re: [PATCH] sched/credit2: remove stale comment
[not found] ` <5C3604D9020000780020BCF6@suse.com>
@ 2019-01-09 14:32 ` Juergen Gross
0 siblings, 0 replies; 4+ messages in thread
From: Juergen Gross @ 2019-01-09 14:32 UTC (permalink / raw)
To: Jan Beulich; +Cc: George Dunlap, xen-devel, Dario Faggioli
On 09/01/2019 15:27, Jan Beulich wrote:
>>>> On 09.01.19 at 14:59, <dfaggioli@suse.com> wrote:
>> On Wed, 2019-01-09 at 13:34 +0100, Juergen Gross wrote:
>>> With being the default scheduler now the comment in sched_credit2
>>> stating it being experimental should be removed.
>>>
>>> While at it remove the "TODO" comments already addressed.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>
>> Acked-by: Dario Faggioli <dfaggioli@suse.com>
>
> And I guess this is fine to put in for 4.12?
Yes:
Release-acked-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-09 14:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-09 12:34 [PATCH] sched/credit2: remove stale comment Juergen Gross
2019-01-09 13:59 ` Dario Faggioli
2019-01-09 14:27 ` Jan Beulich
[not found] ` <5C3604D9020000780020BCF6@suse.com>
2019-01-09 14:32 ` Juergen Gross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.