From: "Jan Beulich" <JBeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <stefanos@xilinx.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 2/4] xen/arm: use SYMBOL when required
Date: Thu, 10 Jan 2019 01:41:45 -0700 [thread overview]
Message-ID: <5C370549020000780020C1A5@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <1547077324-9705-2-git-send-email-sstabellini@kernel.org>
>>> On 10.01.19 at 00:42, <sstabellini@kernel.org> wrote:
> @@ -1138,9 +1138,10 @@ void free_init_memory(void)
> for ( i = 0; i < nr; i++ )
> *(p + i) = insn;
>
> - set_pte_flags_on_range(__init_begin, len, mg_clear);
> + set_pte_flags_on_range(SYMBOL(__init_begin), len, mg_clear);
> init_domheap_pages(pa, pa + len);
> - printk("Freed %ldkB init memory.\n", (long)(__init_end-__init_begin)>>10);
> + printk("Freed %ldkB init memory.\n",
> + (long)(SYMBOL(__init_end)-SYMBOL(__init_begin))>>10);
I've noticed this only here, but I can't exclude I've overlooked other
instances: I think it would be really nice if you corrected formatting
at the same time (here: add the missing blanks).
> --- a/xen/arch/arm/percpu.c
> +++ b/xen/arch/arm/percpu.c
> @@ -6,7 +6,7 @@
>
> unsigned long __per_cpu_offset[NR_CPUS];
> #define INVALID_PERCPU_AREA (-(long)__per_cpu_start)
> -#define PERCPU_ORDER (get_order_from_bytes(__per_cpu_data_end-__per_cpu_start))
> +#define PERCPU_ORDER (get_order_from_bytes(SYMBOL(__per_cpu_data_end) - SYMBOL(__per_cpu_start)))
Long line.
> @@ -37,7 +37,7 @@ static void _free_percpu_area(struct rcu_head *head)
> {
> struct free_info *info = container_of(head, struct free_info, rcu);
> unsigned int cpu = info->cpu;
> - char *p = __per_cpu_start + __per_cpu_offset[cpu];
> + char *p = SYMBOL(__per_cpu_start) + __per_cpu_offset[cpu];
> free_xenheap_pages(p, PERCPU_ORDER);
> __per_cpu_offset[cpu] = INVALID_PERCPU_AREA;
> }
As per above, to add the missing blank line would be quite nice at
this occasion.
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -772,8 +772,10 @@ void __init start_xen(unsigned long boot_phys_offset,
>
> /* Register Xen's load address as a boot module. */
> xen_bootmodule = add_boot_module(BOOTMOD_XEN,
> - (paddr_t)(uintptr_t)(_start + boot_phys_offset),
> - (paddr_t)(uintptr_t)(_end - _start + 1), false);
> + (paddr_t)(uintptr_t)(SYMBOL(_start) +
> + boot_phys_offset),
> + (paddr_t)(uintptr_t)(SYMBOL(_end) -
> + SYMBOL(_start) + 1), false);
Why you need the double casts, i.e. why does (uintptr_t) alone not
suffice?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-10 8:41 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 23:41 [PATCH v6 0/4] misc safety certification fixes Stefano Stabellini
2019-01-09 23:42 ` [PATCH v6 1/4] xen: introduce SYMBOL Stefano Stabellini
2019-01-10 2:40 ` Julien Grall
2019-01-10 8:24 ` Jan Beulich
2019-01-10 17:29 ` Stefano Stabellini
2019-01-10 18:46 ` Stewart Hildebrand
2019-01-10 19:03 ` Stefano Stabellini
2019-01-11 10:35 ` Jan Beulich
2019-01-11 17:01 ` Stefano Stabellini
2019-01-10 19:24 ` Julien Grall
2019-01-10 21:36 ` Stefano Stabellini
2019-01-10 23:31 ` Julien Grall
2019-01-11 2:14 ` Stefano Stabellini
2019-01-11 6:52 ` Juergen Gross
2019-01-11 16:52 ` Stefano Stabellini
2019-01-11 10:48 ` Jan Beulich
2019-01-11 18:04 ` Stefano Stabellini
2019-01-11 18:53 ` Stewart Hildebrand
2019-01-11 20:35 ` Julien Grall
2019-01-11 20:46 ` Stewart Hildebrand
2019-01-11 21:37 ` Stefano Stabellini
2019-01-14 3:45 ` Stewart Hildebrand
2019-01-14 10:26 ` Jan Beulich
2019-01-14 21:18 ` Stefano Stabellini
[not found] ` <1CACC1FB020000D800417A66@prv1-mh.provo.novell.com>
2019-01-15 8:21 ` Jan Beulich
2019-01-15 11:51 ` Julien Grall
[not found] ` <AB1DA25B020000B95C475325@prv1-mh.provo.novell.com>
2019-01-15 12:04 ` Jan Beulich
2019-01-15 12:23 ` Julien Grall
[not found] ` <BAE986750200003A5C475325@prv1-mh.provo.novell.com>
2019-01-15 12:44 ` Jan Beulich
2019-01-15 20:03 ` Stewart Hildebrand
2019-01-16 6:01 ` Juergen Gross
2019-01-16 10:19 ` Jan Beulich
2019-01-17 0:37 ` Stefano Stabellini
[not found] ` <B4D3ABC30200003B88BF86FB@prv1-mh.provo.novell.com>
[not found] ` <529ED2F90200004D00417A66@prv1-mh.provo.novell.com>
2019-01-17 11:45 ` Jan Beulich
2019-01-18 1:24 ` Stefano Stabellini
[not found] ` <76A2DEED0200005600417A66@prv1-mh.provo.novell.com>
2019-01-18 9:54 ` Jan Beulich
2019-01-18 10:48 ` Julien Grall
[not found] ` <9F511FC70200005E5C475325@prv1-mh.provo.novell.com>
2019-01-18 11:09 ` Jan Beulich
2019-01-18 15:22 ` Julien Grall
[not found] ` <3A8206D8020000035C475325@prv1-mh.provo.novell.com>
2019-01-21 9:39 ` Jan Beulich
2019-01-21 9:34 ` Jan Beulich
2019-01-21 10:22 ` Julien Grall
[not found] ` <E16AB350020000435C475325@prv1-mh.provo.novell.com>
2019-01-21 10:31 ` Jan Beulich
2019-01-21 23:15 ` Stefano Stabellini
[not found] ` <5EA2B4FA0200008000417A66@prv1-mh.provo.novell.com>
2019-01-22 9:06 ` Jan Beulich
2019-01-18 23:05 ` Stefano Stabellini
2019-01-21 5:24 ` Stewart Hildebrand
[not found] ` <5A96F2FD0200008D00417A66@prv1-mh.provo.novell.com>
2019-01-21 9:50 ` Jan Beulich
2019-01-21 23:41 ` Stefano Stabellini
2019-01-22 6:08 ` Juergen Gross
[not found] ` <42A2C4FA0200009000417A66@prv1-mh.provo.novell.com>
2019-01-22 9:16 ` Jan Beulich
2019-02-01 18:52 ` George Dunlap
2019-02-01 20:53 ` Stefano Stabellini
[not found] ` <58377FAD0200004688BF86FB@prv1-mh.provo.novell.com>
2019-01-21 10:06 ` Jan Beulich
2019-02-06 15:41 ` Ian Jackson
[not found] ` <C8F95655020000CAB8D7C7D4@prv1-mh.provo.novell.com>
[not found] ` <5867EFE6020000DB00417A66@prv1-mh.provo.novell.com>
[not found] ` <DACE7A5F020000B1B8D7C7D4@prv1-mh.provo.novell.com>
2019-02-07 14:51 ` Jan Beulich
2019-01-15 23:36 ` Stefano Stabellini
2019-01-16 8:47 ` Juergen Gross
[not found] ` <2EA6D6FD0200001F00417A66@prv1-mh.provo.novell.com>
2019-01-16 10:25 ` Jan Beulich
2019-01-17 0:41 ` Stefano Stabellini
[not found] ` <4EA2F2F90200004D00417A66@prv1-mh.provo.novell.com>
2019-01-17 11:46 ` Jan Beulich
[not found] ` <95DC675902000028AB59E961@prv1-mh.provo.novell.com>
2019-02-04 9:37 ` Jan Beulich
2019-02-04 19:08 ` Stefano Stabellini
2019-02-05 6:02 ` Juergen Gross
[not found] ` <2E9DDEFD0200007B00417A66@prv1-mh.provo.novell.com>
2019-02-05 7:53 ` Jan Beulich
2019-02-05 14:56 ` George Dunlap
[not found] ` <E730A9F90200001DAB59E961@prv1-mh.provo.novell.com>
2019-02-06 11:59 ` Jan Beulich
[not found] ` <7A8C0A4F020000EEB8D7C7D4@prv1-mh.provo.novell.com>
2019-02-06 16:21 ` Jan Beulich
2019-02-06 16:37 ` Ian Jackson
[not found] ` <08D440470200001BB8D7C7D4@prv1-mh.provo.novell.com>
2019-02-06 16:47 ` Jan Beulich
2019-02-06 16:52 ` Ian Jackson
2019-02-06 23:39 ` Stefano Stabellini
2019-02-07 11:48 ` Ian Jackson
2019-02-07 18:18 ` Stefano Stabellini
2019-02-12 11:31 ` Ian Jackson
2019-02-13 0:09 ` Stefano Stabellini
2019-01-15 11:46 ` Julien Grall
2019-01-15 12:23 ` Julien Grall
2019-01-14 10:11 ` Jan Beulich
2019-01-14 15:41 ` Julien Grall
2019-01-14 15:52 ` Jan Beulich
2019-01-14 16:26 ` Stewart Hildebrand
2019-01-14 16:39 ` Jan Beulich
2019-01-14 16:28 ` Julien Grall
2019-01-14 16:44 ` Jan Beulich
2019-01-14 17:24 ` Julien Grall
2019-01-15 8:04 ` Jan Beulich
2019-01-10 17:22 ` Stefano Stabellini
2019-01-10 8:34 ` Jan Beulich
2019-01-10 18:09 ` Stefano Stabellini
2019-01-09 23:42 ` [PATCH v6 2/4] xen/arm: use SYMBOL when required Stefano Stabellini
2019-01-10 8:41 ` Jan Beulich [this message]
2019-01-10 17:44 ` Stefano Stabellini
2019-01-11 10:52 ` Jan Beulich
2019-01-11 16:58 ` Stefano Stabellini
2019-01-14 9:23 ` Jan Beulich
2019-01-09 23:42 ` [PATCH v6 3/4] xen/x86: " Stefano Stabellini
2019-01-10 8:43 ` Jan Beulich
2019-01-10 17:45 ` Stefano Stabellini
2019-01-09 23:42 ` [PATCH v6 4/4] xen/common: " Stefano Stabellini
2019-01-10 8:49 ` Jan Beulich
2019-01-10 17:48 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C370549020000780020C1A5@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=stefanos@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.