From: "Jan Beulich" <JBeulich@suse.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
george.dunlap@citrix.com,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v3 1/4] x86/mem_sharing: reorder when pages are unlocked and released
Date: Mon, 29 Apr 2019 10:14:48 -0600 [thread overview]
Message-ID: <5CC722F8020000780022A22C@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <CABfawhk4AnVBMTssrqsDr7e9FB2GSiCn9iE13L5=sBKhQdiEeQ@mail.gmail.com>
>>> On 29.04.19 at 18:05, <tamas@tklengyel.com> wrote:
> On Mon, Apr 29, 2019 at 9:52 AM George Dunlap <george.dunlap@citrix.com> wrote:
>> I haven't re-grokked the code here, but assuming I was correct 2 weeks
>> ago, if you have the BUG_ON() there, you can get rid of the extra
>> references.
>
> Sure, but again, the overhead of having them in-place is negligible so
> might as well just keep it.
The overhead is only one aspect here. People looking at the code
may also be mislead into trying to figure out why the heck this
extra reference gets obtained. Plus sub-optimal code tends to get
cloned ...
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: "Tamas K Lengyel" <tamas@tklengyel.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
george.dunlap@citrix.com,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 1/4] x86/mem_sharing: reorder when pages are unlocked and released
Date: Mon, 29 Apr 2019 10:14:48 -0600 [thread overview]
Message-ID: <5CC722F8020000780022A22C@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190429161448.F3r1auBUv8NT9CycSHXfjjJX0mAB-QwUwyshybLUiQA@z> (raw)
In-Reply-To: <CABfawhk4AnVBMTssrqsDr7e9FB2GSiCn9iE13L5=sBKhQdiEeQ@mail.gmail.com>
>>> On 29.04.19 at 18:05, <tamas@tklengyel.com> wrote:
> On Mon, Apr 29, 2019 at 9:52 AM George Dunlap <george.dunlap@citrix.com> wrote:
>> I haven't re-grokked the code here, but assuming I was correct 2 weeks
>> ago, if you have the BUG_ON() there, you can get rid of the extra
>> references.
>
> Sure, but again, the overhead of having them in-place is negligible so
> might as well just keep it.
The overhead is only one aspect here. People looking at the code
may also be mislead into trying to figure out why the heck this
extra reference gets obtained. Plus sub-optimal code tends to get
cloned ...
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-29 16:14 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 17:21 [PATCH v3 1/4] x86/mem_sharing: reorder when pages are unlocked and released Tamas K Lengyel
2019-04-26 17:21 ` [Xen-devel] " Tamas K Lengyel
2019-04-26 17:21 ` [PATCH v3 2/4] x86/mem_sharing: introduce and use page_lock_memshr instead of page_lock Tamas K Lengyel
2019-04-26 17:21 ` [Xen-devel] " Tamas K Lengyel
2019-04-29 15:18 ` Jan Beulich
2019-04-29 15:18 ` [Xen-devel] " Jan Beulich
2019-04-29 16:35 ` Tamas K Lengyel
2019-04-29 16:35 ` [Xen-devel] " Tamas K Lengyel
2019-04-30 7:15 ` Jan Beulich
2019-04-30 7:15 ` [Xen-devel] " Jan Beulich
2019-04-30 8:28 ` Tamas K Lengyel
2019-04-30 8:28 ` [Xen-devel] " Tamas K Lengyel
2019-04-30 8:44 ` Jan Beulich
2019-04-30 8:44 ` [Xen-devel] " Jan Beulich
2019-04-30 14:19 ` Tamas K Lengyel
2019-04-30 14:19 ` [Xen-devel] " Tamas K Lengyel
2019-04-30 14:43 ` George Dunlap
2019-04-30 14:43 ` [Xen-devel] " George Dunlap
2019-04-30 14:46 ` Tamas K Lengyel
2019-04-30 14:46 ` [Xen-devel] " Tamas K Lengyel
2019-04-30 15:06 ` Jan Beulich
2019-04-30 15:06 ` [Xen-devel] " Jan Beulich
2019-04-30 16:03 ` George Dunlap
2019-04-30 16:03 ` [Xen-devel] " George Dunlap
2019-05-02 7:24 ` Jan Beulich
2019-05-02 7:24 ` [Xen-devel] " Jan Beulich
2019-04-29 16:42 ` George Dunlap
2019-04-29 16:42 ` [Xen-devel] " George Dunlap
2019-04-30 7:13 ` Jan Beulich
2019-04-30 7:13 ` [Xen-devel] " Jan Beulich
2019-04-26 17:21 ` [PATCH v3 3/4] x86/mem_sharing: enable mem_share audit mode only in debug builds Tamas K Lengyel
2019-04-26 17:21 ` [Xen-devel] " Tamas K Lengyel
2019-04-29 14:57 ` Jan Beulich
2019-04-29 14:57 ` [Xen-devel] " Jan Beulich
2019-04-29 15:31 ` Tamas K Lengyel
2019-04-29 15:31 ` [Xen-devel] " Tamas K Lengyel
2019-04-26 17:21 ` [PATCH v3 4/4] x86/mem_sharing: compile mem_sharing subsystem only when kconfig is enabled Tamas K Lengyel
2019-04-26 17:21 ` [Xen-devel] " Tamas K Lengyel
2019-04-29 15:32 ` Jan Beulich
2019-04-29 15:32 ` [Xen-devel] " Jan Beulich
2019-04-29 15:49 ` Tamas K Lengyel
2019-04-29 15:49 ` [Xen-devel] " Tamas K Lengyel
2019-04-29 14:32 ` [PATCH v3 1/4] x86/mem_sharing: reorder when pages are unlocked and released George Dunlap
2019-04-29 14:32 ` [Xen-devel] " George Dunlap
2019-04-29 14:46 ` George Dunlap
2019-04-29 14:46 ` [Xen-devel] " George Dunlap
2019-04-29 14:49 ` Andrew Cooper
2019-04-29 14:49 ` [Xen-devel] " Andrew Cooper
2019-04-29 14:54 ` George Dunlap
2019-04-29 14:54 ` [Xen-devel] " George Dunlap
2019-04-29 15:37 ` Tamas K Lengyel
2019-04-29 15:37 ` [Xen-devel] " Tamas K Lengyel
2019-04-29 15:01 ` Jan Beulich
2019-04-29 15:01 ` [Xen-devel] " Jan Beulich
2019-04-29 15:41 ` Tamas K Lengyel
2019-04-29 15:41 ` [Xen-devel] " Tamas K Lengyel
2019-04-29 15:52 ` George Dunlap
2019-04-29 15:52 ` [Xen-devel] " George Dunlap
2019-04-29 16:05 ` Tamas K Lengyel
2019-04-29 16:05 ` [Xen-devel] " Tamas K Lengyel
2019-04-29 16:14 ` Jan Beulich [this message]
2019-04-29 16:14 ` Jan Beulich
2019-04-29 16:22 ` George Dunlap
2019-04-29 16:22 ` [Xen-devel] " George Dunlap
2019-04-29 16:26 ` Tamas K Lengyel
2019-04-29 16:26 ` [Xen-devel] " Tamas K Lengyel
2019-04-29 16:29 ` George Dunlap
2019-04-29 16:29 ` [Xen-devel] " George Dunlap
2019-04-29 16:36 ` Tamas K Lengyel
2019-04-29 16:36 ` [Xen-devel] " Tamas K Lengyel
2019-04-29 15:44 ` George Dunlap
2019-04-29 15:44 ` [Xen-devel] " George Dunlap
2019-04-29 15:58 ` Tamas K Lengyel
2019-04-29 15:58 ` [Xen-devel] " Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CC722F8020000780022A22C@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=roger.pau@citrix.com \
--cc=tamas@tklengyel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.