All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	oleksandr_tyshchenko@epam.com,
	xen-devel <xen-devel@lists.xenproject.org>,
	"andrii_anisov@epam.com" <andrii_anisov@epam.com>
Subject: Re: [PATCH MM-PART2 RESEND v2 01/19] xen/const: Extend the existing macro BIT to take a suffix in parameter
Date: Tue, 14 May 2019 06:37:58 -0600	[thread overview]
Message-ID: <5CDAB6A6020000780022EAF9@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20190514122456.28559-2-julien.grall@arm.com>

>>> On 14.05.19 at 14:24, <julien.grall@arm.com> wrote:
> Arm currently provides two macro BIT and BIT_ULL that are only usable
> in C and return respectively unsigned long and unsigned long long.
> 
> Extending the macros to deal with assembly would be a nice benefits as
> it could replace the common pattern to define fields (AC(1, sfx) << X)
> easier to read.
> 
> Rather than extending the two macros, it was decided to drop BIT_ULL()
> and extend the macro BIT() to take a suffix (e.g U, UL, ULL) in
> parameter. This would allow to use different suffix without having to
> define new macros.
> 
> The new extend macro is now moved in include/xen/const.h so it can be
> used by anyone in Xen and also avoid to include bitops.h in assembly
> code.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Thanks much for going this route! For the single line addition to
common code
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: "Julien Grall" <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	oleksandr_tyshchenko@epam.com,
	xen-devel <xen-devel@lists.xenproject.org>,
	"andrii_anisov@epam.com" <andrii_anisov@epam.com>
Subject: Re: [Xen-devel] [PATCH MM-PART2 RESEND v2 01/19] xen/const: Extend the existing macro BIT to take a suffix in parameter
Date: Tue, 14 May 2019 06:37:58 -0600	[thread overview]
Message-ID: <5CDAB6A6020000780022EAF9@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190514123758.B1PoLdPBodmjvEyN0s16TQMmjZg2WqM9oQC-Rt4sMcQ@z> (raw)
In-Reply-To: <20190514122456.28559-2-julien.grall@arm.com>

>>> On 14.05.19 at 14:24, <julien.grall@arm.com> wrote:
> Arm currently provides two macro BIT and BIT_ULL that are only usable
> in C and return respectively unsigned long and unsigned long long.
> 
> Extending the macros to deal with assembly would be a nice benefits as
> it could replace the common pattern to define fields (AC(1, sfx) << X)
> easier to read.
> 
> Rather than extending the two macros, it was decided to drop BIT_ULL()
> and extend the macro BIT() to take a suffix (e.g U, UL, ULL) in
> parameter. This would allow to use different suffix without having to
> define new macros.
> 
> The new extend macro is now moved in include/xen/const.h so it can be
> used by anyone in Xen and also avoid to include bitops.h in assembly
> code.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Thanks much for going this route! For the single line addition to
common code
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-14 12:38 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 12:24 [PATCH MM-PART2 RESEND v2 00/19] xen/arm: Clean-up & fixes in boot/mm code Julien Grall
2019-05-14 12:24 ` [Xen-devel] " Julien Grall
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 01/19] xen/const: Extend the existing macro BIT to take a suffix in parameter Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-14 12:37   ` Jan Beulich [this message]
2019-05-14 12:37     ` Jan Beulich
2019-05-20 21:43   ` Stefano Stabellini
2019-05-20 21:43     ` [Xen-devel] " Stefano Stabellini
2019-05-21 10:01     ` Andrii Anisov
2019-05-21 10:01       ` [Xen-devel] " Andrii Anisov
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 02/19] xen/arm: Rename SCTLR_* defines and remove unused one Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-20 21:46   ` Stefano Stabellini
2019-05-20 21:46     ` [Xen-devel] " Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 03/19] xen/arm: processor: Use BIT(.., UL) instead of _AC(1, U) in SCTLR_ defines Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-20 21:48   ` Stefano Stabellini
2019-05-20 21:48     ` [Xen-devel] " Stefano Stabellini
2019-05-21 10:01   ` Andrii Anisov
2019-05-21 10:01     ` [Xen-devel] " Andrii Anisov
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 04/19] xen/arm: Rework HSCTLR_BASE Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-20 22:56   ` Stefano Stabellini
2019-05-20 22:56     ` [Xen-devel] " Stefano Stabellini
2019-05-21 10:09     ` Julien Grall
2019-05-21 10:09       ` [Xen-devel] " Julien Grall
2019-05-29 16:54       ` Julien Grall
2019-05-29 16:54         ` [Xen-devel] " Julien Grall
2019-06-03 23:12         ` Stefano Stabellini
2019-06-03 23:12           ` [Xen-devel] " Stefano Stabellini
2019-06-04 10:27           ` Julien Grall
2019-06-04 17:41             ` Stefano Stabellini
2019-05-30 16:17       ` Andrii Anisov
2019-05-30 16:17         ` [Xen-devel] " Andrii Anisov
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 05/19] xen/arm: Remove parameter cpuid from start_xen Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-21 10:01   ` Andrii Anisov
2019-05-21 10:01     ` [Xen-devel] " Andrii Anisov
2019-06-06 17:15     ` Julien Grall
2019-06-07 22:39   ` Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 06/19] xen/arm: Rework secondary_start prototype Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-20 22:56   ` Stefano Stabellini
2019-05-20 22:56     ` [Xen-devel] " Stefano Stabellini
2019-05-29 17:06     ` Julien Grall
2019-05-29 17:06       ` [Xen-devel] " Julien Grall
2019-05-30 16:18       ` Andrii Anisov
2019-05-30 16:18         ` [Xen-devel] " Andrii Anisov
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 07/19] xen/arm64: head: Remove unnecessary comment Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-20 22:56   ` Stefano Stabellini
2019-05-20 22:56     ` [Xen-devel] " Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 08/19] xen/arm64: head: Move earlyprintk messages in .rodata.str Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-20 22:56   ` Stefano Stabellini
2019-05-20 22:56     ` [Xen-devel] " Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 09/19] xen/arm64: head: Correctly report the HW CPU ID Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-20 22:56   ` Stefano Stabellini
2019-05-20 22:56     ` [Xen-devel] " Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 10/19] xen/arm32: " Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-06-03 22:45   ` Stefano Stabellini
2019-06-03 22:45     ` [Xen-devel] " Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 11/19] xen/arm32: head: Don't set MAIR0 and MAIR1 Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-06-03 22:47   ` Stefano Stabellini
2019-06-03 22:47     ` [Xen-devel] " Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 12/19] xen/arm32: head: Always zero r3 before update a page-table entry Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-21 10:03   ` Andrii Anisov
2019-05-21 10:03     ` [Xen-devel] " Andrii Anisov
2019-06-03 23:15   ` Stefano Stabellini
2019-06-03 23:15     ` [Xen-devel] " Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 13/19] xen/arm32: mm: Avoid to zero and clean cache for CPU0 domheap Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-06-03 23:20   ` Stefano Stabellini
2019-06-03 23:20     ` [Xen-devel] " Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 14/19] xen/arm32: mm: Avoid cleaning the cache for secondary CPUs page-tables Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-06-04 23:11   ` Stefano Stabellini
2019-06-05 10:19     ` Julien Grall
2019-06-10 10:15       ` Julien Grall
2019-06-10 20:28       ` Stefano Stabellini
2019-06-10 20:40         ` Julien Grall
2019-06-10 20:54           ` Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 15/19] xen/arm: mm: Introduce DEFINE_PAGE_TABLE{, S} and use it Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-06-03 23:29   ` Stefano Stabellini
2019-06-03 23:29     ` [Xen-devel] " Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 16/19] xen/arm: mm: Protect Xen page-table update with a spinlock Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-05-21 10:04   ` Andrii Anisov
2019-05-21 10:04     ` [Xen-devel] " Andrii Anisov
2019-06-04 23:11   ` Stefano Stabellini
2019-06-05 10:36     ` Julien Grall
2019-06-08  0:17       ` Stefano Stabellini
2019-06-13 12:06         ` Julien Grall
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 17/19] xen/arm: mm: Initialize page-tables earlier Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-06-04 23:12   ` Stefano Stabellini
2019-06-06 17:32     ` Julien Grall
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 18/19] xen/arm: mm: Check start is always before end in {destroy, modify}_xen_mappings Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-06-04 23:12   ` Stefano Stabellini
2019-05-14 12:24 ` [PATCH MM-PART2 RESEND v2 19/19] xen/arm: Pair call to set_fixmap with call to clear_fixmap in copy_from_paddr Julien Grall
2019-05-14 12:24   ` [Xen-devel] " Julien Grall
2019-06-04 17:59   ` Stefano Stabellini
2019-06-04 20:18     ` Julien Grall
2019-06-04 23:12       ` Stefano Stabellini
2019-06-06 17:38         ` Julien Grall
2019-05-29 17:23 ` [PATCH MM-PART2 RESEND v2 00/19] xen/arm: Clean-up & fixes in boot/mm code Julien Grall
2019-05-29 17:23   ` [Xen-devel] " Julien Grall
2019-06-13 12:09 ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CDAB6A6020000780022EAF9@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=andrii_anisov@epam.com \
    --cc=julien.grall@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.