All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Anthony Perard <anthony.perard@citrix.com>
Cc: Ian Jackson <ian.jackson@citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	osstest service owner <osstest-admin@xenproject.org>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [qemu-upstream-4.11-testing test] 136184: regressions - FAIL
Date: Tue, 04 Jun 2019 01:06:56 -0600	[thread overview]
Message-ID: <5CF618900200007800234E5F@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20190603171558.GF2126@perard.uk.xensource.com>

>>> On 03.06.19 at 19:15, <anthony.perard@citrix.com> wrote:
> On Tue, May 21, 2019 at 05:52:12PM +0100, Julien Grall wrote:
>> The same error cannot be reproduced on laxton*. Looking at the test history,
>> it looks like qemu-upstream-4.12-testing flight has run successfully a few
>> times on rochester*. So we may have fixed the error in Xen 4.12.
>> 
>> Potential candidates would be:
>>    - 00c96d7742 "xen/arm: mm: Set-up page permission for Xen mappings earlier on"
>>    - f60658c6ae "xen/arm: Stop relocating Xen"
>> 
>> Ian, is it something the bisector could automatically look at?
>> If not, I will need to find some time and borrow the board to bisect the
>> issues.
> 
> I attempted to do that bisection myself, and the first commit that git
> wanted to try, a common commit to both branches, boots just fine.

Thanks for doing this!

One thing that, for now, completely escapes me: How come the
main 4.11 branch has progressed fine, but the qemuu one has
got stalled like this?

> It turns out that the first commit that fails to boot on rochester is
>   e202feb713 xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct
> (even with the "eb8acba82a xen: Fix backport of .." applied)

Now that's particularly odd a regression candidate. It doesn't
touch any Arm code at all (nor does the fixup commit). And the
common code changes don't look "risky" either; the one thing that
jumps out as the most likely of all the unlikely candidates would
seem to be the xen/common/efi/boot.c change, but if there was
a problem there then the EFI boot on Arm would be latently
broken in other ways as well. Plus, of course, you say that the
same change is no problem on 4.12.

Of course the commit itself could be further "bisected" - all
changes other than the introduction of cmdline_strcmp() are
completely independent of one another.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: "Anthony Perard" <anthony.perard@citrix.com>
Cc: Ian Jackson <ian.jackson@citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	osstest service owner <osstest-admin@xenproject.org>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [qemu-upstream-4.11-testing test] 136184: regressions - FAIL
Date: Tue, 04 Jun 2019 01:06:56 -0600	[thread overview]
Message-ID: <5CF618900200007800234E5F@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190604070656.pG8XHgCe6X224Tr68o7016Y5B0VztthTloXGDLdnU0M@z> (raw)
In-Reply-To: <20190603171558.GF2126@perard.uk.xensource.com>

>>> On 03.06.19 at 19:15, <anthony.perard@citrix.com> wrote:
> On Tue, May 21, 2019 at 05:52:12PM +0100, Julien Grall wrote:
>> The same error cannot be reproduced on laxton*. Looking at the test history,
>> it looks like qemu-upstream-4.12-testing flight has run successfully a few
>> times on rochester*. So we may have fixed the error in Xen 4.12.
>> 
>> Potential candidates would be:
>>    - 00c96d7742 "xen/arm: mm: Set-up page permission for Xen mappings earlier on"
>>    - f60658c6ae "xen/arm: Stop relocating Xen"
>> 
>> Ian, is it something the bisector could automatically look at?
>> If not, I will need to find some time and borrow the board to bisect the
>> issues.
> 
> I attempted to do that bisection myself, and the first commit that git
> wanted to try, a common commit to both branches, boots just fine.

Thanks for doing this!

One thing that, for now, completely escapes me: How come the
main 4.11 branch has progressed fine, but the qemuu one has
got stalled like this?

> It turns out that the first commit that fails to boot on rochester is
>   e202feb713 xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct
> (even with the "eb8acba82a xen: Fix backport of .." applied)

Now that's particularly odd a regression candidate. It doesn't
touch any Arm code at all (nor does the fixup commit). And the
common code changes don't look "risky" either; the one thing that
jumps out as the most likely of all the unlikely candidates would
seem to be the xen/common/efi/boot.c change, but if there was
a problem there then the EFI boot on Arm would be latently
broken in other ways as well. Plus, of course, you say that the
same change is no problem on 4.12.

Of course the commit itself could be further "bisected" - all
changes other than the introduction of cmdline_strcmp() are
completely independent of one another.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-06-04  7:07 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 19:48 [qemu-upstream-4.11-testing test] 136184: regressions - FAIL osstest service owner
2019-05-15 19:48 ` [Xen-devel] " osstest service owner
2019-05-16 10:37 ` Anthony PERARD
2019-05-16 10:37   ` [Xen-devel] " Anthony PERARD
2019-05-16 21:38   ` Julien Grall
2019-05-16 21:38     ` [Xen-devel] " Julien Grall
2019-05-17 15:53     ` Ian Jackson
2019-05-17 15:53       ` [Xen-devel] " Ian Jackson
2019-05-17 17:23     ` Anthony PERARD
2019-05-17 17:23       ` [Xen-devel] " Anthony PERARD
2019-05-17 19:00       ` Julien Grall
2019-05-17 19:00         ` [Xen-devel] " Julien Grall
2019-05-21 16:52         ` Julien Grall
2019-05-21 16:52           ` [Xen-devel] " Julien Grall
2019-06-03 17:15           ` Anthony PERARD
2019-06-03 17:15             ` [Xen-devel] " Anthony PERARD
2019-06-04  7:06             ` Jan Beulich [this message]
2019-06-04  7:06               ` Jan Beulich
2019-06-04  9:01               ` Julien Grall
2019-06-04  9:01                 ` [Xen-devel] " Julien Grall
2019-06-04  9:17                 ` Jan Beulich
2019-06-04  9:17                   ` [Xen-devel] " Jan Beulich
2019-06-04  9:57                   ` Julien Grall
2019-06-04  9:57                     ` [Xen-devel] " Julien Grall
2019-06-04 10:02                     ` Jan Beulich
2019-06-04 10:02                       ` [Xen-devel] " Jan Beulich
2019-06-04 17:09                 ` Stefano Stabellini
2019-06-04 17:22                   ` Julien Grall
2019-06-04 17:39                     ` Stefano Stabellini
2019-06-04 17:52                       ` Ian Jackson
2019-06-04 18:03                         ` Stefano Stabellini
2019-06-04 18:27                           ` Ian Jackson
2019-06-04 18:53                             ` Stefano Stabellini
2019-06-04 20:50                       ` Julien Grall
2019-06-04 23:11                         ` Stefano Stabellini
2019-06-05 10:59                           ` Julien Grall
2019-06-05 20:29                             ` Stefano Stabellini
2019-06-05 21:38                               ` Julien Grall
2019-06-06  8:42                                 ` Jan Beulich
2019-06-06  8:47                                   ` Julien Grall
2019-06-06 22:21                                     ` Stefano Stabellini
2019-06-07  9:33                                       ` Julien Grall
2019-06-05 10:19                     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CF618900200007800234E5F@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=anthony.perard@citrix.com \
    --cc=ian.jackson@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=osstest-admin@xenproject.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.