All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: hsr: remove an redundant null check before kfree_skb
@ 2019-09-04  3:09 zhong jiang
  2019-09-04 11:55   ` Markus Elfring
  0 siblings, 1 reply; 5+ messages in thread
From: zhong jiang @ 2019-09-04  3:09 UTC (permalink / raw)
  To: davem, arvid.brodin; +Cc: zhongjiang, netdev, linux-kernel

kfree_skb has taken the null pointer into account. Hence just remove
the null check before kfree_skb.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 net/hsr/hsr_forward.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/net/hsr/hsr_forward.c b/net/hsr/hsr_forward.c
index ddd9605..0c9e5b0 100644
--- a/net/hsr/hsr_forward.c
+++ b/net/hsr/hsr_forward.c
@@ -367,10 +367,8 @@ void hsr_forward_skb(struct sk_buff *skb, struct hsr_port *port)
 		port->dev->stats.tx_bytes += skb->len;
 	}
 
-	if (frame.skb_hsr)
-		kfree_skb(frame.skb_hsr);
-	if (frame.skb_std)
-		kfree_skb(frame.skb_std);
+	kfree_skb(frame.skb_hsr);
+	kfree_skb(frame.skb_std);
 	return;
 
 out_drop:
-- 
1.7.12.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-04 15:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04  3:09 [PATCH] net: hsr: remove an redundant null check before kfree_skb zhong jiang
2019-09-04 11:55 ` net: hsr: remove a " Markus Elfring
2019-09-04 11:55   ` Markus Elfring
2019-09-04 15:21   ` zhong jiang
2019-09-04 15:21     ` zhong jiang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.