* [PATCH 0/3] target: minor iSCSI parameter parsing fixes
@ 2019-09-12 9:55 David Disseldorp
2019-10-21 16:06 ` Mike Christie
2019-10-23 2:14 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: David Disseldorp @ 2019-09-12 9:55 UTC (permalink / raw)
To: target-devel
This patchset includes some minor fixes for parsing iSCSI CHAP_A and
SendTargets fields. Patch 1/3 was already submitted and reviewed by
Lee.
I used the following libiscsi hacks to test for these bugs:
https://github.com/ddiss/libiscsi/commits/bogus_chap_a
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_key
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_val
I'll work on turning these into propper libiscsi regression tests
(pending https://github.com/sahlberg/libiscsi/issues/297).
Cheers, David
drivers/target/iscsi/iscsi_target.c | 14 ++++++--------
drivers/target/iscsi/iscsi_target_auth.c | 2 +-
drivers/target/iscsi/iscsi_target_parameters.h | 3 ---
3 files changed, 7 insertions(+), 12 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] target: minor iSCSI parameter parsing fixes
2019-09-12 9:55 [PATCH 0/3] target: minor iSCSI parameter parsing fixes David Disseldorp
@ 2019-10-21 16:06 ` Mike Christie
2019-10-23 2:14 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Mike Christie @ 2019-10-21 16:06 UTC (permalink / raw)
To: target-devel
On 09/12/2019 04:55 AM, David Disseldorp wrote:
> This patchset includes some minor fixes for parsing iSCSI CHAP_A and
> SendTargets fields. Patch 1/3 was already submitted and reviewed by
> Lee.
> I used the following libiscsi hacks to test for these bugs:
> https://github.com/ddiss/libiscsi/commits/bogus_chap_a
> https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_key
> https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_val
> I'll work on turning these into propper libiscsi regression tests
> (pending https://github.com/sahlberg/libiscsi/issues/297).
>
> Cheers, David
>
> drivers/target/iscsi/iscsi_target.c | 14 ++++++--------
> drivers/target/iscsi/iscsi_target_auth.c | 2 +-
> drivers/target/iscsi/iscsi_target_parameters.h | 3 ---
> 3 files changed, 7 insertions(+), 12 deletions(-)
>
Reviewed-by: Mike Christie <mchristi@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] target: minor iSCSI parameter parsing fixes
2019-09-12 9:55 [PATCH 0/3] target: minor iSCSI parameter parsing fixes David Disseldorp
2019-10-21 16:06 ` Mike Christie
@ 2019-10-23 2:14 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-10-23 2:14 UTC (permalink / raw)
To: target-devel
>> This patchset includes some minor fixes for parsing iSCSI CHAP_A and
>> SendTargets fields. Patch 1/3 was already submitted and reviewed by
>> Lee.
> Reviewed-by: Mike Christie <mchristi@redhat.com>
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-23 2:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 9:55 [PATCH 0/3] target: minor iSCSI parameter parsing fixes David Disseldorp
2019-10-21 16:06 ` Mike Christie
2019-10-23 2:14 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.