From: Zhou Yanjie <zhouyanjie@zoho.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, paul.burton@mips.com, paulburton@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, mark.rutland@arm.com,
syq@debian.org, sernia.zhou@foxmail.com, zhenwenjin@gmail.com
Subject: Re: [PATCH 4/5] dt-bindings: clock: Add USB OTG clock for X1000.
Date: Thu, 28 Nov 2019 13:44:09 +0800 [thread overview]
Message-ID: <5DDF5EA9.8030007@zoho.com> (raw)
In-Reply-To: <1574875148.3.3@crapouillou.net>
Hi Paul,
On 2019年11月28日 01:19, Paul Cercueil wrote:
> Hi Zhou,
>
>
> Le mer., nov. 27, 2019 at 11:32, Zhou Yanjie <zhouyanjie@zoho.com> a
> écrit :
>> Add the USB OTC clock bindings for the X1000 Soc from Ingenic.
>>
>> Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com>
>> ---
>> include/dt-bindings/clock/x1000-cgu.h | 23 ++++++++++++-----------
>> 1 file changed, 12 insertions(+), 11 deletions(-)
>>
>> diff --git a/include/dt-bindings/clock/x1000-cgu.h
>> b/include/dt-bindings/clock/x1000-cgu.h
>> index bbaebaf..c401fce 100644
>> --- a/include/dt-bindings/clock/x1000-cgu.h
>> +++ b/include/dt-bindings/clock/x1000-cgu.h
>> @@ -29,16 +29,17 @@
>> #define X1000_CLK_MSCMUX 14
>> #define X1000_CLK_MSC0 15
>> #define X1000_CLK_MSC1 16
>> -#define X1000_CLK_SSIPLL 17
>> -#define X1000_CLK_SSIMUX 18
>> -#define X1000_CLK_SFC 19
>> -#define X1000_CLK_I2C0 20
>> -#define X1000_CLK_I2C1 21
>> -#define X1000_CLK_I2C2 22
>> -#define X1000_CLK_UART0 23
>> -#define X1000_CLK_UART1 24
>> -#define X1000_CLK_UART2 25
>> -#define X1000_CLK_SSI 26
>> -#define X1000_CLK_PDMA 27
>
> You can't do that. These macros are ABI now, since they are used in
> the devicetree. Just use the next valid number for your OTG clock.
>
My fault, I will fix this in v2.
> Cheers,
> -Paul
>
>> +#define X1000_CLK_OTG 17
>> +#define X1000_CLK_SSIPLL 18
>> +#define X1000_CLK_SSIMUX 19
>> +#define X1000_CLK_SFC 20
>> +#define X1000_CLK_I2C0 21
>> +#define X1000_CLK_I2C1 22
>> +#define X1000_CLK_I2C2 23
>> +#define X1000_CLK_UART0 24
>> +#define X1000_CLK_UART1 25
>> +#define X1000_CLK_UART2 26
>> +#define X1000_CLK_SSI 27
>> +#define X1000_CLK_PDMA 28
>>
>> #endif /* __DT_BINDINGS_CLOCK_X1000_CGU_H__ */
>> --
>> 2.7.4
>>
>>
>
>
next prev parent reply other threads:[~2019-11-28 5:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 3:32 clk: Ingenic: Add support for the X1830 and add USB clk for X1000 Zhou Yanjie
2019-11-27 3:32 ` [PATCH 1/5] clk: Ingenic: Adjust code to make it compatible with X1830 Zhou Yanjie
2019-11-27 17:37 ` Paul Cercueil
2019-11-28 6:29 ` Zhou Yanjie
2019-11-29 11:23 ` Paul Cercueil
2019-12-10 22:55 ` Paul Burton
2019-11-27 3:32 ` [PATCH 2/5] dt-bindings: clock: Add X1830 bindings Zhou Yanjie
2019-12-05 20:38 ` Rob Herring
2019-11-27 3:32 ` [PATCH 3/5] clk: Ingenic: Add CGU driver for X1830 Zhou Yanjie
2019-11-27 3:32 ` [PATCH 4/5] dt-bindings: clock: Add USB OTG clock for X1000 Zhou Yanjie
2019-11-27 17:19 ` Paul Cercueil
2019-11-28 5:44 ` Zhou Yanjie [this message]
2019-11-27 3:32 ` [PATCH 5/5] clk: Ingenic: " Zhou Yanjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DDF5EA9.8030007@zoho.com \
--to=zhouyanjie@zoho.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=syq@debian.org \
--cc=zhenwenjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.