* [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr()
@ 2012-10-26 15:30 Wei Yongjun
2012-10-26 16:35 ` Jitendra Kalsaria
2012-10-31 17:36 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2012-10-26 15:30 UTC (permalink / raw)
To: jitendra.kalsaria, ron.mercer; +Cc: yongjun_wei, linux-driver, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The variable retval is initialized but never used
otherwise, so remove the unused variable.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index 6407d0d..dd4d864a 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -1920,7 +1920,6 @@ static void ql_process_mac_tx_intr(struct ql3_adapter *qdev,
{
struct ql_tx_buf_cb *tx_cb;
int i;
- int retval = 0;
if (mac_rsp->flags & OB_MAC_IOCB_RSP_S) {
netdev_warn(qdev->ndev,
@@ -1935,7 +1934,6 @@ static void ql_process_mac_tx_intr(struct ql3_adapter *qdev,
"Frame too short to be legal, frame not sent\n");
qdev->ndev->stats.tx_errors++;
- retval = -EIO;
goto frame_not_sent;
}
@@ -1944,7 +1942,6 @@ static void ql_process_mac_tx_intr(struct ql3_adapter *qdev,
mac_rsp->transaction_id);
qdev->ndev->stats.tx_errors++;
- retval = -EIO;
goto invalid_seg_count;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr()
2012-10-26 15:30 [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr() Wei Yongjun
@ 2012-10-26 16:35 ` Jitendra Kalsaria
2012-10-31 17:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jitendra Kalsaria @ 2012-10-26 16:35 UTC (permalink / raw)
To: Wei Yongjun, Ron Mercer; +Cc: yongjun_wei, Dept-Eng Linux Driver, netdev
>From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
>Sent: Friday, October 26, 2012 8:31 AM
>To: Jitendra Kalsaria; Ron Mercer
>Cc: yongjun_wei@trendmicro.com.cn; Dept-Eng Linux Driver; netdev
>Subject: [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr()
>
>From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
>The variable retval is initialized but never used
>otherwise, so remove the unused variable.
>
>dpatch engine is used to auto generate this patch.
>(https://github.com/weiyj/dpatch)
>
>Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr()
2012-10-26 15:30 [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr() Wei Yongjun
2012-10-26 16:35 ` Jitendra Kalsaria
@ 2012-10-31 17:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-10-31 17:36 UTC (permalink / raw)
To: weiyj.lk; +Cc: jitendra.kalsaria, ron.mercer, yongjun_wei, linux-driver, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Fri, 26 Oct 2012 23:30:31 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variable retval is initialized but never used
> otherwise, so remove the unused variable.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-31 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-26 15:30 [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr() Wei Yongjun
2012-10-26 16:35 ` Jitendra Kalsaria
2012-10-31 17:36 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.