* Review request for Bug 5947 - Replace fstypes lookup on main build page
@ 2014-03-11 23:00 Wymore, Farrell
2014-03-14 17:37 ` Damian, Alexandru
0 siblings, 1 reply; 9+ messages in thread
From: Wymore, Farrell @ 2014-03-11 23:00 UTC (permalink / raw)
To: BARROS PENA, BELEN; +Cc: toaster
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Hi Belen,
I have pushed the fix for this defect.
fwymore/fstypes
Thanks in advance - fw
[-- Attachment #2: Type: text/html, Size: 1891 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Review request for Bug 5947 - Replace fstypes lookup on main build page
2014-03-11 23:00 Review request for Bug 5947 - Replace fstypes lookup on main build page Wymore, Farrell
@ 2014-03-14 17:37 ` Damian, Alexandru
2014-03-20 11:45 ` Damian, Alexandru
0 siblings, 1 reply; 9+ messages in thread
From: Damian, Alexandru @ 2014-03-14 17:37 UTC (permalink / raw)
To: Wymore, Farrell; +Cc: toaster
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
Taken in.
On Tue, Mar 11, 2014 at 11:00 PM, Wymore, Farrell <
Farrell.Wymore@windriver.com> wrote:
> Hi Belen,
>
>
>
> I have pushed the fix for this defect.
>
> fwymore/fstypes
>
>
>
> Thanks in advance - fw
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 1328 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Review request for Bug 5947 - Replace fstypes lookup on main build page
2014-03-14 17:37 ` Damian, Alexandru
@ 2014-03-20 11:45 ` Damian, Alexandru
2014-03-21 7:18 ` Reyna, David
0 siblings, 1 reply; 9+ messages in thread
From: Damian, Alexandru @ 2014-03-20 11:45 UTC (permalink / raw)
To: Wymore, Farrell; +Cc: toaster
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
Hi,
I made a sloppy job reviewing this patch, I'm sorry for this.
The filters should have no knowledge of the object system. All object
manipulation should happen only in the views.py page, and relevant values
passed through the context.
I'm reverting this patch for the 2014/03/20 submission. Can you please
rework this patch with the relevant data queries inside views.py ?
Thank you,
Alex
On Fri, Mar 14, 2014 at 5:37 PM, Damian, Alexandru <
alexandru.damian@intel.com> wrote:
> Taken in.
>
>
> On Tue, Mar 11, 2014 at 11:00 PM, Wymore, Farrell <
> Farrell.Wymore@windriver.com> wrote:
>
>> Hi Belen,
>>
>>
>>
>> I have pushed the fix for this defect.
>>
>> fwymore/fstypes
>>
>>
>>
>> Thanks in advance - fw
>>
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 3189 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Review request for Bug 5947 - Replace fstypes lookup on main build page
2014-03-20 11:45 ` Damian, Alexandru
@ 2014-03-21 7:18 ` Reyna, David
2014-03-21 9:12 ` Damian, Alexandru
0 siblings, 1 reply; 9+ messages in thread
From: Reyna, David @ 2014-03-21 7:18 UTC (permalink / raw)
To: DAMIAN, ALEXANDRU, Wymore, Farrell; +Cc: toaster
[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]
Hi Alex,
I can and will redo the commit. Did you revert the original patch?
I did a pull at 11:00 pm 2014/3/20 and I still see the patch. If you allow me to revert it explicitly with the updated patch, then you do not need to revert and I do not need to rebase yet again and lose a day, nor would anyone else preparing commits with changes to “projecttags.py”.
Also, we are seeing image file entries like “rootfs.manifest”. How does the algorithm know that “rootfs.tar.bz2” and “rootfs.ext3” are image files, but ‘rootfs.manifest” is not? Or is the issue that entries like “rootfs.manifest” should not be in the image file list in the first place?
- David
From: toaster-bounces@yoctoproject.org [mailto:toaster-bounces@yoctoproject.org] On Behalf Of Damian, Alexandru
Sent: Thursday, March 20, 2014 4:45 AM
To: Wymore, Farrell
Cc: toaster@yoctoproject.org
Subject: Re: [Toaster] Review request for Bug 5947 - Replace fstypes lookup on main build page
Hi,
I made a sloppy job reviewing this patch, I'm sorry for this.
The filters should have no knowledge of the object system. All object manipulation should happen only in the views.py page, and relevant values passed through the context.
I'm reverting this patch for the 2014/03/20 submission. Can you please rework this patch with the relevant data queries inside views.py ?
Thank you,
Alex
On Fri, Mar 14, 2014 at 5:37 PM, Damian, Alexandru <alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>> wrote:
Taken in.
On Tue, Mar 11, 2014 at 11:00 PM, Wymore, Farrell <Farrell.Wymore@windriver.com<mailto:Farrell.Wymore@windriver.com>> wrote:
Hi Belen,
I have pushed the fix for this defect.
fwymore/fstypes
Thanks in advance - fw
--
_______________________________________________
toaster mailing list
toaster@yoctoproject.org<mailto:toaster@yoctoproject.org>
https://lists.yoctoproject.org/listinfo/toaster
--
Alex Damian
Yocto Project
SSG / OTC
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 9743 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Review request for Bug 5947 - Replace fstypes lookup on main build page
2014-03-21 7:18 ` Reyna, David
@ 2014-03-21 9:12 ` Damian, Alexandru
2014-03-25 16:32 ` Damian, Alexandru
0 siblings, 1 reply; 9+ messages in thread
From: Damian, Alexandru @ 2014-03-21 9:12 UTC (permalink / raw)
To: Reyna, David L (Wind River); +Cc: Wymore, Farrell W (Wind River), toaster
[-- Attachment #1: Type: text/plain, Size: 3044 bytes --]
Hi David,
I have the reverting patch up for submission. Unfortunately, the next
merging upstream will not happen until Monday. Can you please postpone this
one until we settle the upstream master ?
There is also another patch that tries to tackle this problem at data
collection time; if we manage to get that one in, that this patch will have
to have a different form. I think I will tackle it to save time, so please
reassign the bug to me.
What that does is basically cross-reference the collected output file
names with the IMAGE_FSTYPES variable and register directly the only output
extensions that are valid.
Hope this helps,
Alex
On Fri, Mar 21, 2014 at 7:18 AM, Reyna, David L (Wind River) <
david.reyna@windriver.com> wrote:
> Hi Alex,
>
>
>
> I can and will redo the commit. Did you revert the original patch?
>
>
>
> I did a pull at 11:00 pm 2014/3/20 and I still see the patch. If you allow
> me to revert it explicitly with the updated patch, then you do not need to
> revert and I do not need to rebase yet again and lose a day, nor would
> anyone else preparing commits with changes to “projecttags.py”.
>
>
>
> Also, we are seeing image file entries like “rootfs.manifest”. How does
> the algorithm know that “rootfs.tar.bz2” and “rootfs.ext3” are image
> files, but ‘rootfs.manifest” is not? Or is the issue that entries like
> “rootfs.manifest” should not be in the image file list in the first place?
>
>
>
> - David
>
>
>
> *From:* toaster-bounces@yoctoproject.org [mailto:
> toaster-bounces@yoctoproject.org] *On Behalf Of *Damian, Alexandru
> *Sent:* Thursday, March 20, 2014 4:45 AM
> *To:* Wymore, Farrell
> *Cc:* toaster@yoctoproject.org
> *Subject:* Re: [Toaster] Review request for Bug 5947 - Replace fstypes
> lookup on main build page
>
>
>
> Hi,
>
>
>
> I made a sloppy job reviewing this patch, I'm sorry for this.
>
>
>
> The filters should have no knowledge of the object system. All object
> manipulation should happen only in the views.py page, and relevant values
> passed through the context.
>
>
>
> I'm reverting this patch for the 2014/03/20 submission. Can you please
> rework this patch with the relevant data queries inside views.py ?
>
>
>
> Thank you,
>
> Alex
>
>
>
> On Fri, Mar 14, 2014 at 5:37 PM, Damian, Alexandru <
> alexandru.damian@intel.com> wrote:
>
> Taken in.
>
>
>
> On Tue, Mar 11, 2014 at 11:00 PM, Wymore, Farrell <
> Farrell.Wymore@windriver.com> wrote:
>
> Hi Belen,
>
>
>
> I have pushed the fix for this defect.
>
> fwymore/fstypes
>
>
>
> Thanks in advance - fw
>
>
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
> --
>
> Alex Damian
>
> Yocto Project
>
> SSG / OTC
>
>
>
>
>
> --
>
> Alex Damian
>
> Yocto Project
>
> SSG / OTC
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 9452 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Review request for Bug 5947 - Replace fstypes lookup on main build page
2014-03-21 9:12 ` Damian, Alexandru
@ 2014-03-25 16:32 ` Damian, Alexandru
2014-03-25 17:12 ` Reyna, David
2014-03-25 17:44 ` Reyna, David
0 siblings, 2 replies; 9+ messages in thread
From: Damian, Alexandru @ 2014-03-25 16:32 UTC (permalink / raw)
To: Reyna, David L (Wind River); +Cc: Wymore, Farrell W (Wind River), toaster
[-- Attachment #1: Type: text/plain, Size: 3510 bytes --]
The origin/master is now updated.
Can you please refactor/rebase the fstypes on main build page patch on top
of origin/master ?
Thank you !
Alex
On Fri, Mar 21, 2014 at 9:12 AM, Damian, Alexandru <
alexandru.damian@intel.com> wrote:
> Hi David,
>
> I have the reverting patch up for submission. Unfortunately, the next
> merging upstream will not happen until Monday. Can you please postpone this
> one until we settle the upstream master ?
>
> There is also another patch that tries to tackle this problem at data
> collection time; if we manage to get that one in, that this patch will have
> to have a different form. I think I will tackle it to save time, so please
> reassign the bug to me.
>
> What that does is basically cross-reference the collected output file
> names with the IMAGE_FSTYPES variable and register directly the only output
> extensions that are valid.
>
> Hope this helps,
> Alex
>
>
> On Fri, Mar 21, 2014 at 7:18 AM, Reyna, David L (Wind River) <
> david.reyna@windriver.com> wrote:
>
>> Hi Alex,
>>
>>
>>
>> I can and will redo the commit. Did you revert the original patch?
>>
>>
>>
>> I did a pull at 11:00 pm 2014/3/20 and I still see the patch. If you
>> allow me to revert it explicitly with the updated patch, then you do not
>> need to revert and I do not need to rebase yet again and lose a day, nor
>> would anyone else preparing commits with changes to “projecttags.py”.
>>
>>
>>
>> Also, we are seeing image file entries like “rootfs.manifest”. How does
>> the algorithm know that “rootfs.tar.bz2” and “rootfs.ext3” are image
>> files, but ‘rootfs.manifest” is not? Or is the issue that entries like
>> “rootfs.manifest” should not be in the image file list in the first place?
>>
>>
>>
>> - David
>>
>>
>>
>> *From:* toaster-bounces@yoctoproject.org [mailto:
>> toaster-bounces@yoctoproject.org] *On Behalf Of *Damian, Alexandru
>> *Sent:* Thursday, March 20, 2014 4:45 AM
>> *To:* Wymore, Farrell
>> *Cc:* toaster@yoctoproject.org
>> *Subject:* Re: [Toaster] Review request for Bug 5947 - Replace fstypes
>> lookup on main build page
>>
>>
>>
>> Hi,
>>
>>
>>
>> I made a sloppy job reviewing this patch, I'm sorry for this.
>>
>>
>>
>> The filters should have no knowledge of the object system. All object
>> manipulation should happen only in the views.py page, and relevant values
>> passed through the context.
>>
>>
>>
>> I'm reverting this patch for the 2014/03/20 submission. Can you please
>> rework this patch with the relevant data queries inside views.py ?
>>
>>
>>
>> Thank you,
>>
>> Alex
>>
>>
>>
>> On Fri, Mar 14, 2014 at 5:37 PM, Damian, Alexandru <
>> alexandru.damian@intel.com> wrote:
>>
>> Taken in.
>>
>>
>>
>> On Tue, Mar 11, 2014 at 11:00 PM, Wymore, Farrell <
>> Farrell.Wymore@windriver.com> wrote:
>>
>> Hi Belen,
>>
>>
>>
>> I have pushed the fix for this defect.
>>
>> fwymore/fstypes
>>
>>
>>
>> Thanks in advance - fw
>>
>>
>>
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>>
>>
>> --
>>
>> Alex Damian
>>
>> Yocto Project
>>
>> SSG / OTC
>>
>>
>>
>>
>>
>> --
>>
>> Alex Damian
>>
>> Yocto Project
>>
>> SSG / OTC
>>
>
>
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 10326 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Review request for Bug 5947 - Replace fstypes lookup on main build page
2014-03-25 16:32 ` Damian, Alexandru
@ 2014-03-25 17:12 ` Reyna, David
2014-03-25 17:44 ` Reyna, David
1 sibling, 0 replies; 9+ messages in thread
From: Reyna, David @ 2014-03-25 17:12 UTC (permalink / raw)
To: DAMIAN, ALEXANDRU; +Cc: Wymore, Farrell, toaster
[-- Attachment #1: Type: text/plain, Size: 3636 bytes --]
As you wish. I will prepare it now.
- David
From: Damian, Alexandru [mailto:alexandru.damian@intel.com]
Sent: Tuesday, March 25, 2014 9:33 AM
To: Reyna, David
Cc: Wymore, Farrell; toaster@yoctoproject.org
Subject: Re: [Toaster] Review request for Bug 5947 - Replace fstypes lookup on main build page
The origin/master is now updated.
Can you please refactor/rebase the fstypes on main build page patch on top of origin/master ?
Thank you !
Alex
On Fri, Mar 21, 2014 at 9:12 AM, Damian, Alexandru <alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>> wrote:
Hi David,
I have the reverting patch up for submission. Unfortunately, the next merging upstream will not happen until Monday. Can you please postpone this one until we settle the upstream master ?
There is also another patch that tries to tackle this problem at data collection time; if we manage to get that one in, that this patch will have to have a different form. I think I will tackle it to save time, so please reassign the bug to me.
What that does is basically cross-reference the collected output file names with the IMAGE_FSTYPES variable and register directly the only output extensions that are valid.
Hope this helps,
Alex
On Fri, Mar 21, 2014 at 7:18 AM, Reyna, David L (Wind River) <david.reyna@windriver.com<mailto:david.reyna@windriver.com>> wrote:
Hi Alex,
I can and will redo the commit. Did you revert the original patch?
I did a pull at 11:00 pm 2014/3/20 and I still see the patch. If you allow me to revert it explicitly with the updated patch, then you do not need to revert and I do not need to rebase yet again and lose a day, nor would anyone else preparing commits with changes to “projecttags.py”.
Also, we are seeing image file entries like “rootfs.manifest”. How does the algorithm know that “rootfs.tar.bz2” and “rootfs.ext3” are image files, but ‘rootfs.manifest” is not? Or is the issue that entries like “rootfs.manifest” should not be in the image file list in the first place?
- David
From: toaster-bounces@yoctoproject.org<mailto:toaster-bounces@yoctoproject.org> [mailto:toaster-bounces@yoctoproject.org<mailto:toaster-bounces@yoctoproject.org>] On Behalf Of Damian, Alexandru
Sent: Thursday, March 20, 2014 4:45 AM
To: Wymore, Farrell
Cc: toaster@yoctoproject.org<mailto:toaster@yoctoproject.org>
Subject: Re: [Toaster] Review request for Bug 5947 - Replace fstypes lookup on main build page
Hi,
I made a sloppy job reviewing this patch, I'm sorry for this.
The filters should have no knowledge of the object system. All object manipulation should happen only in the views.py page, and relevant values passed through the context.
I'm reverting this patch for the 2014/03/20 submission. Can you please rework this patch with the relevant data queries inside views.py ?
Thank you,
Alex
On Fri, Mar 14, 2014 at 5:37 PM, Damian, Alexandru <alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>> wrote:
Taken in.
On Tue, Mar 11, 2014 at 11:00 PM, Wymore, Farrell <Farrell.Wymore@windriver.com<mailto:Farrell.Wymore@windriver.com>> wrote:
Hi Belen,
I have pushed the fix for this defect.
fwymore/fstypes
Thanks in advance - fw
--
_______________________________________________
toaster mailing list
toaster@yoctoproject.org<mailto:toaster@yoctoproject.org>
https://lists.yoctoproject.org/listinfo/toaster
--
Alex Damian
Yocto Project
SSG / OTC
--
Alex Damian
Yocto Project
SSG / OTC
--
Alex Damian
Yocto Project
SSG / OTC
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 16254 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Review request for Bug 5947 - Replace fstypes lookup on main build page
2014-03-25 16:32 ` Damian, Alexandru
2014-03-25 17:12 ` Reyna, David
@ 2014-03-25 17:44 ` Reyna, David
2014-03-27 16:38 ` Damian, Alexandru
1 sibling, 1 reply; 9+ messages in thread
From: Reyna, David @ 2014-03-25 17:44 UTC (permalink / raw)
To: DAMIAN, ALEXANDRU; +Cc: Wymore, Farrell, toaster
[-- Attachment #1: Type: text/plain, Size: 3688 bytes --]
Hi Alex,
I have created a new branch and rebased the patch:
dreyna/fstypes_v2
- David
From: Damian, Alexandru [mailto:alexandru.damian@intel.com]
Sent: Tuesday, March 25, 2014 9:33 AM
To: Reyna, David
Cc: Wymore, Farrell; toaster@yoctoproject.org
Subject: Re: [Toaster] Review request for Bug 5947 - Replace fstypes lookup on main build page
The origin/master is now updated.
Can you please refactor/rebase the fstypes on main build page patch on top of origin/master ?
Thank you !
Alex
On Fri, Mar 21, 2014 at 9:12 AM, Damian, Alexandru <alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>> wrote:
Hi David,
I have the reverting patch up for submission. Unfortunately, the next merging upstream will not happen until Monday. Can you please postpone this one until we settle the upstream master ?
There is also another patch that tries to tackle this problem at data collection time; if we manage to get that one in, that this patch will have to have a different form. I think I will tackle it to save time, so please reassign the bug to me.
What that does is basically cross-reference the collected output file names with the IMAGE_FSTYPES variable and register directly the only output extensions that are valid.
Hope this helps,
Alex
On Fri, Mar 21, 2014 at 7:18 AM, Reyna, David L (Wind River) <david.reyna@windriver.com<mailto:david.reyna@windriver.com>> wrote:
Hi Alex,
I can and will redo the commit. Did you revert the original patch?
I did a pull at 11:00 pm 2014/3/20 and I still see the patch. If you allow me to revert it explicitly with the updated patch, then you do not need to revert and I do not need to rebase yet again and lose a day, nor would anyone else preparing commits with changes to “projecttags.py”.
Also, we are seeing image file entries like “rootfs.manifest”. How does the algorithm know that “rootfs.tar.bz2” and “rootfs.ext3” are image files, but ‘rootfs.manifest” is not? Or is the issue that entries like “rootfs.manifest” should not be in the image file list in the first place?
- David
From: toaster-bounces@yoctoproject.org<mailto:toaster-bounces@yoctoproject.org> [mailto:toaster-bounces@yoctoproject.org<mailto:toaster-bounces@yoctoproject.org>] On Behalf Of Damian, Alexandru
Sent: Thursday, March 20, 2014 4:45 AM
To: Wymore, Farrell
Cc: toaster@yoctoproject.org<mailto:toaster@yoctoproject.org>
Subject: Re: [Toaster] Review request for Bug 5947 - Replace fstypes lookup on main build page
Hi,
I made a sloppy job reviewing this patch, I'm sorry for this.
The filters should have no knowledge of the object system. All object manipulation should happen only in the views.py page, and relevant values passed through the context.
I'm reverting this patch for the 2014/03/20 submission. Can you please rework this patch with the relevant data queries inside views.py ?
Thank you,
Alex
On Fri, Mar 14, 2014 at 5:37 PM, Damian, Alexandru <alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>> wrote:
Taken in.
On Tue, Mar 11, 2014 at 11:00 PM, Wymore, Farrell <Farrell.Wymore@windriver.com<mailto:Farrell.Wymore@windriver.com>> wrote:
Hi Belen,
I have pushed the fix for this defect.
fwymore/fstypes
Thanks in advance - fw
--
_______________________________________________
toaster mailing list
toaster@yoctoproject.org<mailto:toaster@yoctoproject.org>
https://lists.yoctoproject.org/listinfo/toaster
--
Alex Damian
Yocto Project
SSG / OTC
--
Alex Damian
Yocto Project
SSG / OTC
--
Alex Damian
Yocto Project
SSG / OTC
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 16905 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Review request for Bug 5947 - Replace fstypes lookup on main build page
2014-03-25 17:44 ` Reyna, David
@ 2014-03-27 16:38 ` Damian, Alexandru
0 siblings, 0 replies; 9+ messages in thread
From: Damian, Alexandru @ 2014-03-27 16:38 UTC (permalink / raw)
To: Reyna, David L (Wind River); +Cc: Wymore, Farrell W (Wind River), toaster
[-- Attachment #1: Type: text/plain, Size: 4061 bytes --]
Taken in.
Alex
On Tue, Mar 25, 2014 at 5:44 PM, Reyna, David L (Wind River) <
david.reyna@windriver.com> wrote:
> Hi Alex,
>
>
>
> I have created a new branch and rebased the patch:
>
>
>
> dreyna/fstypes_v2
>
>
>
> - David
>
>
>
> *From:* Damian, Alexandru [mailto:alexandru.damian@intel.com]
> *Sent:* Tuesday, March 25, 2014 9:33 AM
> *To:* Reyna, David
> *Cc:* Wymore, Farrell; toaster@yoctoproject.org
>
> *Subject:* Re: [Toaster] Review request for Bug 5947 - Replace fstypes
> lookup on main build page
>
>
>
> The origin/master is now updated.
>
> Can you please refactor/rebase the fstypes on main build page patch on top
> of origin/master ?
>
> Thank you !
>
> Alex
>
>
>
> On Fri, Mar 21, 2014 at 9:12 AM, Damian, Alexandru <
> alexandru.damian@intel.com> wrote:
>
> Hi David,
>
> I have the reverting patch up for submission. Unfortunately, the next
> merging upstream will not happen until Monday. Can you please postpone this
> one until we settle the upstream master ?
>
> There is also another patch that tries to tackle this problem at data
> collection time; if we manage to get that one in, that this patch will have
> to have a different form. I think I will tackle it to save time, so please
> reassign the bug to me.
>
> What that does is basically cross-reference the collected output file
> names with the IMAGE_FSTYPES variable and register directly the only output
> extensions that are valid.
>
> Hope this helps,
> Alex
>
>
>
> On Fri, Mar 21, 2014 at 7:18 AM, Reyna, David L (Wind River) <
> david.reyna@windriver.com> wrote:
>
> Hi Alex,
>
>
>
> I can and will redo the commit. Did you revert the original patch?
>
>
>
> I did a pull at 11:00 pm 2014/3/20 and I still see the patch. If you allow
> me to revert it explicitly with the updated patch, then you do not need to
> revert and I do not need to rebase yet again and lose a day, nor would
> anyone else preparing commits with changes to “projecttags.py”.
>
>
>
> Also, we are seeing image file entries like “rootfs.manifest”. How does
> the algorithm know that “rootfs.tar.bz2” and “rootfs.ext3” are image files,
> but ‘rootfs.manifest” is not? Or is the issue that entries like
> “rootfs.manifest” should not be in the image file list in the first place?
>
>
>
> - David
>
>
>
> *From:* toaster-bounces@yoctoproject.org [mailto:
> toaster-bounces@yoctoproject.org] *On Behalf Of *Damian, Alexandru
> *Sent:* Thursday, March 20, 2014 4:45 AM
> *To:* Wymore, Farrell
> *Cc:* toaster@yoctoproject.org
> *Subject:* Re: [Toaster] Review request for Bug 5947 - Replace fstypes
> lookup on main build page
>
>
>
> Hi,
>
>
>
> I made a sloppy job reviewing this patch, I'm sorry for this.
>
>
>
> The filters should have no knowledge of the object system. All object
> manipulation should happen only in the views.py page, and relevant values
> passed through the context.
>
>
>
> I'm reverting this patch for the 2014/03/20 submission. Can you please
> rework this patch with the relevant data queries inside views.py ?
>
>
>
> Thank you,
>
> Alex
>
>
>
> On Fri, Mar 14, 2014 at 5:37 PM, Damian, Alexandru <
> alexandru.damian@intel.com> wrote:
>
> Taken in.
>
>
>
> On Tue, Mar 11, 2014 at 11:00 PM, Wymore, Farrell <
> Farrell.Wymore@windriver.com> wrote:
>
> Hi Belen,
>
>
>
> I have pushed the fix for this defect.
>
> fwymore/fstypes
>
>
>
> Thanks in advance - fw
>
>
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
> --
>
> Alex Damian
>
> Yocto Project
>
> SSG / OTC
>
>
>
>
>
> --
>
> Alex Damian
>
> Yocto Project
>
> SSG / OTC
>
>
>
>
> --
>
> Alex Damian
>
> Yocto Project
>
> SSG / OTC
>
>
>
>
> --
>
> Alex Damian
>
> Yocto Project
>
> SSG / OTC
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 13324 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-03-27 16:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-11 23:00 Review request for Bug 5947 - Replace fstypes lookup on main build page Wymore, Farrell
2014-03-14 17:37 ` Damian, Alexandru
2014-03-20 11:45 ` Damian, Alexandru
2014-03-21 7:18 ` Reyna, David
2014-03-21 9:12 ` Damian, Alexandru
2014-03-25 16:32 ` Damian, Alexandru
2014-03-25 17:12 ` Reyna, David
2014-03-25 17:44 ` Reyna, David
2014-03-27 16:38 ` Damian, Alexandru
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.