[PATCH] toaster: make debug output more readable

[PATCH] toaster: make debug output more readable

[Olaf Mandel]

One of the debug-messages during build contains a list of all layers,
but without spaces or other separators between them. Use pformat
instead.

Signed-off-by: Olaf Mandel <o.mandel@menlosystems.com>
---
 lib/toaster/bldcontrol/localhostbecontroller.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/toaster/bldcontrol/localhostbecontroller.py b/lib/toaster/bldcontrol/localhostbecontroller.py
index 358cce4d..12071029 100644
--- a/lib/toaster/bldcontrol/localhostbecontroller.py
+++ b/lib/toaster/bldcontrol/localhostbecontroller.py
@@ -221,7 +221,7 @@ class LocalhostBEController(BuildEnvironmentController):
                 continue  # not a custom recipe, skip
 
         layerlist.extend(nongitlayerlist)
-        logger.debug("\n\nset layers gives this list \n %s" % ''.join(layerlist))
+        logger.debug("\n\nset layers gives this list %s" % pformat(layerlist))
         self.islayerset = True
         return layerlist
 
-- 
2.11.0

Re: [PATCH] toaster: make debug output more readable

[Reyna, David]

Hi Olaf,

I have looked at both of your patches, and I think that they are both useful and consistent with Toaster, thank you!

They do not however have a Bugzilla reference, and they are missing the normal patch header. I propose that I go ahead and (a) create those Bugzilla entries for you and (b) submit them together with other pending Toaster fixes using the standard bitbake-dev patch submission, together with my additional sign-off.

Created:
	Bug 12014 - debug message during build lists layers missing separators
	Bug 12015 - set default pokydirname if no external layers

Thanks!
David
Toaster maintainer


-----Original Message-----
From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-devel-bounces@lists.openembedded.org] On Behalf Of Olaf Mandel
Sent: Wednesday, August 30, 2017 5:25 AM
To: bitbake-devel@lists.openembedded.org
Cc: Olaf Mandel
Subject: [bitbake-devel] [PATCH] toaster: make debug output more readable

One of the debug-messages during build contains a list of all layers,
but without spaces or other separators between them. Use pformat
instead.

Signed-off-by: Olaf Mandel <o.mandel@menlosystems.com>
---
 lib/toaster/bldcontrol/localhostbecontroller.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/toaster/bldcontrol/localhostbecontroller.py b/lib/toaster/bldcontrol/localhostbecontroller.py
index 358cce4d..12071029 100644
--- a/lib/toaster/bldcontrol/localhostbecontroller.py
+++ b/lib/toaster/bldcontrol/localhostbecontroller.py
@@ -221,7 +221,7 @@ class LocalhostBEController(BuildEnvironmentController):
                 continue  # not a custom recipe, skip
 
         layerlist.extend(nongitlayerlist)
-        logger.debug("\n\nset layers gives this list \n %s" % ''.join(layerlist))
+        logger.debug("\n\nset layers gives this list %s" % pformat(layerlist))
         self.islayerset = True
         return layerlist
 
-- 
2.11.0

-- 
_______________________________________________
bitbake-devel mailing list
bitbake-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/bitbake-devel