* [PATCH 0/2] toaster: cummulative 021518 patch
@ 2018-02-16 4:25 David Reyna
2018-02-16 4:26 ` [PATCH 1/2] toaster: do not fail on optional 'custom.xml' file David Reyna
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: David Reyna @ 2018-02-16 4:25 UTC (permalink / raw)
To: bitbake-devel
From: David Reyna <David.Reyna@windriver.com>
This patchset addresses two blocking issues for Toaster.
The following changes since commit f51f28b7b927fde9489e244cb812b562f28bbafa:
icecc-create-env: Allow multiple tool aliases (2018-02-15 13:28:54 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib dreyna/submit/dreyna/toaster/cummulative_021518_patch
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=dreyna/submit/dreyna/toaster/cummulative_021518_patch
David Reyna (2):
toaster: do not fail on optional 'custom.xml' file
Toaster: fix shutdown and extra threads
bin/toaster | 4 ++--
lib/toaster/bldcontrol/management/commands/checksettings.py | 5 ++++-
2 files changed, 6 insertions(+), 3 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] toaster: do not fail on optional 'custom.xml' file
2018-02-16 4:25 [PATCH 0/2] toaster: cummulative 021518 patch David Reyna
@ 2018-02-16 4:26 ` David Reyna
2018-03-26 6:46 ` Reyna, David
2018-02-16 4:26 ` [PATCH 2/2] Toaster: fix shutdown and extra threads David Reyna
2018-03-26 6:46 ` [PATCH 0/2] toaster: cummulative 021518 patch Reyna, David
2 siblings, 1 reply; 6+ messages in thread
From: David Reyna @ 2018-02-16 4:26 UTC (permalink / raw)
To: bitbake-devel
From: David Reyna <David.Reyna@windriver.com>
Explicitly capture and ignore errors when trying to load the optional
'custom.xml' fixture file.
[YOCTO #12554]
Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
lib/toaster/bldcontrol/management/commands/checksettings.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/toaster/bldcontrol/management/commands/checksettings.py b/lib/toaster/bldcontrol/management/commands/checksettings.py
index 582114a..823c6f1 100644
--- a/lib/toaster/bldcontrol/management/commands/checksettings.py
+++ b/lib/toaster/bldcontrol/management/commands/checksettings.py
@@ -107,7 +107,10 @@ class Command(BaseCommand):
action="ignore",
message="^.*No fixture named.*$")
print("Importing custom settings if present")
- call_command("loaddata", "custom")
+ try:
+ call_command("loaddata", "custom")
+ except:
+ print("NOTE: optional fixture 'custom' not found")
# we run lsupdates after config update
print("\nFetching information from the layer index, "
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] Toaster: fix shutdown and extra threads
2018-02-16 4:25 [PATCH 0/2] toaster: cummulative 021518 patch David Reyna
2018-02-16 4:26 ` [PATCH 1/2] toaster: do not fail on optional 'custom.xml' file David Reyna
@ 2018-02-16 4:26 ` David Reyna
2018-03-26 6:46 ` Reyna, David
2018-03-26 6:46 ` [PATCH 0/2] toaster: cummulative 021518 patch Reyna, David
2 siblings, 1 reply; 6+ messages in thread
From: David Reyna @ 2018-02-16 4:26 UTC (permalink / raw)
To: bitbake-devel
From: David Reyna <David.Reyna@windriver.com>
Fix typo in shutdown code to kill threads when "kill -0" is not enough.
Use the '--noreload' flag for 'runserver' so that there are no extra
and unaccounted threads.
[YOCTO #12555]
Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
bin/toaster | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/toaster b/bin/toaster
index 4036f0a..ed365ee 100755
--- a/bin/toaster
+++ b/bin/toaster
@@ -68,7 +68,7 @@ webserverKillAll()
if [ -f ${pidfile} ]; then
pid=`cat ${pidfile}`
while kill -0 $pid 2>/dev/null; do
- kill -SIGTERM -$pid 2>/dev/null
+ kill -SIGTERM $pid 2>/dev/null
sleep 1
done
rm ${pidfile}
@@ -91,7 +91,7 @@ webserverStartAll()
echo "Starting webserver..."
- $MANAGE runserver "$ADDR_PORT" \
+ $MANAGE runserver --noreload "$ADDR_PORT" \
</dev/null >>${BUILDDIR}/toaster_web.log 2>&1 \
& echo $! >${BUILDDIR}/.toastermain.pid
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 0/2] toaster: cummulative 021518 patch
2018-02-16 4:25 [PATCH 0/2] toaster: cummulative 021518 patch David Reyna
2018-02-16 4:26 ` [PATCH 1/2] toaster: do not fail on optional 'custom.xml' file David Reyna
2018-02-16 4:26 ` [PATCH 2/2] Toaster: fix shutdown and extra threads David Reyna
@ 2018-03-26 6:46 ` Reyna, David
2 siblings, 0 replies; 6+ messages in thread
From: Reyna, David @ 2018-03-26 6:46 UTC (permalink / raw)
To: bitbake-devel
This patch was yet not pulled. Trying again. Thanks.
-----Original Message-----
From: Reyna, David
Sent: Thursday, February 15, 2018 8:26 PM
To: bitbake-devel@lists.openembedded.org
Cc: Reyna, David
Subject: [PATCH 0/2] toaster: cummulative 021518 patch
From: David Reyna <David.Reyna@windriver.com>
This patchset addresses two blocking issues for Toaster.
The following changes since commit f51f28b7b927fde9489e244cb812b562f28bbafa:
icecc-create-env: Allow multiple tool aliases (2018-02-15 13:28:54 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib dreyna/submit/dreyna/toaster/cummulative_021518_patch
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=dreyna/submit/dreyna/toaster/cummulative_021518_patch
David Reyna (2):
toaster: do not fail on optional 'custom.xml' file
Toaster: fix shutdown and extra threads
bin/toaster | 4 ++--
lib/toaster/bldcontrol/management/commands/checksettings.py | 5 ++++-
2 files changed, 6 insertions(+), 3 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] toaster: do not fail on optional 'custom.xml' file
2018-02-16 4:26 ` [PATCH 1/2] toaster: do not fail on optional 'custom.xml' file David Reyna
@ 2018-03-26 6:46 ` Reyna, David
0 siblings, 0 replies; 6+ messages in thread
From: Reyna, David @ 2018-03-26 6:46 UTC (permalink / raw)
To: bitbake-devel
-----Original Message-----
From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-devel-bounces@lists.openembedded.org] On Behalf Of David Reyna
Sent: Thursday, February 15, 2018 8:26 PM
To: bitbake-devel@lists.openembedded.org
Subject: [bitbake-devel] [PATCH 1/2] toaster: do not fail on optional 'custom.xml' file
From: David Reyna <David.Reyna@windriver.com>
Explicitly capture and ignore errors when trying to load the optional
'custom.xml' fixture file.
[YOCTO #12554]
Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
lib/toaster/bldcontrol/management/commands/checksettings.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/toaster/bldcontrol/management/commands/checksettings.py b/lib/toaster/bldcontrol/management/commands/checksettings.py
index 582114a..823c6f1 100644
--- a/lib/toaster/bldcontrol/management/commands/checksettings.py
+++ b/lib/toaster/bldcontrol/management/commands/checksettings.py
@@ -107,7 +107,10 @@ class Command(BaseCommand):
action="ignore",
message="^.*No fixture named.*$")
print("Importing custom settings if present")
- call_command("loaddata", "custom")
+ try:
+ call_command("loaddata", "custom")
+ except:
+ print("NOTE: optional fixture 'custom' not found")
# we run lsupdates after config update
print("\nFetching information from the layer index, "
--
2.7.4
--
_______________________________________________
bitbake-devel mailing list
bitbake-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/bitbake-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Toaster: fix shutdown and extra threads
2018-02-16 4:26 ` [PATCH 2/2] Toaster: fix shutdown and extra threads David Reyna
@ 2018-03-26 6:46 ` Reyna, David
0 siblings, 0 replies; 6+ messages in thread
From: Reyna, David @ 2018-03-26 6:46 UTC (permalink / raw)
To: bitbake-devel
-----Original Message-----
From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-devel-bounces@lists.openembedded.org] On Behalf Of David Reyna
Sent: Thursday, February 15, 2018 8:26 PM
To: bitbake-devel@lists.openembedded.org
Subject: [bitbake-devel] [PATCH 2/2] Toaster: fix shutdown and extra threads
From: David Reyna <David.Reyna@windriver.com>
Fix typo in shutdown code to kill threads when "kill -0" is not enough.
Use the '--noreload' flag for 'runserver' so that there are no extra and unaccounted threads.
[YOCTO #12555]
Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
bin/toaster | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/toaster b/bin/toaster
index 4036f0a..ed365ee 100755
--- a/bin/toaster
+++ b/bin/toaster
@@ -68,7 +68,7 @@ webserverKillAll()
if [ -f ${pidfile} ]; then
pid=`cat ${pidfile}`
while kill -0 $pid 2>/dev/null; do
- kill -SIGTERM -$pid 2>/dev/null
+ kill -SIGTERM $pid 2>/dev/null
sleep 1
done
rm ${pidfile}
@@ -91,7 +91,7 @@ webserverStartAll()
echo "Starting webserver..."
- $MANAGE runserver "$ADDR_PORT" \
+ $MANAGE runserver --noreload "$ADDR_PORT" \
</dev/null >>${BUILDDIR}/toaster_web.log 2>&1 \
& echo $! >${BUILDDIR}/.toastermain.pid
--
2.7.4
--
_______________________________________________
bitbake-devel mailing list
bitbake-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/bitbake-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-26 6:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-16 4:25 [PATCH 0/2] toaster: cummulative 021518 patch David Reyna
2018-02-16 4:26 ` [PATCH 1/2] toaster: do not fail on optional 'custom.xml' file David Reyna
2018-03-26 6:46 ` Reyna, David
2018-02-16 4:26 ` [PATCH 2/2] Toaster: fix shutdown and extra threads David Reyna
2018-03-26 6:46 ` Reyna, David
2018-03-26 6:46 ` [PATCH 0/2] toaster: cummulative 021518 patch Reyna, David
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.