All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <mchristi@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>,
	jsmart2021@gmail.com, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	nab@linux-iscsi.org
Subject: Re: [RFC PATCH 3/5] target: add target_setup_session sysfs support
Date: Wed, 15 Apr 2020 17:38:04 +0000	[thread overview]
Message-ID: <5E97467C.1070108@redhat.com> (raw)
In-Reply-To: <0267ebe3-8168-ef02-b414-6d14a756277b@acm.org>

On 04/14/2020 09:37 PM, Bart Van Assche wrote:
> On 2020-04-13 22:15, Mike Christie wrote:
>>  struct se_session *target_setup_session(struct se_portal_group *,
>>  		unsigned int, unsigned int, enum target_prot_op prot_op,
>> -		const char *, void *,
>> -		int (*callback)(struct se_portal_group *,
>> -				struct se_session *, void *));
>> +		const char *, struct attribute_group *, void *,
>> +		int (*setup_cb)(struct se_portal_group *,
>> +				struct se_session *, void *),
>> +		void (*free_cb)(struct se_session *));
> 
> The argument list of target_setup_session() is getting really long. How
> about moving the attribute_group, setup_cb and free_cb arguments into
> struct target_core_fabric_ops? Would that make it easier to extend

I agree.

> session sysfs attribute support in the future?
> 

Yeah, I can move those callbacks and the attribute_group to the
target_core_fabric_ops and it then it will work more similarly to the
other callout/attr handling.

WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <mchristi@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>,
	jsmart2021@gmail.com, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	nab@linux-iscsi.org
Subject: Re: [RFC PATCH 3/5] target: add target_setup_session sysfs support
Date: Wed, 15 Apr 2020 12:38:04 -0500	[thread overview]
Message-ID: <5E97467C.1070108@redhat.com> (raw)
In-Reply-To: <0267ebe3-8168-ef02-b414-6d14a756277b@acm.org>

On 04/14/2020 09:37 PM, Bart Van Assche wrote:
> On 2020-04-13 22:15, Mike Christie wrote:
>>  struct se_session *target_setup_session(struct se_portal_group *,
>>  		unsigned int, unsigned int, enum target_prot_op prot_op,
>> -		const char *, void *,
>> -		int (*callback)(struct se_portal_group *,
>> -				struct se_session *, void *));
>> +		const char *, struct attribute_group *, void *,
>> +		int (*setup_cb)(struct se_portal_group *,
>> +				struct se_session *, void *),
>> +		void (*free_cb)(struct se_session *));
> 
> The argument list of target_setup_session() is getting really long. How
> about moving the attribute_group, setup_cb and free_cb arguments into
> struct target_core_fabric_ops? Would that make it easier to extend

I agree.

> session sysfs attribute support in the future?
> 

Yeah, I can move those callbacks and the attribute_group to the
target_core_fabric_ops and it then it will work more similarly to the
other callout/attr handling.


  reply	other threads:[~2020-04-15 17:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  5:15 [RFC PATCH 0/5] target: add sysfs support Mike Christie
2020-04-14  5:15 ` Mike Christie
2020-04-14  5:15 ` [RFC PATCH 1/5] " Mike Christie
2020-04-14  5:15   ` Mike Christie
2020-04-15  2:23   ` Bart Van Assche
2020-04-15  2:23     ` Bart Van Assche
2020-04-15 17:28     ` Mike Christie
2020-04-15 17:28       ` Mike Christie
2020-04-14  5:15 ` [RFC PATCH 2/5] target: add sysfs session helper functions Mike Christie
2020-04-14  5:15   ` Mike Christie
2020-04-15  2:30   ` Bart Van Assche
2020-04-15  2:30     ` Bart Van Assche
2020-04-15 17:35     ` Mike Christie
2020-04-15 17:35       ` Mike Christie
2020-04-15 17:46       ` Mike Christie
2020-04-15 17:46         ` Mike Christie
2020-04-20 17:39   ` Bodo Stroesser
2020-04-20 17:39     ` Bodo Stroesser
2020-04-20 17:43     ` Mike Christie
2020-04-20 17:43       ` Mike Christie
2020-04-14  5:15 ` [RFC PATCH 3/5] target: add target_setup_session sysfs support Mike Christie
2020-04-14  5:15   ` Mike Christie
2020-04-14  5:28   ` Mike Christie
2020-04-14  5:28     ` Mike Christie
2020-04-15  2:37   ` Bart Van Assche
2020-04-15  2:37     ` Bart Van Assche
2020-04-15 17:38     ` Mike Christie [this message]
2020-04-15 17:38       ` Mike Christie
2020-04-14  5:15 ` [RFC PATCH 4/5] iscsi target: use session sysfs helpers Mike Christie
2020-04-14  5:15   ` Mike Christie
2020-04-14  5:15 ` [RFC PATCH 5/5] target: drop sess_get_index Mike Christie
2020-04-14  5:15   ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5E97467C.1070108@redhat.com \
    --to=mchristi@redhat.com \
    --cc=bvanassche@acm.org \
    --cc=jsmart2021@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.