All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix wrong function declaration
@ 2022-01-19 13:06 Juergen Gross
  2022-01-19 13:09 ` Bertrand Marquis
  0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2022-01-19 13:06 UTC (permalink / raw)
  To: minios-devel, xen-devel; +Cc: samuel.thibault, wl, Juergen Gross

Coverity spotted a wrong function declaration, fix it.

Coverity-Id: 1497423
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 include/balloon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/balloon.h b/include/balloon.h
index 8f7c8bd8..510e475a 100644
--- a/include/balloon.h
+++ b/include/balloon.h
@@ -50,7 +50,7 @@ static inline int chk_free_pages(unsigned long needed)
 {
     return needed <= nr_free_pages;
 }
-static inline balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
+static inline void balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
 
 #endif /* CONFIG_BALLOON */
 #endif /* _BALLOON_H_ */
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix wrong function declaration
  2022-01-19 13:06 [PATCH] fix wrong function declaration Juergen Gross
@ 2022-01-19 13:09 ` Bertrand Marquis
  0 siblings, 0 replies; 2+ messages in thread
From: Bertrand Marquis @ 2022-01-19 13:09 UTC (permalink / raw)
  To: Juergen Gross; +Cc: minios-devel, xen-devel, samuel.thibault, wl

Hi Juergen,

> On 19 Jan 2022, at 13:06, Juergen Gross <jgross@suse.com> wrote:
> 
> Coverity spotted a wrong function declaration, fix it.
> 
> Coverity-Id: 1497423
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> include/balloon.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/balloon.h b/include/balloon.h
> index 8f7c8bd8..510e475a 100644
> --- a/include/balloon.h
> +++ b/include/balloon.h
> @@ -50,7 +50,7 @@ static inline int chk_free_pages(unsigned long needed)
> {
>     return needed <= nr_free_pages;
> }
> -static inline balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
> +static inline void balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
> 
> #endif /* CONFIG_BALLOON */
> #endif /* _BALLOON_H_ */
> -- 
> 2.31.1
> 
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-19 13:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-19 13:06 [PATCH] fix wrong function declaration Juergen Gross
2022-01-19 13:09 ` Bertrand Marquis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.