All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] webkitgtk: Disable gold for mips/mips64
@ 2016-08-08 22:51 Khem Raj
  2016-08-08 22:51 ` [PATCH 2/2] libunwind: Do not use gold for linking Khem Raj
  2016-08-09  8:29 ` [PATCH 1/2] webkitgtk: Disable gold for mips/mips64 André Draszik
  0 siblings, 2 replies; 6+ messages in thread
From: Khem Raj @ 2016-08-08 22:51 UTC (permalink / raw)
  To: openembedded-core

with binutils 2.27, mips has got the gold support
but it doesnt work for webkitgtk _yet_ therefore
disable it for now.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.12.3.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
index f2ba8b6..d9f1c30 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
@@ -75,6 +75,8 @@ EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
 # binutils 2.25.1 has a bug on aarch64:
 # https://sourceware.org/bugzilla/show_bug.cgi?id=18430
 EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
+EXTRA_OECMAKE_append_mips = " -DUSE_LD_GOLD=OFF "
+EXTRA_OECMAKE_append_mips64 = " -DUSE_LD_GOLD=OFF "
 EXTRA_OECMAKE_append_toolchain-clang = " -DUSE_LD_GOLD=OFF "
 
 # JIT not supported on MIPS either
-- 
2.9.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] libunwind: Do not use gold for linking
  2016-08-08 22:51 [PATCH 1/2] webkitgtk: Disable gold for mips/mips64 Khem Raj
@ 2016-08-08 22:51 ` Khem Raj
  2016-08-08 23:25   ` Burton, Ross
  2016-08-09  8:29 ` [PATCH 1/2] webkitgtk: Disable gold for mips/mips64 André Draszik
  1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-08-08 22:51 UTC (permalink / raw)
  To: openembedded-core

This effectively reverts the commit
3dd233ac0c80393824100c54bb525236f8290fd2

gold now emits errors on copy relocs against
protected symbols what ld.bfd did in past, however
it seems its too conservative.

This does not fix the case for folks who
use gold as default linker, however it
does make bintuls 2.27 work with default
configuration of OE

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-support/libunwind/libunwind.inc | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/meta/recipes-support/libunwind/libunwind.inc b/meta/recipes-support/libunwind/libunwind.inc
index 1c342d3..e4ae8df 100644
--- a/meta/recipes-support/libunwind/libunwind.inc
+++ b/meta/recipes-support/libunwind/libunwind.inc
@@ -18,15 +18,6 @@ ATOMICOPS_armv5 = "-DAO_USE_PTHREAD_DEFS=1"
 ATOMICOPS_armv4 = "-DAO_USE_PTHREAD_DEFS=1"
 ATOMICOPS ?= ""
 
-LDFLAGS_append_x86 = " -fuse-ld=gold"
-LDFLAGS_append_x86-64 = " -fuse-ld=gold"
-
-LDFLAGS_append_arm = " -fuse-ld=gold"
-LDFLAGS_append_aarch64 = " -fuse-ld=gold"
-
-LDFLAGS_append_powerpc = " -fuse-ld=gold -mbss-plt"
-LDFLAGS_append_powerpc64 = " -fuse-ld=gold -mbss-plt"
-
 SECURITY_LDFLAGS_append_libc-musl = " -lssp_nonshared -lssp"
 
 BBCLASSEXTEND = "native"
-- 
2.9.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] libunwind: Do not use gold for linking
  2016-08-08 22:51 ` [PATCH 2/2] libunwind: Do not use gold for linking Khem Raj
@ 2016-08-08 23:25   ` Burton, Ross
  2016-08-09  1:48     ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2016-08-08 23:25 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

On 8 August 2016 at 23:51, Khem Raj <raj.khem@gmail.com> wrote:

> This effectively reverts the commit
> 3dd233ac0c80393824100c54bb525236f8290fd2
>
> gold now emits errors on copy relocs against
> protected symbols what ld.bfd did in past, however
> it seems its too conservative.
>
> This does not fix the case for folks who
> use gold as default linker, however it
> does make bintuls 2.27 work with default
> configuration of OE
>

Presumably this is blocked by the binutils upgrade and should be merged
with it and not beforehand?

Ross

[-- Attachment #2: Type: text/html, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] libunwind: Do not use gold for linking
  2016-08-08 23:25   ` Burton, Ross
@ 2016-08-09  1:48     ` Khem Raj
  0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2016-08-09  1:48 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core


[-- Attachment #1.1: Type: text/plain, Size: 699 bytes --]


> On Aug 8, 2016, at 4:25 PM, Burton, Ross <ross.burton@intel.com> wrote:
> 
> 
> On 8 August 2016 at 23:51, Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>> wrote:
> This effectively reverts the commit
> 3dd233ac0c80393824100c54bb525236f8290fd2
> 
> gold now emits errors on copy relocs against
> protected symbols what ld.bfd did in past, however
> it seems its too conservative.
> 
> This does not fix the case for folks who
> use gold as default linker, however it
> does make bintuls 2.27 work with default
> configuration of OE
> 
> Presumably this is blocked by the binutils upgrade and should be merged with it and not beforehand?

Thats right.

> 
> Ross


[-- Attachment #1.2: Type: text/html, Size: 1810 bytes --]

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] webkitgtk: Disable gold for mips/mips64
  2016-08-08 22:51 [PATCH 1/2] webkitgtk: Disable gold for mips/mips64 Khem Raj
  2016-08-08 22:51 ` [PATCH 2/2] libunwind: Do not use gold for linking Khem Raj
@ 2016-08-09  8:29 ` André Draszik
  2016-08-09  8:53   ` Khem Raj
  1 sibling, 1 reply; 6+ messages in thread
From: André Draszik @ 2016-08-09  8:29 UTC (permalink / raw)
  To: openembedded-core

On Mon, 2016-08-08 at 15:51 -0700, Khem Raj wrote:
> with binutils 2.27, mips has got the gold support
> but it doesnt work for webkitgtk _yet_ therefore
> disable it for now.
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-sato/webkit/webkitgtk_2.12.3.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb b/meta/recipes-
> sato/webkit/webkitgtk_2.12.3.bb
> index f2ba8b6..d9f1c30 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
> @@ -75,6 +75,8 @@ EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
>  # binutils 2.25.1 has a bug on aarch64:
>  # https://sourceware.org/bugzilla/show_bug.cgi?id=18430
>  EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
> +EXTRA_OECMAKE_append_mips = " -DUSE_LD_GOLD=OFF "
> +EXTRA_OECMAKE_append_mips64 = " -DUSE_LD_GOLD=OFF "

What about mipsel and mips64el? Should need the same I would think...



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] webkitgtk: Disable gold for mips/mips64
  2016-08-09  8:29 ` [PATCH 1/2] webkitgtk: Disable gold for mips/mips64 André Draszik
@ 2016-08-09  8:53   ` Khem Raj
  0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2016-08-09  8:53 UTC (permalink / raw)
  To: André Draszik; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]


> On Aug 9, 2016, at 1:29 AM, André Draszik <git@andred.net> wrote:
> 
> On Mon, 2016-08-08 at 15:51 -0700, Khem Raj wrote:
>> with binutils 2.27, mips has got the gold support
>> but it doesnt work for webkitgtk _yet_ therefore
>> disable it for now.
>> 
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  meta/recipes-sato/webkit/webkitgtk_2.12.3.bb | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb b/meta/recipes-
>> sato/webkit/webkitgtk_2.12.3.bb
>> index f2ba8b6..d9f1c30 100644
>> --- a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
>> +++ b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
>> @@ -75,6 +75,8 @@ EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
>>  # binutils 2.25.1 has a bug on aarch64:
>>  # https://sourceware.org/bugzilla/show_bug.cgi?id=18430
>>  EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
>> +EXTRA_OECMAKE_append_mips = " -DUSE_LD_GOLD=OFF "
>> +EXTRA_OECMAKE_append_mips64 = " -DUSE_LD_GOLD=OFF "
> 
> What about mipsel and mips64el? Should need the same I would think…

yes, I would think so. I do not test the el parts.

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-08-09  8:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-08 22:51 [PATCH 1/2] webkitgtk: Disable gold for mips/mips64 Khem Raj
2016-08-08 22:51 ` [PATCH 2/2] libunwind: Do not use gold for linking Khem Raj
2016-08-08 23:25   ` Burton, Ross
2016-08-09  1:48     ` Khem Raj
2016-08-09  8:29 ` [PATCH 1/2] webkitgtk: Disable gold for mips/mips64 André Draszik
2016-08-09  8:53   ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.