[PATCH] Bluetooth: btintel: fix btintel_download_firmware stub signature

[PATCH] Bluetooth: btintel: fix btintel_download_firmware stub signature

[trix]

From: Tom Rix <trix@redhat.com>

cppcheck returns this warning
btintel.c:1059]: (warning) Function 'btintel_download_firmware'
  argument order different: declaration
  'dev, fw, boot_param, ' definition 'hdev, ver, fw, boot_param'

By inspection, the stub version is missing
'struct intel_version *ver', so add it.

Fixes: ac0565462e33 ("Bluetooth: btintel: Check firmware version before download")
Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/bluetooth/btintel.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
index e0060e58573c..66902866a5c1 100644
--- a/drivers/bluetooth/btintel.h
+++ b/drivers/bluetooth/btintel.h
@@ -281,6 +281,7 @@ static inline int btintel_read_boot_params(struct hci_dev *hdev,
 }
 
 static inline int btintel_download_firmware(struct hci_dev *dev,
+					    struct intel_version *ver,
 					    const struct firmware *fw,
 					    u32 *boot_param)
 {
-- 
2.26.3

RE: Bluetooth: btintel: fix btintel_download_firmware stub signature

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=627929

---Test result---

Test Summary:
CheckPatch                    PASS      1.67 seconds
GitLint                       PASS      1.05 seconds
SubjectPrefix                 PASS      0.85 seconds
BuildKernel                   PASS      37.40 seconds
BuildKernel32                 PASS      33.34 seconds
Incremental Build with patchesPASS      44.96 seconds
TestRunner: Setup             PASS      553.75 seconds
TestRunner: l2cap-tester      PASS      17.89 seconds
TestRunner: bnep-tester       PASS      7.27 seconds
TestRunner: mgmt-tester       PASS      116.35 seconds
TestRunner: rfcomm-tester     PASS      9.48 seconds
TestRunner: sco-tester        PASS      9.23 seconds
TestRunner: smp-tester        PASS      8.94 seconds
TestRunner: userchan-tester   PASS      7.59 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: btintel: fix btintel_download_firmware stub signature

[Marcel Holtmann]

Hi Tom,

> On Mar 31, 2022, at 19:49, trix@redhat.com wrote:
> 
> <Mail Attachment>

please fix your email client to send this properly inline. Or use git-send-email.

Regards

Marcel

Re: [PATCH] Bluetooth: btintel: fix btintel_download_firmware stub signature

[Tom Rix]

On 4/1/22 10:22 AM, Marcel Holtmann wrote:
> Hi Tom,
>
>> On Mar 31, 2022, at 19:49, trix@redhat.com wrote:
>>
>> <Mail Attachment>
> please fix your email client to send this properly inline. Or use git-send-email.

I did use git-send-email.

I am not sure what the problem is.

Tom

>
> Regards
>
> Marcel
>