All of lore.kernel.org
 help / color / mirror / Atom feed
* Fix bad backport to stable v3.16+
@ 2019-05-22 16:30 Song Liu
  2019-05-23 17:44 ` Greg KH
  2019-11-19 15:05 ` Ben Hutchings
  0 siblings, 2 replies; 4+ messages in thread
From: Song Liu @ 2019-05-22 16:30 UTC (permalink / raw)
  To: stable; +Cc: linux-raid, Nigel Croxon, linux

Hi, 

As reported by Thorsten Knabe <linux@thorsten-knabe.de>. 

commit 4f4fd7c5798b ("Don't jump to compute_result state from check_result state")  
was back ported to v3.16+. However, this fix was wrong.  

Please back port the following two commits to fix this issue. 

commit a25d8c327bb4 ("Revert "Don't jump to compute_result state from check_result state"")
commit b2176a1dfb51 ("md/raid: raid5 preserve the writeback action after the parity check")

Thanks,
Song

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Fix bad backport to stable v3.16+
  2019-05-22 16:30 Fix bad backport to stable v3.16+ Song Liu
@ 2019-05-23 17:44 ` Greg KH
  2019-05-23 18:11   ` Song Liu
  2019-11-19 15:05 ` Ben Hutchings
  1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-05-23 17:44 UTC (permalink / raw)
  To: Song Liu; +Cc: stable, linux-raid, Nigel Croxon, linux

On Wed, May 22, 2019 at 04:30:33PM +0000, Song Liu wrote:
> Hi, 
> 
> As reported by Thorsten Knabe <linux@thorsten-knabe.de>. 
> 
> commit 4f4fd7c5798b ("Don't jump to compute_result state from check_result state")  
> was back ported to v3.16+. However, this fix was wrong.  
> 
> Please back port the following two commits to fix this issue. 
> 
> commit a25d8c327bb4 ("Revert "Don't jump to compute_result state from check_result state"")
> commit b2176a1dfb51 ("md/raid: raid5 preserve the writeback action after the parity check")

Added to 4.4+ for now.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Fix bad backport to stable v3.16+
  2019-05-23 17:44 ` Greg KH
@ 2019-05-23 18:11   ` Song Liu
  0 siblings, 0 replies; 4+ messages in thread
From: Song Liu @ 2019-05-23 18:11 UTC (permalink / raw)
  To: Greg KH; +Cc: stable, linux-raid, Nigel Croxon, linux



> On May 23, 2019, at 10:44 AM, Greg KH <greg@kroah.com> wrote:
> 
> On Wed, May 22, 2019 at 04:30:33PM +0000, Song Liu wrote:
>> Hi, 
>> 
>> As reported by Thorsten Knabe <linux@thorsten-knabe.de>. 
>> 
>> commit 4f4fd7c5798b ("Don't jump to compute_result state from check_result state")  
>> was back ported to v3.16+. However, this fix was wrong.  
>> 
>> Please back port the following two commits to fix this issue. 
>> 
>> commit a25d8c327bb4 ("Revert "Don't jump to compute_result state from check_result state"")
>> commit b2176a1dfb51 ("md/raid: raid5 preserve the writeback action after the parity check")
> 
> Added to 4.4+ for now.
> 
> thanks,
> 
> greg k-h

Thanks Greg!!

Song

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Fix bad backport to stable v3.16+
  2019-05-22 16:30 Fix bad backport to stable v3.16+ Song Liu
  2019-05-23 17:44 ` Greg KH
@ 2019-11-19 15:05 ` Ben Hutchings
  1 sibling, 0 replies; 4+ messages in thread
From: Ben Hutchings @ 2019-11-19 15:05 UTC (permalink / raw)
  To: Song Liu, stable; +Cc: linux-raid, Nigel Croxon, linux

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

On Wed, 2019-05-22 at 16:30 +0000, Song Liu wrote:
> Hi, 
> 
> As reported by Thorsten Knabe <linux@thorsten-knabe.de>. 
> 
> commit 4f4fd7c5798b ("Don't jump to compute_result state from check_result state")  
> was back ported to v3.16+. However, this fix was wrong.  

I never backported it to 3.16…

> Please back port the following two commits to fix this issue. 
> 
> commit a25d8c327bb4 ("Revert "Don't jump to compute_result state from check_result state"")

…so I didn't need this…

> commit b2176a1dfb51 ("md/raid: raid5 preserve the writeback action after the parity check")

…but I have queued this up, thanks.

Ben.

-- 
Ben Hutchings
Theory and practice are closer in theory than in practice - John Levine



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-19 15:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-22 16:30 Fix bad backport to stable v3.16+ Song Liu
2019-05-23 17:44 ` Greg KH
2019-05-23 18:11   ` Song Liu
2019-11-19 15:05 ` Ben Hutchings

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.