Add size property of EEPROM device

Add size property of EEPROM device

[he.huang]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Hi All,
I'm going to add the "size" property to the fru device .json file under entity-manager/configurations.

The requirement comes from:
When we write to the EEPROM we need the size to ensure that we won't write out of the range and return the correct complete code.

Here is an example for review:
https://gerrit.openbmc-project.xyz/c/openbmc/entity-manager/+/38532

If the proposal gets approved I will add the 'size' property to the other .json file under entity-manager/configurations.

Could you please help to review and let me know if you have any comments.
Thanks a lot.

2020-11-24


Helen.huang 

[-- Attachment #2: Type: text/html, Size: 2015 bytes --]

Re: Add size property of EEPROM device

[Brad Bishop]

On Tue, 2020-11-24 at 15:31 +0800, he.huang wrote:
> The requirement comes from:
> When we write to the EEPROM we need the size to ensure that we won't
> write out of the range and return the correct complete code.

Don't the eeprom drivers prevent this?

Re: Re: Add size property of EEPROM device

[he.huang]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

Hi Brad,
Yes, eeprom driver could help the requirement partially.
As Ed's comments on the patch, we still need the size in the upper level such as IPMI command handler, to differentiate the error between writing failed and writing out of the range, and return the correct complete code.
Thanks.

2020-11-26 

Helen.huang 



发件人：Brad Bishop <bradleyb@fuzziesquirrel.com>
发送时间：2020-11-25 23:36
主题：Re: Add size property of EEPROM device
收件人："he.huang"<he.huang@linux.intel.com>,"ed"<ed@tanous.net>,"jae.hyun.yoo"<jae.hyun.yoo@linux.intel.com>,"vernon.mauery"<vernon.mauery@linux.intel.com>,"openbmc"<openbmc@lists.ozlabs.org>
抄送：

On Tue, 2020-11-24 at 15:31 +0800, he.huang wrote: 
> The requirement comes from: 
> When we write to the EEPROM we need the size to ensure that we won't 
> write out of the range and return the correct complete code. 

Don't the eeprom drivers prevent this? 

[-- Attachment #2: Type: text/html, Size: 3401 bytes --]