[U-Boot] [PATCH] drivers/mmc/tegra2_mmc.c: fix GCC 4.6 warning

[U-Boot] [PATCH] drivers/mmc/tegra2_mmc.c: fix GCC 4.6 warning

[Anatolij Gustschin]

Fix:
tegra2_mmc.c: In function 'mmc_send_cmd':
tegra2_mmc.c:230:3: warning: 'mask' may be used uninitialized in this
function [-Wuninitialized]

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Doug Anderson <dianders@chromium.org>
Cc: Tom Warren <twarren@nvidia.com>
---
gcc is wrong here, I think. But I'd like to have a clean
build log.

Anatolij

 drivers/mmc/tegra2_mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/tegra2_mmc.c b/drivers/mmc/tegra2_mmc.c
index 33cc8fb..fb8a57d 100644
--- a/drivers/mmc/tegra2_mmc.c
+++ b/drivers/mmc/tegra2_mmc.c
@@ -162,7 +162,7 @@ static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 	struct mmc_host *host = (struct mmc_host *)mmc->priv;
 	int flags, i;
 	int result;
-	unsigned int mask;
+	unsigned int mask = 0;
 	unsigned int retry = 0x100000;
 	debug(" mmc_send_cmd called\n");
 
-- 
1.7.7.6

[U-Boot] [PATCH] drivers/mmc/tegra2_mmc.c: fix GCC 4.6 warning

[Tom Warren]

Anatolij,

> -----Original Message-----
> From: Anatolij Gustschin [mailto:agust at denx.de]
> Sent: Wednesday, March 28, 2012 6:40 AM
> To: u-boot at lists.denx.de
> Cc: Doug Anderson; Tom Warren
> Subject: [PATCH] drivers/mmc/tegra2_mmc.c: fix GCC 4.6 warning
> 
> Fix:
> tegra2_mmc.c: In function 'mmc_send_cmd':
> tegra2_mmc.c:230:3: warning: 'mask' may be used uninitialized in this
> function [-Wuninitialized]
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Doug Anderson <dianders@chromium.org>
> Cc: Tom Warren <twarren@nvidia.com>
> ---
> gcc is wrong here, I think. But I'd like to have a clean build log.
> 
I agree that gcc is being overly paranoid, but thanks for the fix!

Acked-by: Tom Warren <twarren@nvidia.com>

> Anatolij
> 
>  drivers/mmc/tegra2_mmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/tegra2_mmc.c b/drivers/mmc/tegra2_mmc.c index
> 33cc8fb..fb8a57d 100644
> --- a/drivers/mmc/tegra2_mmc.c
> +++ b/drivers/mmc/tegra2_mmc.c
> @@ -162,7 +162,7 @@ static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd
> *cmd,
>  	struct mmc_host *host = (struct mmc_host *)mmc->priv;
>  	int flags, i;
>  	int result;
> -	unsigned int mask;
> +	unsigned int mask = 0;
>  	unsigned int retry = 0x100000;
>  	debug(" mmc_send_cmd called\n");
> 
> --
> 1.7.7.6
-- 
nvpublic

[U-Boot] [PATCH] drivers/mmc/tegra2_mmc.c: fix GCC 4.6 warning

[Wolfgang Denk]

Dear Anatolij Gustschin,

In message <1332942000-4992-1-git-send-email-agust@denx.de> you wrote:
> Fix:
> tegra2_mmc.c: In function 'mmc_send_cmd':
> tegra2_mmc.c:230:3: warning: 'mask' may be used uninitialized in this
> function [-Wuninitialized]
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Doug Anderson <dianders@chromium.org>
> Cc: Tom Warren <twarren@nvidia.com>
> ---
> gcc is wrong here, I think. But I'd like to have a clean
> build log.
> 
> Anatolij
> 
>  drivers/mmc/tegra2_mmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Tom, Albert: hope this is OK with you; it fixes some real issues, and
I want to get clear for -rc1.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Command, n.:
            Statement presented by a human and accepted by a computer
in such a manner as to make the human feel as if he is in control.