From: Markus Theil <markus.theil@tu-ilmenau.de>
To: Sven Eckelmann <sven@narfation.org>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
kvalo@codeaurora.org
Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics
Date: Mon, 4 May 2020 18:33:43 +0200 [thread overview]
Message-ID: <5a4c9924-e727-30e7-8409-967c361c2fae@tu-ilmenau.de> (raw)
In-Reply-To: <1760068.xeLkAeoAig@bentobox>
On 5/4/20 6:29 PM, Sven Eckelmann wrote:
> On Monday, 4 May 2020 17:41:21 CEST Markus Theil wrote:
>> ath10k currently reports survey results for the last interval between each
>> invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this
>> can lead to unexpectedly small results, e.g. when hostapd uses survey
>> data and iw survey dump is invoked in parallel. Fix this by returning
>> cumulative results, that don't depend on the last invocation. Other
>> drivers, e.g. ath9k or mt76 also use this behavior.
> It is (unfortunately) not that trivial:
>
> See code and comments from other people:
>
> * https://patchwork.kernel.org/cover/11150285/
> * https://patchwork.kernel.org/patch/11150287/
> * https://patchwork.kernel.org/patch/11150289/
>
> Kind regards,
> Sven
Thanks a lot for pointing this out! I was not aware of your patch.
WARNING: multiple messages have this Message-ID (diff)
From: Markus Theil <markus.theil@tu-ilmenau.de>
To: Sven Eckelmann <sven@narfation.org>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics
Date: Mon, 4 May 2020 18:33:43 +0200 [thread overview]
Message-ID: <5a4c9924-e727-30e7-8409-967c361c2fae@tu-ilmenau.de> (raw)
In-Reply-To: <1760068.xeLkAeoAig@bentobox>
On 5/4/20 6:29 PM, Sven Eckelmann wrote:
> On Monday, 4 May 2020 17:41:21 CEST Markus Theil wrote:
>> ath10k currently reports survey results for the last interval between each
>> invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this
>> can lead to unexpectedly small results, e.g. when hostapd uses survey
>> data and iw survey dump is invoked in parallel. Fix this by returning
>> cumulative results, that don't depend on the last invocation. Other
>> drivers, e.g. ath9k or mt76 also use this behavior.
> It is (unfortunately) not that trivial:
>
> See code and comments from other people:
>
> * https://patchwork.kernel.org/cover/11150285/
> * https://patchwork.kernel.org/patch/11150287/
> * https://patchwork.kernel.org/patch/11150289/
>
> Kind regards,
> Sven
Thanks a lot for pointing this out! I was not aware of your patch.
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Markus Theil <markus.theil@tu-ilmenau.de>
To: Sven Eckelmann <sven@narfation.org>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics
Date: Mon, 4 May 2020 18:33:43 +0200 [thread overview]
Message-ID: <5a4c9924-e727-30e7-8409-967c361c2fae@tu-ilmenau.de> (raw)
In-Reply-To: <1760068.xeLkAeoAig@bentobox>
On 5/4/20 6:29 PM, Sven Eckelmann wrote:
> On Monday, 4 May 2020 17:41:21 CEST Markus Theil wrote:
>> ath10k currently reports survey results for the last interval between each
>> invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this
>> can lead to unexpectedly small results, e.g. when hostapd uses survey
>> data and iw survey dump is invoked in parallel. Fix this by returning
>> cumulative results, that don't depend on the last invocation. Other
>> drivers, e.g. ath9k or mt76 also use this behavior.
> It is (unfortunately) not that trivial:
>
> See code and comments from other people:
>
> * https://patchwork.kernel.org/cover/11150285/
> * https://patchwork.kernel.org/patch/11150287/
> * https://patchwork.kernel.org/patch/11150289/
>
> Kind regards,
> Sven
Thanks a lot for pointing this out! I was not aware of your patch.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-05-04 16:33 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 15:41 [PATCH 1/2] ath10k: use cumulative survey statistics Markus Theil
2020-05-04 15:41 ` Markus Theil
2020-05-04 15:41 ` Markus Theil
2020-05-04 15:41 ` [PATCH 2/2] ath11k: " Markus Theil
2020-05-04 15:41 ` Markus Theil
2020-05-04 15:41 ` Markus Theil
2020-05-04 16:36 ` Sven Eckelmann
2020-05-04 16:36 ` Sven Eckelmann
2020-05-04 16:36 ` Sven Eckelmann
2020-05-04 23:37 ` Rajkumar Manoharan
2020-05-04 23:37 ` Rajkumar Manoharan
2020-05-04 23:37 ` Rajkumar Manoharan
2020-05-05 6:53 ` Markus Theil
2020-05-05 6:53 ` Markus Theil
2020-05-05 6:53 ` Markus Theil
2020-05-05 17:31 ` Rajkumar Manoharan
2020-05-05 17:31 ` Rajkumar Manoharan
2020-05-05 17:31 ` Rajkumar Manoharan
2020-05-04 16:29 ` [PATCH 1/2] ath10k: " Sven Eckelmann
2020-05-04 16:29 ` Sven Eckelmann
2020-05-04 16:29 ` Sven Eckelmann
2020-05-04 16:33 ` Markus Theil [this message]
2020-05-04 16:33 ` Markus Theil
2020-05-04 16:33 ` Markus Theil
2020-05-04 23:46 ` Rajkumar Manoharan
2020-05-04 23:46 ` Rajkumar Manoharan
2020-05-04 23:46 ` Rajkumar Manoharan
2020-05-04 23:49 ` Ben Greear
2020-05-04 23:49 ` Ben Greear
2020-05-04 23:49 ` Ben Greear
2020-05-04 23:52 ` Rajkumar Manoharan
2020-05-04 23:52 ` Rajkumar Manoharan
2020-05-04 23:52 ` Rajkumar Manoharan
2020-05-05 0:02 ` Ben Greear
2020-05-05 0:02 ` Ben Greear
2020-05-05 0:02 ` Ben Greear
2020-05-05 7:01 ` Sven Eckelmann
2020-05-05 7:01 ` Sven Eckelmann
2020-05-05 7:01 ` Sven Eckelmann
2020-05-05 7:49 ` Sven Eckelmann
2020-05-05 7:49 ` Sven Eckelmann
2020-05-05 7:49 ` Sven Eckelmann
2020-05-05 7:55 ` Sven Eckelmann
2020-05-05 7:55 ` Sven Eckelmann
2020-05-05 7:55 ` Sven Eckelmann
2020-05-05 18:45 ` Rajkumar Manoharan
2020-05-05 18:45 ` Rajkumar Manoharan
2020-05-05 18:45 ` Rajkumar Manoharan
2020-05-05 15:37 ` Markus Theil
2020-05-05 15:37 ` Markus Theil
2020-05-05 15:37 ` Markus Theil
2020-05-05 18:32 ` Rajkumar Manoharan
2020-05-05 18:32 ` Rajkumar Manoharan
2020-05-05 18:32 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a4c9924-e727-30e7-8409-967c361c2fae@tu-ilmenau.de \
--to=markus.theil@tu-ilmenau.de \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.