All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 4/4] tools/objtool/Makefile: don't assume sync-check.sh is executable
@ 2018-01-13  0:53 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2018-01-13  0:53 UTC (permalink / raw)
  To: torvalds, mm-commits, akpm, jpoimboe, mingo, nicolasbock

From: Andrew Morton <akpm@linux-foundation.org>
Subject: tools/objtool/Makefile: don't assume sync-check.sh is executable

patch(1) loses the x bit.  So if a user follows our patching instructions
in Documentation/admin-guide/README.rst, their kernel will not compile.

Fixes: 3bd51c5a371de ("objtool: Move kernel headers/code sync check to a script")
Reported-by: Nicolas Bock <nicolasbock@gentoo.org>
Reported-by Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 tools/objtool/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN tools/objtool/Makefile~tools-objtool-makefile-dont-assume-sync-checksh-is-executable tools/objtool/Makefile
--- a/tools/objtool/Makefile~tools-objtool-makefile-dont-assume-sync-checksh-is-executable
+++ a/tools/objtool/Makefile
@@ -46,7 +46,7 @@ $(OBJTOOL_IN): fixdep FORCE
 	@$(MAKE) $(build)=objtool
 
 $(OBJTOOL): $(LIBSUBCMD) $(OBJTOOL_IN)
-	@./sync-check.sh
+	@$(CONFIG_SHELL) ./sync-check.sh
 	$(QUIET_LINK)$(CC) $(OBJTOOL_IN) $(LDFLAGS) -o $@
 
 
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-01-13  0:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-13  0:53 [patch 4/4] tools/objtool/Makefile: don't assume sync-check.sh is executable akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.