All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip over IGT_DRAW_BLT when there's no BLT
Date: Thu, 17 May 2018 16:16:48 -0700	[thread overview]
Message-ID: <5a6093f3-aa6c-46a6-2d04-df7af328b4c3@intel.com> (raw)
In-Reply-To: <20180517095605.25331-1-chris@chris-wilson.co.uk>



On 17/05/18 02:56, Chris Wilson wrote:
> If the blitter is not available, we cannot use it as a source for dirty
> rectangles. We shall have to rely on the other engines to create GPU
> dirty instead.
> 
> v2: Try using lots of subgroup+fixtures
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

>   	TEST_MODE_ITER_BEGIN(t)
> +		igt_fixture {
> +			if (t.method == IGT_DRAW_BLT)
> +				gem_require_blitter(drm.fd); > +		}

Put the require inside the subtest so to leave a constant sub-tests 
list. Unless I got lost in the nested macros ;).

Thanks,
Antonio

>   		igt_subtest_f("%s-%s-%s-%s-%s-draw-%s",
>   			      feature_str(t.feature),
>   			      pipes_str(t.pipes),

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-05-17 23:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17  8:23 [PATCH i-g-t 1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it Chris Wilson
2018-05-17  8:23 ` [PATCH i-g-t 2/3] igt/gem_blits: Check for blitter support before use Chris Wilson
2018-05-17 17:58   ` Antonio Argenziano
2018-05-17  8:23 ` [PATCH i-g-t 3/3] igt/kms_frontbuffer_tracking: Skip over IGT_DRAW_BLT when there's no BLT Chris Wilson
2018-05-17  9:56   ` [PATCH i-g-t] " Chris Wilson
2018-05-17 23:16     ` Antonio Argenziano [this message]
2018-05-17  9:28 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it Patchwork
2018-05-17 10:38 ` ✓ Fi.CI.BAT: success for series starting with [1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it (rev2) Patchwork
2018-05-17 13:43 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-17 15:08 ` [PATCH i-g-t 1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it Antonio Argenziano
2018-05-17 15:37   ` Chris Wilson
2018-05-17 16:29     ` Antonio Argenziano
2018-05-17 16:52       ` Chris Wilson
2018-05-17 17:01         ` Antonio Argenziano
2019-09-15  9:39 [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip over IGT_DRAW_BLT when there's no BLT Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a6093f3-aa6c-46a6-2d04-df7af328b4c3@intel.com \
    --to=antonio.argenziano@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.