All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeffrey Hugo <jhugo@codeaurora.org>
To: bbhatt@codeaurora.org
Cc: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Fan Wu <wufan@codeaurora.org>,
	jhugo=codeaurora.org@codeaurora.org
Subject: Re: [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full
Date: Tue, 16 Feb 2021 13:53:37 -0700	[thread overview]
Message-ID: <5a6a77d2-fc67-753f-7b9f-4a60c808ac92@codeaurora.org> (raw)
In-Reply-To: <e3b0dd23ea461ac76a61266b4c657d83@codeaurora.org>

On 2/16/2021 1:22 PM, Bhaumik Bhatt wrote:
> On 2021-02-16 10:48 AM, Jeffrey Hugo wrote:
>> From: Fan Wu <wufan@codeaurora.org>
>>
>> Currently ENOMEM is returned when MHI ring is full. This error code is
>> very misleading. Change to EBUSY instead.
>>
>> Signed-off-by: Fan Wu <wufan@codeaurora.org>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>>  drivers/bus/mhi/core/main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
>> index f182736..21eb5fc 100644
>> --- a/drivers/bus/mhi/core/main.c
>> +++ b/drivers/bus/mhi/core/main.c
>> @@ -996,7 +996,7 @@ static int mhi_queue(struct mhi_device *mhi_dev,
>> struct mhi_buf_info *buf_info,
>>
>>      ret = mhi_is_ring_full(mhi_cntrl, tre_ring);
>>      if (unlikely(ret)) {
>> -        ret = -ENOMEM;
>> +        ret = -EBUSY;
>>          goto exit_unlock;
>>      }
> 
> ENOMEM is descriptive of the state of the ring since you basically 
> cannot queue any
> more packets as no memory is currently available.
> 
> But I agree, it can be misleading for this API. How about EAGAIN in 
> place of EBUSY,
> which tells the user to try the queue attempt again implying memory 
> should become
> available as more elements are consumed by the device/client?

Fan and I think EAGAIN is fine.  Will send a v2.

-- 
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2021-02-16 20:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 18:48 [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full Jeffrey Hugo
2021-02-16 20:22 ` Bhaumik Bhatt
2021-02-16 20:53   ` Jeffrey Hugo [this message]
2021-02-17  3:26 ` Manivannan Sadhasivam
2021-02-17 15:02 ` Loic Poulain
2021-02-17 15:06   ` Jeffrey Hugo
2021-02-17 16:14     ` Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a6a77d2-fc67-753f-7b9f-4a60c808ac92@codeaurora.org \
    --to=jhugo@codeaurora.org \
    --cc=bbhatt@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo=codeaurora.org@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=wufan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.