From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Hemant Kumar <hemantk@codeaurora.org>,
Bhaumik Bhatt <bbhatt@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Fan Wu <wufan@codeaurora.org>
Subject: Re: [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full
Date: Wed, 17 Feb 2021 08:06:48 -0700 [thread overview]
Message-ID: <eb873085-4120-7ec4-1f18-1c768ed741bd@codeaurora.org> (raw)
In-Reply-To: <CAMZdPi9S5OnWs_QFnf+xVM+jLve6cpdvi_vpC_KdEbUUaqoFYg@mail.gmail.com>
On 2/17/2021 8:02 AM, Loic Poulain wrote:
> On Tue, 16 Feb 2021 at 19:50, Jeffrey Hugo <jhugo@codeaurora.org> wrote:
>>
>> From: Fan Wu <wufan@codeaurora.org>
>>
>> Currently ENOMEM is returned when MHI ring is full. This error code is
>> very misleading. Change to EBUSY instead.
>
> Well, there is no space left in the ring, so it's no so misleading.
ENOMEM is typically a memory allocation failure which is not what a
client is going to think of regarding the ring, and it's not a unique
failure code in this case. gen_tre can also return ENOMEM, which makes
it difficult for the client to know if there is some significant
failure, or they might just need to wait (assuming that is something the
client can do).
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-02-17 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 18:48 [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full Jeffrey Hugo
2021-02-16 20:22 ` Bhaumik Bhatt
2021-02-16 20:53 ` Jeffrey Hugo
2021-02-17 3:26 ` Manivannan Sadhasivam
2021-02-17 15:02 ` Loic Poulain
2021-02-17 15:06 ` Jeffrey Hugo [this message]
2021-02-17 16:14 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb873085-4120-7ec4-1f18-1c768ed741bd@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=wufan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.