From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Srinivas Neeli <srinivas.neeli@amd.com>, wim@linux-watchdog.org, linux@roeck-us.net, shubhrajyoti.datta@amd.com, michal.simek@amd.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, git@amd.com Subject: Re: [PATCH 1/3] dt-bindings: watchdog: xlnx,versal-wwdt: Add binding documentation for xilinx window watchdog device Date: Fri, 30 Sep 2022 12:31:40 +0200 [thread overview] Message-ID: <5a7816e8-9ee8-a2c6-04a1-d27807ace0f2@linaro.org> (raw) In-Reply-To: <20220927110257.41963-2-srinivas.neeli@amd.com> On 27/09/2022 13:02, Srinivas Neeli wrote: > Add documentation for the binding of window watchdog device. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@amd.com> > --- > .../bindings/watchdog/xlnx,versal-wwdt.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > new file mode 100644 > index 000000000000..986455efa6f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/xlnx,versal-wwdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx Versal window watchdog timer controller > + > +maintainers: > + - Neeli Srinivas <srinivas.neeli@amd.com> > + > +description: > + Versal watchdog driver uses window watchdog mode. Window watchdog > + timer(WWDT) contains closed(first) and open(second) window with > + 32 bit width. Write to the watchdog timer within predefined window > + periods of time. This means a period that is not too soon and a > + period that is not too late. The WWDT has to be restarted within > + the open window time. If software tries to restart WWDT outside of > + the open window time period, it generates a reset. > + Missing ref to watchdog. > +properties: > + compatible: > + enum: > + - xlnx,versal-wwdt-1.0 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + timeout-sec: true This can be dropped. > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false and this then can be unevaluatedProperties:false > + > +examples: > + - | > + watchdog@fd4d0000 { Use 4 spaces for example indentation. > + compatible = "xlnx,versal-wwdt-1.0"; > + reg = <0xfd4d0000 0x10000>; > + clocks = <&clock25>; > + timeout-sec = <30>; > + }; > +... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Srinivas Neeli <srinivas.neeli@amd.com>, wim@linux-watchdog.org, linux@roeck-us.net, shubhrajyoti.datta@amd.com, michal.simek@amd.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, git@amd.com Subject: Re: [PATCH 1/3] dt-bindings: watchdog: xlnx,versal-wwdt: Add binding documentation for xilinx window watchdog device Date: Fri, 30 Sep 2022 12:31:40 +0200 [thread overview] Message-ID: <5a7816e8-9ee8-a2c6-04a1-d27807ace0f2@linaro.org> (raw) In-Reply-To: <20220927110257.41963-2-srinivas.neeli@amd.com> On 27/09/2022 13:02, Srinivas Neeli wrote: > Add documentation for the binding of window watchdog device. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@amd.com> > --- > .../bindings/watchdog/xlnx,versal-wwdt.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > new file mode 100644 > index 000000000000..986455efa6f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/xlnx,versal-wwdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx Versal window watchdog timer controller > + > +maintainers: > + - Neeli Srinivas <srinivas.neeli@amd.com> > + > +description: > + Versal watchdog driver uses window watchdog mode. Window watchdog > + timer(WWDT) contains closed(first) and open(second) window with > + 32 bit width. Write to the watchdog timer within predefined window > + periods of time. This means a period that is not too soon and a > + period that is not too late. The WWDT has to be restarted within > + the open window time. If software tries to restart WWDT outside of > + the open window time period, it generates a reset. > + Missing ref to watchdog. > +properties: > + compatible: > + enum: > + - xlnx,versal-wwdt-1.0 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + timeout-sec: true This can be dropped. > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false and this then can be unevaluatedProperties:false > + > +examples: > + - | > + watchdog@fd4d0000 { Use 4 spaces for example indentation. > + compatible = "xlnx,versal-wwdt-1.0"; > + reg = <0xfd4d0000 0x10000>; > + clocks = <&clock25>; > + timeout-sec = <30>; > + }; > +... Best regards, Krzysztof
next prev parent reply other threads:[~2022-09-30 10:32 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-27 11:02 [PATCH 0/3] watchdog: xilinx_wwdt: Add Versal watchdog support Srinivas Neeli 2022-09-27 11:02 ` Srinivas Neeli 2022-09-27 11:02 ` [PATCH 1/3] dt-bindings: watchdog: xlnx,versal-wwdt: Add binding documentation for xilinx window watchdog device Srinivas Neeli 2022-09-27 11:02 ` Srinivas Neeli 2022-09-29 22:20 ` Rob Herring 2022-09-29 22:20 ` Rob Herring 2022-09-30 10:31 ` Krzysztof Kozlowski [this message] 2022-09-30 10:31 ` Krzysztof Kozlowski 2022-09-27 11:02 ` [PATCH 2/3] watchdog: xilinx_wwdt: Add Versal window watchdog support Srinivas Neeli 2022-09-27 11:02 ` Srinivas Neeli 2022-09-30 10:35 ` Krzysztof Kozlowski 2022-09-30 10:35 ` Krzysztof Kozlowski 2022-10-02 16:06 ` Guenter Roeck 2022-10-02 16:06 ` Guenter Roeck 2022-10-02 16:29 ` Guenter Roeck 2022-10-02 16:29 ` Guenter Roeck 2022-10-03 7:00 ` Krzysztof Kozlowski 2022-10-03 7:00 ` Krzysztof Kozlowski 2022-10-02 16:25 ` Guenter Roeck 2022-10-02 16:25 ` Guenter Roeck 2022-10-11 6:27 ` Neeli, Srinivas 2022-10-11 6:27 ` Neeli, Srinivas 2022-11-03 16:51 ` Neeli, Srinivas 2022-11-03 16:51 ` Neeli, Srinivas 2022-11-03 17:24 ` Guenter Roeck 2022-11-03 17:24 ` Guenter Roeck 2022-11-06 15:16 ` Neeli, Srinivas 2022-11-06 15:16 ` Neeli, Srinivas 2022-12-01 11:08 ` Michal Simek 2022-12-01 11:08 ` Michal Simek 2022-12-01 15:56 ` Guenter Roeck 2022-12-01 15:56 ` Guenter Roeck 2022-10-03 2:06 ` kernel test robot 2022-09-27 11:02 ` [PATCH 3/3] MAINTAINERS: Add fragment for Xilinx watchdog drivers Srinivas Neeli 2022-09-27 11:02 ` Srinivas Neeli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5a7816e8-9ee8-a2c6-04a1-d27807ace0f2@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=git@amd.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=michal.simek@amd.com \ --cc=robh+dt@kernel.org \ --cc=shubhrajyoti.datta@amd.com \ --cc=srinivas.neeli@amd.com \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.