From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Gene Chen <gene.chen.richtek@gmail.com>,
pavel@ucw.cz, robh+dt@kernel.org, matthias.bgg@gmail.com
Cc: dmurphy@ti.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
gene_chen@richtek.com, Wilma.Wu@mediatek.com,
shufan_lee@richtek.com, cy_huang@richtek.com,
benjamin.chao@mediatek.com
Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360
Date: Thu, 8 Oct 2020 23:51:22 +0200 [thread overview]
Message-ID: <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> (raw)
In-Reply-To: <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com>
Hi Gene,
On 10/7/20 3:42 AM, Gene Chen wrote:
> From: Gene Chen <gene_chen@richtek.com>
>
> Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode,
> 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for
> moonlight LED.
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> ---
> drivers/leds/Kconfig | 12 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-mt6360.c | 783 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 796 insertions(+)
> create mode 100644 drivers/leds/leds-mt6360.c
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 1c181df..c7192dd 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -271,6 +271,18 @@ config LEDS_MT6323
> This option enables support for on-chip LED drivers found on
> Mediatek MT6323 PMIC.
>
> +config LEDS_MT6360
> + tristate "LED Support for Mediatek MT6360 PMIC"
> + depends on LEDS_CLASS_FLASH && OF
> + depends on LEDS_CLASS_MULTICOLOR
Since CONFIG_LED_CLASS_MULTICOLOR can be turned off you need to have
below instead:
depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR
Unless you want to prevent enabling the driver without RGB LED,
but that does not seem to be reasonable at first glance.
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> + depends on MFD_MT6360
> + help
> + This option enables support for dual Flash LED drivers found on
> + Mediatek MT6360 PMIC.
> + Independent current sources supply for each flash LED support torch
> + and strobe mode.
> +
--
Best regards,
Jacek Anaszewski
WARNING: multiple messages have this Message-ID (diff)
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Gene Chen <gene.chen.richtek@gmail.com>,
pavel@ucw.cz, robh+dt@kernel.org, matthias.bgg@gmail.com
Cc: gene_chen@richtek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cy_huang@richtek.com,
benjamin.chao@mediatek.com, linux-mediatek@lists.infradead.org,
dmurphy@ti.com, linux-leds@vger.kernel.org,
Wilma.Wu@mediatek.com, linux-arm-kernel@lists.infradead.org,
shufan_lee@richtek.com
Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360
Date: Thu, 8 Oct 2020 23:51:22 +0200 [thread overview]
Message-ID: <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> (raw)
In-Reply-To: <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com>
Hi Gene,
On 10/7/20 3:42 AM, Gene Chen wrote:
> From: Gene Chen <gene_chen@richtek.com>
>
> Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode,
> 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for
> moonlight LED.
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> ---
> drivers/leds/Kconfig | 12 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-mt6360.c | 783 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 796 insertions(+)
> create mode 100644 drivers/leds/leds-mt6360.c
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 1c181df..c7192dd 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -271,6 +271,18 @@ config LEDS_MT6323
> This option enables support for on-chip LED drivers found on
> Mediatek MT6323 PMIC.
>
> +config LEDS_MT6360
> + tristate "LED Support for Mediatek MT6360 PMIC"
> + depends on LEDS_CLASS_FLASH && OF
> + depends on LEDS_CLASS_MULTICOLOR
Since CONFIG_LED_CLASS_MULTICOLOR can be turned off you need to have
below instead:
depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR
Unless you want to prevent enabling the driver without RGB LED,
but that does not seem to be reasonable at first glance.
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> + depends on MFD_MT6360
> + help
> + This option enables support for dual Flash LED drivers found on
> + Mediatek MT6360 PMIC.
> + Independent current sources supply for each flash LED support torch
> + and strobe mode.
> +
--
Best regards,
Jacek Anaszewski
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Gene Chen <gene.chen.richtek@gmail.com>,
pavel@ucw.cz, robh+dt@kernel.org, matthias.bgg@gmail.com
Cc: gene_chen@richtek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cy_huang@richtek.com,
benjamin.chao@mediatek.com, linux-mediatek@lists.infradead.org,
dmurphy@ti.com, linux-leds@vger.kernel.org,
Wilma.Wu@mediatek.com, linux-arm-kernel@lists.infradead.org,
shufan_lee@richtek.com
Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360
Date: Thu, 8 Oct 2020 23:51:22 +0200 [thread overview]
Message-ID: <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> (raw)
In-Reply-To: <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com>
Hi Gene,
On 10/7/20 3:42 AM, Gene Chen wrote:
> From: Gene Chen <gene_chen@richtek.com>
>
> Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode,
> 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for
> moonlight LED.
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> ---
> drivers/leds/Kconfig | 12 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-mt6360.c | 783 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 796 insertions(+)
> create mode 100644 drivers/leds/leds-mt6360.c
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 1c181df..c7192dd 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -271,6 +271,18 @@ config LEDS_MT6323
> This option enables support for on-chip LED drivers found on
> Mediatek MT6323 PMIC.
>
> +config LEDS_MT6360
> + tristate "LED Support for Mediatek MT6360 PMIC"
> + depends on LEDS_CLASS_FLASH && OF
> + depends on LEDS_CLASS_MULTICOLOR
Since CONFIG_LED_CLASS_MULTICOLOR can be turned off you need to have
below instead:
depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR
Unless you want to prevent enabling the driver without RGB LED,
but that does not seem to be reasonable at first glance.
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> + depends on MFD_MT6360
> + help
> + This option enables support for dual Flash LED drivers found on
> + Mediatek MT6360 PMIC.
> + Independent current sources supply for each flash LED support torch
> + and strobe mode.
> +
--
Best regards,
Jacek Anaszewski
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-08 21:51 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 1:42 [PATCH v5 0/2] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-10-07 1:42 ` Gene Chen
2020-10-07 1:42 ` Gene Chen
2020-10-07 1:42 ` [PATCH v5 1/2] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-10-07 1:42 ` Gene Chen
2020-10-07 1:42 ` Gene Chen
2020-10-07 13:50 ` Rob Herring
2020-10-07 13:50 ` Rob Herring
2020-10-07 13:50 ` Rob Herring
2020-10-08 21:42 ` Jacek Anaszewski
2020-10-08 21:42 ` Jacek Anaszewski
2020-10-08 21:42 ` Jacek Anaszewski
2020-10-07 1:42 ` [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-10-07 1:42 ` Gene Chen
2020-10-07 1:42 ` Gene Chen
2020-10-07 5:11 ` kernel test robot
2020-10-07 5:11 ` kernel test robot
2020-10-07 5:11 ` kernel test robot
2020-10-07 5:11 ` kernel test robot
2020-10-08 21:51 ` Jacek Anaszewski [this message]
2020-10-08 21:51 ` Jacek Anaszewski
2020-10-08 21:51 ` Jacek Anaszewski
2020-10-20 6:44 ` Gene Chen
2020-10-20 6:44 ` Gene Chen
2020-10-20 6:44 ` Gene Chen
2020-10-20 21:46 ` Jacek Anaszewski
2020-10-20 21:46 ` Jacek Anaszewski
2020-10-20 21:46 ` Jacek Anaszewski
2020-10-27 9:28 ` Gene Chen
2020-10-27 9:28 ` Gene Chen
2020-10-27 9:28 ` Gene Chen
2020-10-27 17:28 ` Jacek Anaszewski
2020-10-27 17:28 ` Jacek Anaszewski
2020-10-27 17:28 ` Jacek Anaszewski
2020-10-30 8:51 ` Gene Chen
2020-10-30 8:51 ` Gene Chen
2020-10-30 8:51 ` Gene Chen
2020-10-30 22:34 ` Jacek Anaszewski
2020-10-30 22:34 ` Jacek Anaszewski
2020-10-30 22:34 ` Jacek Anaszewski
2020-11-16 10:01 ` Gene Chen
2020-11-16 10:01 ` Gene Chen
2020-11-16 10:01 ` Gene Chen
2020-11-16 18:25 ` Jacek Anaszewski
2020-11-16 18:25 ` Jacek Anaszewski
2020-11-16 18:25 ` Jacek Anaszewski
2020-11-17 9:54 ` Gene Chen
2020-11-17 9:54 ` Gene Chen
2020-11-17 9:54 ` Gene Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.