From: Alex Belits <abelits@marvell.com> To: "frederic@kernel.org" <frederic@kernel.org>, "rostedt@goodmis.org" <rostedt@goodmis.org> Cc: Prasun Kapoor <pkapoor@marvell.com>, "mingo@kernel.org" <mingo@kernel.org>, "davem@davemloft.net" <davem@davemloft.net>, "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>, "peterz@infradead.org" <peterz@infradead.org>, "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "will@kernel.org" <will@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org> Subject: [PATCH v4 10/13] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Date: Wed, 22 Jul 2020 14:57:33 +0000 [thread overview] Message-ID: <5acf7502c071c0d1365ba5e5940e003a7da6521f.camel@marvell.com> (raw) In-Reply-To: <04be044c1bcd76b7438b7563edc35383417f12c8.camel@marvell.com> From: Yuri Norov <ynorov@marvell.com> For nohz_full CPUs the desirable behavior is to receive interrupts generated by tick_nohz_full_kick_cpu(). But for hard isolation it's obviously not desirable because it breaks isolation. This patch adds check for it. Signed-off-by: Yuri Norov <ynorov@marvell.com> [abelits@marvell.com: updated, only exclude CPUs running isolated tasks] Signed-off-by: Alex Belits <abelits@marvell.com> --- kernel/time/tick-sched.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 6e4cd8459f05..2f82a6daf8fc 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -20,6 +20,7 @@ #include <linux/sched/clock.h> #include <linux/sched/stat.h> #include <linux/sched/nohz.h> +#include <linux/isolation.h> #include <linux/module.h> #include <linux/irq_work.h> #include <linux/posix-timers.h> @@ -268,7 +269,8 @@ static void tick_nohz_full_kick(void) */ void tick_nohz_full_kick_cpu(int cpu) { - if (!tick_nohz_full_cpu(cpu)) + smp_rmb(); + if (!tick_nohz_full_cpu(cpu) || task_isolation_on_cpu(cpu)) return; irq_work_queue_on(&per_cpu(nohz_full_kick_work, cpu), cpu); -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Alex Belits <abelits@marvell.com> To: "frederic@kernel.org" <frederic@kernel.org>, "rostedt@goodmis.org" <rostedt@goodmis.org> Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "peterz@infradead.org" <peterz@infradead.org>, Prasun Kapoor <pkapoor@marvell.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "davem@davemloft.net" <davem@davemloft.net>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>, "tglx@linutronix.de" <tglx@linutronix.de>, "will@kernel.org" <will@kernel.org>, "mingo@kernel.org" <mingo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: [PATCH v4 10/13] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Date: Wed, 22 Jul 2020 14:57:33 +0000 [thread overview] Message-ID: <5acf7502c071c0d1365ba5e5940e003a7da6521f.camel@marvell.com> (raw) In-Reply-To: <04be044c1bcd76b7438b7563edc35383417f12c8.camel@marvell.com> From: Yuri Norov <ynorov@marvell.com> For nohz_full CPUs the desirable behavior is to receive interrupts generated by tick_nohz_full_kick_cpu(). But for hard isolation it's obviously not desirable because it breaks isolation. This patch adds check for it. Signed-off-by: Yuri Norov <ynorov@marvell.com> [abelits@marvell.com: updated, only exclude CPUs running isolated tasks] Signed-off-by: Alex Belits <abelits@marvell.com> --- kernel/time/tick-sched.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 6e4cd8459f05..2f82a6daf8fc 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -20,6 +20,7 @@ #include <linux/sched/clock.h> #include <linux/sched/stat.h> #include <linux/sched/nohz.h> +#include <linux/isolation.h> #include <linux/module.h> #include <linux/irq_work.h> #include <linux/posix-timers.h> @@ -268,7 +269,8 @@ static void tick_nohz_full_kick(void) */ void tick_nohz_full_kick_cpu(int cpu) { - if (!tick_nohz_full_cpu(cpu)) + smp_rmb(); + if (!tick_nohz_full_cpu(cpu) || task_isolation_on_cpu(cpu)) return; irq_work_queue_on(&per_cpu(nohz_full_kick_work, cpu), cpu); -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-22 14:58 UTC|newest] Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-22 14:44 [PATCH v4 00/13] "Task_isolation" mode Alex Belits 2020-07-22 14:44 ` Alex Belits 2020-07-22 14:44 ` Alex Belits 2020-07-22 14:47 ` [PATCH v4 01/13] task_isolation: vmstat: add quiet_vmstat_sync function Alex Belits 2020-07-22 14:47 ` Alex Belits 2020-07-22 14:47 ` Alex Belits 2020-07-22 14:47 ` Alex Belits 2020-07-22 14:48 ` [PATCH v4 02/13] task_isolation: vmstat: add vmstat_idle function Alex Belits 2020-07-22 14:48 ` Alex Belits 2020-07-22 14:48 ` Alex Belits 2020-07-22 14:49 ` [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel Alex Belits 2020-07-22 14:49 ` Alex Belits 2020-07-22 14:49 ` Alex Belits 2020-10-01 13:56 ` Frederic Weisbecker 2020-10-01 13:56 ` Frederic Weisbecker 2020-10-04 14:44 ` [EXT] " Alex Belits 2020-10-04 14:44 ` Alex Belits 2020-10-04 23:14 ` Frederic Weisbecker 2020-10-04 23:14 ` Frederic Weisbecker 2020-10-05 18:52 ` Nitesh Narayan Lal 2020-10-05 18:52 ` Nitesh Narayan Lal 2020-10-06 10:35 ` Frederic Weisbecker 2020-10-06 10:35 ` Frederic Weisbecker 2020-10-17 1:13 ` Alex Belits 2020-10-17 1:13 ` Alex Belits 2020-10-17 1:08 ` Alex Belits 2020-10-17 1:08 ` Alex Belits 2020-10-17 16:08 ` Thomas Gleixner 2020-10-17 16:08 ` Thomas Gleixner 2020-10-17 16:15 ` Alex Belits 2020-10-17 16:15 ` Alex Belits 2020-10-17 20:03 ` Thomas Gleixner 2020-10-17 20:03 ` Thomas Gleixner 2020-10-06 11:01 ` Alex Belits 2020-10-06 11:01 ` Alex Belits 2020-10-01 14:40 ` Frederic Weisbecker 2020-10-01 14:40 ` Frederic Weisbecker 2020-10-04 15:01 ` [EXT] " Alex Belits 2020-10-04 15:01 ` Alex Belits 2020-07-22 14:51 ` [PATCH v4 04/13] task_isolation: Add task isolation hooks to arch-independent code Alex Belits 2020-07-22 14:51 ` Alex Belits 2020-07-22 14:51 ` Alex Belits 2020-07-22 14:51 ` Alex Belits 2020-07-22 14:51 ` [PATCH v4 05/13] task_isolation: Add xen-specific hook Alex Belits 2020-07-22 14:51 ` Alex Belits 2020-07-22 14:51 ` Alex Belits 2020-07-22 14:53 ` [PATCH 06/13] task_isolation: Add driver-specific hooks Alex Belits 2020-07-22 14:53 ` Alex Belits 2020-07-22 14:53 ` Alex Belits 2020-07-22 14:54 ` [PATCH v4 07/13] task_isolation: arch/x86: enable task isolation functionality Alex Belits 2020-07-22 14:54 ` Alex Belits 2020-07-22 14:54 ` Alex Belits 2020-07-22 14:55 ` [PATCH 08/13] task_isolation: arch/arm64: " Alex Belits 2020-07-22 14:55 ` Alex Belits 2020-07-22 14:55 ` Alex Belits 2020-07-22 14:55 ` Alex Belits 2020-07-22 14:56 ` [PATCH v4 09/13] task_isolation: arch/arm: " Alex Belits 2020-07-22 14:56 ` Alex Belits 2020-07-22 14:56 ` Alex Belits 2020-07-22 14:56 ` Alex Belits 2020-07-22 14:57 ` Alex Belits [this message] 2020-07-22 14:57 ` [PATCH v4 10/13] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Alex Belits 2020-07-22 14:57 ` Alex Belits 2020-10-01 14:44 ` Frederic Weisbecker 2020-10-01 14:44 ` Frederic Weisbecker 2020-10-04 15:22 ` [EXT] " Alex Belits 2020-10-04 15:22 ` Alex Belits 2020-10-06 21:41 ` Frederic Weisbecker 2020-10-06 21:41 ` Frederic Weisbecker 2020-10-17 0:17 ` Alex Belits 2020-10-17 0:17 ` Alex Belits 2020-07-22 14:58 ` [PATCH v4 11/13] task_isolation: net: don't flush backlog on CPUs running isolated tasks Alex Belits 2020-07-22 14:58 ` Alex Belits 2020-07-22 14:58 ` Alex Belits 2020-07-22 14:58 ` Alex Belits 2020-10-01 14:47 ` Frederic Weisbecker 2020-10-01 14:47 ` Frederic Weisbecker 2020-10-04 17:12 ` [EXT] " Alex Belits 2020-10-04 17:12 ` Alex Belits 2021-01-22 14:13 ` Marcelo Tosatti 2021-01-22 14:13 ` Marcelo Tosatti 2021-01-22 16:13 ` Paolo Abeni 2021-01-22 16:13 ` Paolo Abeni 2020-07-22 14:59 ` [PATCH v4 12/13] task_isolation: ringbuffer: don't interrupt CPUs running isolated tasks on buffer resize Alex Belits 2020-07-22 14:59 ` Alex Belits 2020-07-22 14:59 ` Alex Belits 2020-07-22 14:59 ` [PATCH 13/13] task_isolation: kick_all_cpus_sync: don't kick isolated cpus Alex Belits 2020-07-22 14:59 ` Alex Belits 2020-07-22 14:59 ` Alex Belits 2020-07-22 14:59 ` Alex Belits 2020-07-23 13:17 ` [PATCH v4 00/13] "Task_isolation" mode Thomas Gleixner 2020-07-23 13:17 ` Thomas Gleixner 2020-07-23 13:17 ` Thomas Gleixner 2020-07-23 14:26 ` Peter Zijlstra 2020-07-23 14:26 ` Peter Zijlstra 2020-07-23 14:26 ` Peter Zijlstra 2020-07-23 14:53 ` Thomas Gleixner 2020-07-23 14:53 ` Thomas Gleixner 2020-07-23 14:53 ` Thomas Gleixner 2020-07-23 14:29 ` Peter Zijlstra 2020-07-23 14:29 ` Peter Zijlstra 2020-07-23 14:29 ` Peter Zijlstra 2020-07-23 15:41 ` [EXT] " Alex Belits 2020-07-23 15:41 ` Alex Belits 2020-07-23 15:41 ` Alex Belits 2020-07-23 15:48 ` Peter Zijlstra 2020-07-23 15:48 ` Peter Zijlstra 2020-07-23 15:48 ` Peter Zijlstra 2020-07-23 16:19 ` Alex Belits 2020-07-23 16:19 ` Alex Belits 2020-07-23 16:19 ` Alex Belits 2020-07-23 15:18 ` Alex Belits 2020-07-23 15:18 ` Alex Belits 2020-07-23 15:18 ` Alex Belits 2020-07-23 15:49 ` Peter Zijlstra 2020-07-23 15:49 ` Peter Zijlstra 2020-07-23 15:49 ` Peter Zijlstra 2020-07-23 15:49 ` Peter Zijlstra 2020-07-23 16:50 ` Alex Belits 2020-07-23 16:50 ` Alex Belits 2020-07-23 16:50 ` Alex Belits 2020-07-23 21:44 ` Thomas Gleixner 2020-07-23 21:44 ` Thomas Gleixner 2020-07-23 21:44 ` Thomas Gleixner 2020-07-24 3:00 ` [EXT] " Alex Belits 2020-07-24 3:00 ` Alex Belits 2020-07-24 3:00 ` Alex Belits 2020-07-24 16:08 ` Thomas Gleixner 2020-07-24 16:08 ` Thomas Gleixner 2020-07-24 16:08 ` Thomas Gleixner 2020-07-23 21:31 ` Thomas Gleixner 2020-07-23 21:31 ` Thomas Gleixner 2020-07-23 21:31 ` Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5acf7502c071c0d1365ba5e5940e003a7da6521f.camel@marvell.com \ --to=abelits@marvell.com \ --cc=catalin.marinas@arm.com \ --cc=davem@davemloft.net \ --cc=frederic@kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=peterz@infradead.org \ --cc=pkapoor@marvell.com \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.