From: "Arnd Bergmann" <arnd@arndb.de>
To: "Hawkins, Nick" <nick.hawkins@hpe.com>,
"Verdun, Jean-Marie" <verdun@hpe.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Rob Herring" <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org,
"Jonathan Corbet" <corbet@lwn.net>,
"Russell King" <linux@armlinux.org.uk>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/5] ARM: dts: add GXP Support for fans and SPI
Date: Thu, 12 Jan 2023 15:24:51 +0100 [thread overview]
Message-ID: <5ad677f3-2cbc-4ba0-bd48-2f832a72fb28@app.fastmail.com> (raw)
In-Reply-To: <20230103203654.59322-4-nick.hawkins@hpe.com>
On Tue, Jan 3, 2023, at 21:36, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
>
> Reorganize the base address of AHB to accommodate the SPI and fan driver
> register requirements. Add the hpe,gxp-spifi and hpe,gxp-fan-ctrl
> compatibles. Add comments to make the register range more clear.
>
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
>
> diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi
> b/arch/arm/boot/dts/hpe-gxp.dtsi
> index cf735b3c4f35..b73b22a93716 100644
> --- a/arch/arm/boot/dts/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe-gxp.dtsi
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree file for HPE GXP
> + * Device Tree for HPE
> */
>
> /dts-v1/;
> @@ -52,76 +52,102 @@
> cache-level = <2>;
> };
>
> - ahb@c0000000 {
> + ahb@80000000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0x0 0xc0000000 0x30000000>;
> + ranges = <0x0 0x80000000 0xf000000>, /* 0x80000000 - 0x8f000000 */
> + <0x40000000 0xc0000000 0x7fffffff>; /* 0xc0000000 - 0xffffffff */
I'm a bit confused by the change in the mappings: are you
sure this all the same ahb bus and not two separate buses?
The comment for the second range looks wrong to me, as
you define a 2GB (minus one byte) sized mapping but the
comment only lists a 1GB (including the last byte) mapping.
I would expect that the original 0x30000000 (including the
last byte) was correct here.
> - vic1: interrupt-controller@80f00000 {
> + vic1: interrupt-controller@f00000 { /* 0x80f00000 */
This is not the same address as before. I'm also not sure the
comment is helpful here.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Hawkins, Nick" <nick.hawkins@hpe.com>,
"Verdun, Jean-Marie" <verdun@hpe.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Rob Herring" <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org,
"Jonathan Corbet" <corbet@lwn.net>,
"Russell King" <linux@armlinux.org.uk>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/5] ARM: dts: add GXP Support for fans and SPI
Date: Thu, 12 Jan 2023 15:24:51 +0100 [thread overview]
Message-ID: <5ad677f3-2cbc-4ba0-bd48-2f832a72fb28@app.fastmail.com> (raw)
In-Reply-To: <20230103203654.59322-4-nick.hawkins@hpe.com>
On Tue, Jan 3, 2023, at 21:36, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
>
> Reorganize the base address of AHB to accommodate the SPI and fan driver
> register requirements. Add the hpe,gxp-spifi and hpe,gxp-fan-ctrl
> compatibles. Add comments to make the register range more clear.
>
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
>
> diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi
> b/arch/arm/boot/dts/hpe-gxp.dtsi
> index cf735b3c4f35..b73b22a93716 100644
> --- a/arch/arm/boot/dts/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe-gxp.dtsi
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree file for HPE GXP
> + * Device Tree for HPE
> */
>
> /dts-v1/;
> @@ -52,76 +52,102 @@
> cache-level = <2>;
> };
>
> - ahb@c0000000 {
> + ahb@80000000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0x0 0xc0000000 0x30000000>;
> + ranges = <0x0 0x80000000 0xf000000>, /* 0x80000000 - 0x8f000000 */
> + <0x40000000 0xc0000000 0x7fffffff>; /* 0xc0000000 - 0xffffffff */
I'm a bit confused by the change in the mappings: are you
sure this all the same ahb bus and not two separate buses?
The comment for the second range looks wrong to me, as
you define a 2GB (minus one byte) sized mapping but the
comment only lists a 1GB (including the last byte) mapping.
I would expect that the original 0x30000000 (including the
last byte) was correct here.
> - vic1: interrupt-controller@80f00000 {
> + vic1: interrupt-controller@f00000 { /* 0x80f00000 */
This is not the same address as before. I'm also not sure the
comment is helpful here.
Arnd
next prev parent reply other threads:[~2023-01-12 14:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 20:36 [PATCH v4 0/5] ARM: Add GXP Fan and SPI controllers nick.hawkins
2023-01-03 20:36 ` nick.hawkins
2023-01-03 20:36 ` [PATCH v4 1/5] hwmon: (gxp-fan-ctrl) Add GXP fan controller nick.hawkins
2023-01-03 20:36 ` nick.hawkins
2023-01-03 21:34 ` Guenter Roeck
2023-01-03 21:34 ` Guenter Roeck
2023-01-03 20:36 ` [PATCH v4 2/5] dt-bindings: hwmon: Add hpe,gxp-fan-ctrl nick.hawkins
2023-01-03 20:36 ` nick.hawkins
2023-01-03 21:35 ` Guenter Roeck
2023-01-03 21:35 ` Guenter Roeck
2023-01-03 20:36 ` [PATCH v4 3/5] ARM: dts: add GXP Support for fans and SPI nick.hawkins
2023-01-03 20:36 ` nick.hawkins
2023-01-03 21:37 ` Guenter Roeck
2023-01-03 21:37 ` Guenter Roeck
2023-01-12 14:24 ` Arnd Bergmann [this message]
2023-01-12 14:24 ` Arnd Bergmann
2023-01-12 15:40 ` Hawkins, Nick
2023-01-12 15:40 ` Hawkins, Nick
2023-01-12 16:00 ` Arnd Bergmann
2023-01-12 16:00 ` Arnd Bergmann
2023-01-12 19:58 ` Hawkins, Nick
2023-01-12 19:58 ` Hawkins, Nick
2023-01-12 21:57 ` Arnd Bergmann
2023-01-12 21:57 ` Arnd Bergmann
2023-01-03 20:36 ` [PATCH v4 4/5] ARM: multi_v7_defconfig: Add GXP Fan and SPI support nick.hawkins
2023-01-03 20:36 ` nick.hawkins
2023-01-03 21:38 ` Guenter Roeck
2023-01-03 21:38 ` Guenter Roeck
2023-01-12 14:29 ` Arnd Bergmann
2023-01-12 14:29 ` Arnd Bergmann
2023-01-03 20:36 ` [PATCH v4 5/5] MAINTAINERS: add gxp fan controller and documents nick.hawkins
2023-01-03 20:36 ` nick.hawkins
2023-01-03 21:36 ` Guenter Roeck
2023-01-03 21:36 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ad677f3-2cbc-4ba0-bd48-2f832a72fb28@app.fastmail.com \
--to=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=nick.hawkins@hpe.com \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.