All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: staging/intel-ipu3: css: Correctly reset some memory
@ 2020-08-22 13:11 ` Christophe JAILLET
  0 siblings, 0 replies; 6+ messages in thread
From: Christophe JAILLET @ 2020-08-22 13:11 UTC (permalink / raw)
  To: sakari.ailus, bingbu.cao, tian.shu.qiu, mchehab, gregkh, yong.zhi
  Cc: linux-media, devel, linux-kernel, kernel-janitors, Christophe JAILLET

The intent here is to reset the whole 'scaler_coeffs_luma' array, not just
the first element.

Fixes: 	e11110a5b744 ("media: staging/intel-ipu3: css: Compute and program ccs")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/staging/media/ipu3/ipu3-css-params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
index fbd53d7c097c..e9d6bd9e9332 100644
--- a/drivers/staging/media/ipu3/ipu3-css-params.c
+++ b/drivers/staging/media/ipu3/ipu3-css-params.c
@@ -159,7 +159,7 @@ imgu_css_scaler_calc(u32 input_width, u32 input_height, u32 target_width,
 
 	memset(&cfg->scaler_coeffs_chroma, 0,
 	       sizeof(cfg->scaler_coeffs_chroma));
-	memset(&cfg->scaler_coeffs_luma, 0, sizeof(*cfg->scaler_coeffs_luma));
+	memset(&cfg->scaler_coeffs_luma, 0, sizeof(cfg->scaler_coeffs_luma));
 	do {
 		phase_step_correction++;
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] media: staging/intel-ipu3: css: Correctly reset some memory
@ 2020-08-22 13:11 ` Christophe JAILLET
  0 siblings, 0 replies; 6+ messages in thread
From: Christophe JAILLET @ 2020-08-22 13:11 UTC (permalink / raw)
  To: sakari.ailus, bingbu.cao, tian.shu.qiu, mchehab, gregkh, yong.zhi
  Cc: devel, Christophe JAILLET, kernel-janitors, linux-kernel, linux-media

The intent here is to reset the whole 'scaler_coeffs_luma' array, not just
the first element.

Fixes: 	e11110a5b744 ("media: staging/intel-ipu3: css: Compute and program ccs")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/staging/media/ipu3/ipu3-css-params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
index fbd53d7c097c..e9d6bd9e9332 100644
--- a/drivers/staging/media/ipu3/ipu3-css-params.c
+++ b/drivers/staging/media/ipu3/ipu3-css-params.c
@@ -159,7 +159,7 @@ imgu_css_scaler_calc(u32 input_width, u32 input_height, u32 target_width,
 
 	memset(&cfg->scaler_coeffs_chroma, 0,
 	       sizeof(cfg->scaler_coeffs_chroma));
-	memset(&cfg->scaler_coeffs_luma, 0, sizeof(*cfg->scaler_coeffs_luma));
+	memset(&cfg->scaler_coeffs_luma, 0, sizeof(cfg->scaler_coeffs_luma));
 	do {
 		phase_step_correction++;
 
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] media: staging/intel-ipu3: css: Correctly reset some memory
@ 2020-08-22 13:11 ` Christophe JAILLET
  0 siblings, 0 replies; 6+ messages in thread
From: Christophe JAILLET @ 2020-08-22 13:11 UTC (permalink / raw)
  To: sakari.ailus, bingbu.cao, tian.shu.qiu, mchehab, gregkh, yong.zhi
  Cc: devel, Christophe JAILLET, kernel-janitors, linux-kernel, linux-media

The intent here is to reset the whole 'scaler_coeffs_luma' array, not just
the first element.

Fixes: 	e11110a5b744 ("media: staging/intel-ipu3: css: Compute and program ccs")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/staging/media/ipu3/ipu3-css-params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
index fbd53d7c097c..e9d6bd9e9332 100644
--- a/drivers/staging/media/ipu3/ipu3-css-params.c
+++ b/drivers/staging/media/ipu3/ipu3-css-params.c
@@ -159,7 +159,7 @@ imgu_css_scaler_calc(u32 input_width, u32 input_height, u32 target_width,
 
 	memset(&cfg->scaler_coeffs_chroma, 0,
 	       sizeof(cfg->scaler_coeffs_chroma));
-	memset(&cfg->scaler_coeffs_luma, 0, sizeof(*cfg->scaler_coeffs_luma));
+	memset(&cfg->scaler_coeffs_luma, 0, sizeof(cfg->scaler_coeffs_luma));
 	do {
 		phase_step_correction++;
 
-- 
2.25.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] media: staging/intel-ipu3: css: Correctly reset some memory
  2020-08-22 13:11 ` Christophe JAILLET
  (?)
@ 2020-08-24  3:26   ` Bingbu Cao
  -1 siblings, 0 replies; 6+ messages in thread
From: Bingbu Cao @ 2020-08-24  3:26 UTC (permalink / raw)
  To: Christophe JAILLET, sakari.ailus, bingbu.cao, tian.shu.qiu,
	mchehab, gregkh, yong.zhi
  Cc: linux-media, devel, linux-kernel, kernel-janitors

Thanks for the patch.

On 8/22/20 9:11 PM, Christophe JAILLET wrote:
> The intent here is to reset the whole 'scaler_coeffs_luma' array, not just
> the first element.
> 
> Fixes: 	e11110a5b744 ("media: staging/intel-ipu3: css: Compute and program ccs")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/staging/media/ipu3/ipu3-css-params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
> index fbd53d7c097c..e9d6bd9e9332 100644
> --- a/drivers/staging/media/ipu3/ipu3-css-params.c
> +++ b/drivers/staging/media/ipu3/ipu3-css-params.c
> @@ -159,7 +159,7 @@ imgu_css_scaler_calc(u32 input_width, u32 input_height, u32 target_width,
>  
>  	memset(&cfg->scaler_coeffs_chroma, 0,
>  	       sizeof(cfg->scaler_coeffs_chroma));
> -	memset(&cfg->scaler_coeffs_luma, 0, sizeof(*cfg->scaler_coeffs_luma));
> +	memset(&cfg->scaler_coeffs_luma, 0, sizeof(cfg->scaler_coeffs_luma));
>  	do {
>  		phase_step_correction++;
>  
> 
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

-- 
Best regards,
Bingbu Cao

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] media: staging/intel-ipu3: css: Correctly reset some memory
@ 2020-08-24  3:26   ` Bingbu Cao
  0 siblings, 0 replies; 6+ messages in thread
From: Bingbu Cao @ 2020-08-24  3:26 UTC (permalink / raw)
  To: Christophe JAILLET, sakari.ailus, bingbu.cao, tian.shu.qiu,
	mchehab, gregkh, yong.zhi
  Cc: devel, kernel-janitors, linux-kernel, linux-media

Thanks for the patch.

On 8/22/20 9:11 PM, Christophe JAILLET wrote:
> The intent here is to reset the whole 'scaler_coeffs_luma' array, not just
> the first element.
> 
> Fixes: 	e11110a5b744 ("media: staging/intel-ipu3: css: Compute and program ccs")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/staging/media/ipu3/ipu3-css-params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
> index fbd53d7c097c..e9d6bd9e9332 100644
> --- a/drivers/staging/media/ipu3/ipu3-css-params.c
> +++ b/drivers/staging/media/ipu3/ipu3-css-params.c
> @@ -159,7 +159,7 @@ imgu_css_scaler_calc(u32 input_width, u32 input_height, u32 target_width,
>  
>  	memset(&cfg->scaler_coeffs_chroma, 0,
>  	       sizeof(cfg->scaler_coeffs_chroma));
> -	memset(&cfg->scaler_coeffs_luma, 0, sizeof(*cfg->scaler_coeffs_luma));
> +	memset(&cfg->scaler_coeffs_luma, 0, sizeof(cfg->scaler_coeffs_luma));
>  	do {
>  		phase_step_correction++;
>  
> 
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

-- 
Best regards,
Bingbu Cao

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] media: staging/intel-ipu3: css: Correctly reset some memory
@ 2020-08-24  3:26   ` Bingbu Cao
  0 siblings, 0 replies; 6+ messages in thread
From: Bingbu Cao @ 2020-08-24  3:26 UTC (permalink / raw)
  To: Christophe JAILLET, sakari.ailus, bingbu.cao, tian.shu.qiu,
	mchehab, gregkh, yong.zhi
  Cc: devel, kernel-janitors, linux-kernel, linux-media

Thanks for the patch.

On 8/22/20 9:11 PM, Christophe JAILLET wrote:
> The intent here is to reset the whole 'scaler_coeffs_luma' array, not just
> the first element.
> 
> Fixes: 	e11110a5b744 ("media: staging/intel-ipu3: css: Compute and program ccs")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/staging/media/ipu3/ipu3-css-params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
> index fbd53d7c097c..e9d6bd9e9332 100644
> --- a/drivers/staging/media/ipu3/ipu3-css-params.c
> +++ b/drivers/staging/media/ipu3/ipu3-css-params.c
> @@ -159,7 +159,7 @@ imgu_css_scaler_calc(u32 input_width, u32 input_height, u32 target_width,
>  
>  	memset(&cfg->scaler_coeffs_chroma, 0,
>  	       sizeof(cfg->scaler_coeffs_chroma));
> -	memset(&cfg->scaler_coeffs_luma, 0, sizeof(*cfg->scaler_coeffs_luma));
> +	memset(&cfg->scaler_coeffs_luma, 0, sizeof(cfg->scaler_coeffs_luma));
>  	do {
>  		phase_step_correction++;
>  
> 
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

-- 
Best regards,
Bingbu Cao
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-24  3:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-22 13:11 [PATCH] media: staging/intel-ipu3: css: Correctly reset some memory Christophe JAILLET
2020-08-22 13:11 ` Christophe JAILLET
2020-08-22 13:11 ` Christophe JAILLET
2020-08-24  3:26 ` Bingbu Cao
2020-08-24  3:26   ` Bingbu Cao
2020-08-24  3:26   ` Bingbu Cao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.