[PATCH] Revert "drm/amdgpu: Set no-retry as default."

[PATCH] Revert "drm/amdgpu: Set no-retry as default."

[Alex Deucher]

This reverts commit 51bfac71cade386966791a8db87a5912781d249f.

This causes stability issues on some raven boards.  Revert
for now until a proper fix is completed.

Bug: https://gitlab.freedesktop.org/drm/amd/issues/934
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=206017
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 0ffc9447b573..3036ec883fb4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -142,7 +142,7 @@ int amdgpu_async_gfx_ring = 1;
 int amdgpu_mcbp = 0;
 int amdgpu_discovery = -1;
 int amdgpu_mes = 0;
-int amdgpu_noretry = 1;
+int amdgpu_noretry;
 int amdgpu_force_asic_type = -1;
 
 struct amdgpu_mgpu_info mgpu_info = {
@@ -588,7 +588,7 @@ MODULE_PARM_DESC(mes,
 module_param_named(mes, amdgpu_mes, int, 0444);
 
 MODULE_PARM_DESC(noretry,
-	"Disable retry faults (0 = retry enabled, 1 = retry disabled (default))");
+	"Disable retry faults (0 = retry enabled (default), 1 = retry disabled)");
 module_param_named(noretry, amdgpu_noretry, int, 0644);
 
 /**
-- 
2.24.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] Revert "drm/amdgpu: Set no-retry as default."

[Felix Kuehling]

On 2020-01-06 3:45 p.m., Alex Deucher wrote:
> This reverts commit 51bfac71cade386966791a8db87a5912781d249f.
>
> This causes stability issues on some raven boards.  Revert
> for now until a proper fix is completed.
>
> Bug: https://gitlab.freedesktop.org/drm/amd/issues/934
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=206017
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 0ffc9447b573..3036ec883fb4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -142,7 +142,7 @@ int amdgpu_async_gfx_ring = 1;
>   int amdgpu_mcbp = 0;
>   int amdgpu_discovery = -1;
>   int amdgpu_mes = 0;
> -int amdgpu_noretry = 1;
> +int amdgpu_noretry;
>   int amdgpu_force_asic_type = -1;
>   
>   struct amdgpu_mgpu_info mgpu_info = {
> @@ -588,7 +588,7 @@ MODULE_PARM_DESC(mes,
>   module_param_named(mes, amdgpu_mes, int, 0444);
>   
>   MODULE_PARM_DESC(noretry,
> -	"Disable retry faults (0 = retry enabled, 1 = retry disabled (default))");
> +	"Disable retry faults (0 = retry enabled (default), 1 = retry disabled)");
>   module_param_named(noretry, amdgpu_noretry, int, 0644);
>   
>   /**
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] Revert "drm/amdgpu: Set no-retry as default."

[Christian König]

Am 06.01.20 um 21:45 schrieb Alex Deucher:
> This reverts commit 51bfac71cade386966791a8db87a5912781d249f.
>
> This causes stability issues on some raven boards.  Revert
> for now until a proper fix is completed.
>
> Bug: https://gitlab.freedesktop.org/drm/amd/issues/934
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=206017
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 0ffc9447b573..3036ec883fb4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -142,7 +142,7 @@ int amdgpu_async_gfx_ring = 1;
>   int amdgpu_mcbp = 0;
>   int amdgpu_discovery = -1;
>   int amdgpu_mes = 0;
> -int amdgpu_noretry = 1;
> +int amdgpu_noretry;
>   int amdgpu_force_asic_type = -1;
>   
>   struct amdgpu_mgpu_info mgpu_info = {
> @@ -588,7 +588,7 @@ MODULE_PARM_DESC(mes,
>   module_param_named(mes, amdgpu_mes, int, 0444);
>   
>   MODULE_PARM_DESC(noretry,
> -	"Disable retry faults (0 = retry enabled, 1 = retry disabled (default))");
> +	"Disable retry faults (0 = retry enabled (default), 1 = retry disabled)");
>   module_param_named(noretry, amdgpu_noretry, int, 0644);
>   
>   /**

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx