[PATCH v2] drm/amdgpu: Fix build error reported for some config

[PATCH v2] drm/amdgpu: Fix build error reported for some config

[Pratik Vishwakarma]

drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: In function ‘amdgpu_acpi_is_s0ix_active’:
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1045:32: error: ‘pm_suspend_target_state’ undeclared (first use in this function)
 1045 |                         return pm_suspend_target_state == PM_SUSPEND_TO_IDLE;
      |                                ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1045:32: note: each undeclared identifier is reported only once for each function it appears in
  CC [M]  drivers/media/usb/dvb-usb/nova-t-usb2.o
  CC [M]  drivers/usb/gadget/legacy/audio.o
  CC [M]  drivers/net/ethernet/intel/igc/igc_tsn.o
  CC [M]  net/mac80211/mlme.o
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1045:59: error: ‘PM_SUSPEND_TO_IDLE’ undeclared (first use in this function)
 1045 |                         return pm_suspend_target_state == PM_SUSPEND_TO_IDLE;
      |                                                           ^~~~~~~~~~~~~~~~~~
  CC [M]  drivers/usb/gadget/function/f_sourcesink.o
make[4]: *** [scripts/Makefile.build:272: drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.o] Error 1
make[3]: *** [scripts/Makefile.build:515: drivers/gpu/drm/amd/amdgpu] Error 2

Fixes: 69e81db337c1 drm/amdgpu: Check pmops for desired suspend state
Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
index 0c281c7f5cea..3d0b67f256f9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
@@ -26,6 +26,7 @@
 #include <linux/slab.h>
 #include <linux/power_supply.h>
 #include <linux/pm_runtime.h>
+#include <linux/suspend.h>
 #include <acpi/video.h>
 #include <acpi/actbl.h>
 
-- 
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH v2] drm/amdgpu: Fix build error reported for some config

[Aurabindo Pillai]

On 2021-07-27 9:45 a.m., Pratik Vishwakarma wrote:
> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: In function ‘amdgpu_acpi_is_s0ix_active’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1045:32: error: ‘pm_suspend_target_state’ undeclared (first use in this function)
>   1045 |                         return pm_suspend_target_state == PM_SUSPEND_TO_IDLE;
>        |                                ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1045:32: note: each undeclared identifier is reported only once for each function it appears in
>    CC [M]  drivers/media/usb/dvb-usb/nova-t-usb2.o
>    CC [M]  drivers/usb/gadget/legacy/audio.o
>    CC [M]  drivers/net/ethernet/intel/igc/igc_tsn.o
>    CC [M]  net/mac80211/mlme.o
> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1045:59: error: ‘PM_SUSPEND_TO_IDLE’ undeclared (first use in this function)
>   1045 |                         return pm_suspend_target_state == PM_SUSPEND_TO_IDLE;
>        |                                                           ^~~~~~~~~~~~~~~~~~
>    CC [M]  drivers/usb/gadget/function/f_sourcesink.o
> make[4]: *** [scripts/Makefile.build:272: drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.o] Error 1
> make[3]: *** [scripts/Makefile.build:515: drivers/gpu/drm/amd/amdgpu] Error 2
> 
> Fixes: 69e81db337c1 drm/amdgpu: Check pmops for desired suspend state
> Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> index 0c281c7f5cea..3d0b67f256f9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> @@ -26,6 +26,7 @@
>   #include <linux/slab.h>
>   #include <linux/power_supply.h>
>   #include <linux/pm_runtime.h>
> +#include <linux/suspend.h>
>   #include <acpi/video.h>
>   #include <acpi/actbl.h>
>   
> 

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx