From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Anthony Perard <anthony.perard@citrix.com>,
Cameron Esfahani <dirty@apple.com>,
Claudio Fontana <cfontana@suse.de>, Colin Xu <colin.xu@intel.com>,
Eduardo Habkost <ehabkost@redhat.com>,
haxm-team@intel.com, Kamil Rytarowski <kamil@netbsd.org>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Paul Durrant <paul@xen.org>,
Reinoud Zandijk <reinoud@netbsd.org>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Thomas Huth <thuth@redhat.com>,
Wenchao Wang <wenchao.wang@intel.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 30/30] accel: Add missing AccelOpsClass::has_work() and drop SysemuCPUOps one
Date: Fri, 3 Sep 2021 22:48:28 +0200 [thread overview]
Message-ID: <5b1a24c2-cdd6-ec88-d0d8-540bf5f96c38@linaro.org> (raw)
In-Reply-To: <20210903181943.763360-1-f4bug@amsat.org>
On 9/3/21 8:19 PM, Philippe Mathieu-Daudé wrote:
> cpu_common_has_work() is the default has_work() implementation
> and returns 'false'.
>
> Explicit it for the QTest / HAX / HVF / NVMM / Xen accelerators
> and remove cpu_common_has_work().
>
> Since there are no more implementations of SysemuCPUOps::has_work,
> remove it along with the assertion in cpu_has_work().
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> include/hw/core/cpu.h | 2 --
> accel/hvf/hvf-accel-ops.c | 6 ++++++
> accel/qtest/qtest.c | 6 ++++++
> accel/xen/xen-all.c | 6 ++++++
> hw/core/cpu-common.c | 6 ------
> softmmu/cpus.c | 9 ++-------
> target/i386/hax/hax-accel-ops.c | 6 ++++++
> target/i386/nvmm/nvmm-accel-ops.c | 6 ++++++
> 8 files changed, 32 insertions(+), 15 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Paul Durrant <paul@xen.org>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Cameron Esfahani <dirty@apple.com>,
Kamil Rytarowski <kamil@netbsd.org>,
Wenchao Wang <wenchao.wang@intel.com>,
haxm-team@intel.com, Claudio Fontana <cfontana@suse.de>,
xen-devel@lists.xenproject.org,
Anthony Perard <anthony.perard@citrix.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Reinoud Zandijk <reinoud@netbsd.org>,
Colin Xu <colin.xu@intel.com>
Subject: Re: [PATCH v3 30/30] accel: Add missing AccelOpsClass::has_work() and drop SysemuCPUOps one
Date: Fri, 3 Sep 2021 22:48:28 +0200 [thread overview]
Message-ID: <5b1a24c2-cdd6-ec88-d0d8-540bf5f96c38@linaro.org> (raw)
In-Reply-To: <20210903181943.763360-1-f4bug@amsat.org>
On 9/3/21 8:19 PM, Philippe Mathieu-Daudé wrote:
> cpu_common_has_work() is the default has_work() implementation
> and returns 'false'.
>
> Explicit it for the QTest / HAX / HVF / NVMM / Xen accelerators
> and remove cpu_common_has_work().
>
> Since there are no more implementations of SysemuCPUOps::has_work,
> remove it along with the assertion in cpu_has_work().
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> include/hw/core/cpu.h | 2 --
> accel/hvf/hvf-accel-ops.c | 6 ++++++
> accel/qtest/qtest.c | 6 ++++++
> accel/xen/xen-all.c | 6 ++++++
> hw/core/cpu-common.c | 6 ------
> softmmu/cpus.c | 9 ++-------
> target/i386/hax/hax-accel-ops.c | 6 ++++++
> target/i386/nvmm/nvmm-accel-ops.c | 6 ++++++
> 8 files changed, 32 insertions(+), 15 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-09-03 20:48 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 16:15 [PATCH v3 00/30] accel: Move has_work() from SysemuCPUOps to AccelOpsClass Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-02 16:15 ` [PATCH v3 01/30] accel/tcg: Restrict cpu_handle_halt() to sysemu Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 19:31 ` Richard Henderson
2021-09-03 19:31 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 02/30] hw/core: Restrict cpu_has_work() " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:11 ` Richard Henderson
2021-09-03 20:11 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 03/30] hw/core: Un-inline cpu_has_work() Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:11 ` Richard Henderson
2021-09-03 20:11 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 04/30] sysemu: Introduce AccelOpsClass::has_work() Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:14 ` Richard Henderson
2021-09-03 20:14 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 05/30] accel/kvm: Implement AccelOpsClass::has_work() Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:15 ` Richard Henderson
2021-09-03 20:15 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 06/30] accel/whpx: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:16 ` Richard Henderson
2021-09-03 20:16 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 07/30] accel/tcg: Implement AccelOpsClass::has_work() as stub Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:17 ` Richard Henderson
2021-09-03 20:17 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 08/30] target/alpha: Restrict has_work() handler to sysemu and TCG Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:18 ` Richard Henderson
2021-09-03 20:18 ` Richard Henderson
2021-09-03 20:34 ` Philippe Mathieu-Daudé
2021-09-03 20:34 ` Philippe Mathieu-Daudé
2021-09-03 20:38 ` Richard Henderson
2021-09-03 20:38 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 09/30] target/arm: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:19 ` Richard Henderson
2021-09-03 20:19 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 10/30] target/avr: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:20 ` Richard Henderson
2021-09-03 20:20 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 11/30] target/cris: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:21 ` Richard Henderson
2021-09-03 20:21 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 12/30] target/hexagon: Remove unused has_work() handler Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:21 ` Richard Henderson
2021-09-03 20:21 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 13/30] target/hppa: Restrict has_work() handler to sysemu and TCG Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:22 ` Richard Henderson
2021-09-03 20:22 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 14/30] target/i386: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:23 ` Richard Henderson
2021-09-03 20:23 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 15/30] target/m68k: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:24 ` Richard Henderson
2021-09-03 20:24 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 16/30] target/microblaze: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:25 ` Richard Henderson
2021-09-03 20:25 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 17/30] target/mips: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:26 ` Richard Henderson
2021-09-03 20:26 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 18/30] target/nios2: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:31 ` Richard Henderson
2021-09-03 20:31 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 19/30] target/openrisc: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:31 ` Richard Henderson
2021-09-03 20:31 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 20/30] target/ppc: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 0:49 ` David Gibson
2021-09-03 0:49 ` David Gibson
2021-09-03 20:43 ` Richard Henderson
2021-09-03 20:43 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 21/30] target/ppc: Introduce PowerPCCPUClass::has_work() Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 0:50 ` David Gibson
2021-09-03 0:50 ` David Gibson
2021-09-03 20:38 ` Philippe Mathieu-Daudé
2021-09-03 20:38 ` Philippe Mathieu-Daudé
2021-09-03 20:42 ` Richard Henderson
2021-09-03 20:42 ` Richard Henderson
2021-09-03 21:11 ` Philippe Mathieu-Daudé
2021-09-03 21:11 ` Philippe Mathieu-Daudé
2021-09-11 22:31 ` Philippe Mathieu-Daudé
2021-09-11 22:31 ` Philippe Mathieu-Daudé
2021-09-12 12:31 ` Richard Henderson
2021-09-12 12:31 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 22/30] target/ppc: Simplify has_work() handlers Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:43 ` Richard Henderson
2021-09-03 20:43 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 23/30] target/riscv: Restrict has_work() handler to sysemu and TCG Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:43 ` Richard Henderson
2021-09-03 20:43 ` Richard Henderson
2021-09-02 16:15 ` [PATCH v3 24/30] target/rx: " Philippe Mathieu-Daudé
2021-09-02 16:15 ` Philippe Mathieu-Daudé
2021-09-03 20:44 ` Richard Henderson
2021-09-03 20:44 ` Richard Henderson
2021-09-03 17:55 ` [PATCH v3 25/30] target/s390x: " Philippe Mathieu-Daudé
2021-09-03 20:44 ` Richard Henderson
2021-09-03 18:13 ` [PATCH v3 26/30] target/sh4: " Philippe Mathieu-Daudé
2021-09-03 20:45 ` Richard Henderson
2021-09-03 18:14 ` [PATCH v3 27/30] target/sparc: " Philippe Mathieu-Daudé
2021-09-03 20:46 ` Richard Henderson
2021-09-03 18:14 ` [PATCH v3 28/30] target/tricore: " Philippe Mathieu-Daudé
2021-09-03 20:46 ` Richard Henderson
2021-09-03 18:15 ` [PATCH v3 29/30] target/xtensa: " Philippe Mathieu-Daudé
2021-09-03 20:47 ` Richard Henderson
2021-09-03 18:19 ` [PATCH v3 30/30] accel: Add missing AccelOpsClass::has_work() and drop SysemuCPUOps one Philippe Mathieu-Daudé
2021-09-03 18:19 ` Philippe Mathieu-Daudé
2021-09-03 20:48 ` Richard Henderson [this message]
2021-09-03 20:48 ` Richard Henderson
2021-09-06 6:48 ` Paul Durrant
2021-09-06 6:48 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b1a24c2-cdd6-ec88-d0d8-540bf5f96c38@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=cfontana@suse.de \
--cc=colin.xu@intel.com \
--cc=dirty@apple.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=haxm-team@intel.com \
--cc=kamil@netbsd.org \
--cc=lvivier@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=reinoud@netbsd.org \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
--cc=wenchao.wang@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.