All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config
@ 2020-09-03 14:17 Enric Balletbo i Serra
  2020-09-03 15:02 ` Guenter Roeck
  2020-09-07 13:25 ` Enric Balletbo i Serra
  0 siblings, 2 replies; 4+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-03 14:17 UTC (permalink / raw)
  To: linux-kernel; +Cc: Collabora Kernel ML, groeck, bleung, dtor, gwendal

The MFD_CROS_EC config was a transitional Kconfig option to not break
current defconfigs in the kernel. Now, this is not required anymore
because all the defconfigs have been removed this option and migrated to
enable the CrOS EC parts individually.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

 drivers/platform/chrome/Kconfig | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index a056031dee81..ccc23d8686e8 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -3,16 +3,6 @@
 # Platform support for Chrome OS hardware (Chromebooks and Chromeboxes)
 #
 
-config MFD_CROS_EC
-	tristate "Platform support for Chrome hardware (transitional)"
-	select CHROME_PLATFORMS
-	select CROS_EC
-	select MFD_CROS_EC_DEV
-	depends on X86 || ARM || ARM64 || COMPILE_TEST
-	help
-	  This is a transitional Kconfig option and will be removed after
-	  everyone enables the parts individually.
-
 menuconfig CHROME_PLATFORMS
 	bool "Platform support for Chrome hardware"
 	depends on X86 || ARM || ARM64 || COMPILE_TEST
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config
  2020-09-03 14:17 [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config Enric Balletbo i Serra
@ 2020-09-03 15:02 ` Guenter Roeck
  2020-09-03 20:39   ` Gwendal Grignou
  2020-09-07 13:25 ` Enric Balletbo i Serra
  1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2020-09-03 15:02 UTC (permalink / raw)
  To: Enric Balletbo i Serra
  Cc: linux-kernel, Collabora Kernel ML, Guenter Roeck, Benson Leung,
	Dmitry Torokhov, Gwendal Grignou

On Thu, Sep 3, 2020 at 7:17 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> The MFD_CROS_EC config was a transitional Kconfig option to not break
> current defconfigs in the kernel. Now, this is not required anymore
> because all the defconfigs have been removed this option and migrated to
> enable the CrOS EC parts individually.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
>
>  drivers/platform/chrome/Kconfig | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index a056031dee81..ccc23d8686e8 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -3,16 +3,6 @@
>  # Platform support for Chrome OS hardware (Chromebooks and Chromeboxes)
>  #
>
> -config MFD_CROS_EC
> -       tristate "Platform support for Chrome hardware (transitional)"
> -       select CHROME_PLATFORMS
> -       select CROS_EC
> -       select MFD_CROS_EC_DEV
> -       depends on X86 || ARM || ARM64 || COMPILE_TEST
> -       help
> -         This is a transitional Kconfig option and will be removed after
> -         everyone enables the parts individually.
> -
>  menuconfig CHROME_PLATFORMS
>         bool "Platform support for Chrome hardware"
>         depends on X86 || ARM || ARM64 || COMPILE_TEST
> --
> 2.28.0
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config
  2020-09-03 15:02 ` Guenter Roeck
@ 2020-09-03 20:39   ` Gwendal Grignou
  0 siblings, 0 replies; 4+ messages in thread
From: Gwendal Grignou @ 2020-09-03 20:39 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Enric Balletbo i Serra, linux-kernel, Collabora Kernel ML,
	Guenter Roeck, Benson Leung, Dmitry Torokhov

On Thu, Sep 3, 2020 at 8:02 AM Guenter Roeck <groeck@google.com> wrote:
>
> On Thu, Sep 3, 2020 at 7:17 AM Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
> >
> > The MFD_CROS_EC config was a transitional Kconfig option to not break
> > current defconfigs in the kernel. Now, this is not required anymore
> > because all the defconfigs have been removed this option and migrated to
> > enable the CrOS EC parts individually.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
>
> > ---
> >
> >  drivers/platform/chrome/Kconfig | 10 ----------
> >  1 file changed, 10 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> > index a056031dee81..ccc23d8686e8 100644
> > --- a/drivers/platform/chrome/Kconfig
> > +++ b/drivers/platform/chrome/Kconfig
> > @@ -3,16 +3,6 @@
> >  # Platform support for Chrome OS hardware (Chromebooks and Chromeboxes)
> >  #
> >
> > -config MFD_CROS_EC
> > -       tristate "Platform support for Chrome hardware (transitional)"
> > -       select CHROME_PLATFORMS
> > -       select CROS_EC
> > -       select MFD_CROS_EC_DEV
> > -       depends on X86 || ARM || ARM64 || COMPILE_TEST
> > -       help
> > -         This is a transitional Kconfig option and will be removed after
> > -         everyone enables the parts individually.
> > -
> >  menuconfig CHROME_PLATFORMS
> >         bool "Platform support for Chrome hardware"
> >         depends on X86 || ARM || ARM64 || COMPILE_TEST
> > --
> > 2.28.0
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config
  2020-09-03 14:17 [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config Enric Balletbo i Serra
  2020-09-03 15:02 ` Guenter Roeck
@ 2020-09-07 13:25 ` Enric Balletbo i Serra
  1 sibling, 0 replies; 4+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-07 13:25 UTC (permalink / raw)
  To: linux-kernel; +Cc: Collabora Kernel ML, groeck, bleung, dtor, gwendal

Hi Gwendal and Guenter,

Thank you for the review and tested tags.

On 3/9/20 16:17, Enric Balletbo i Serra wrote:
> The MFD_CROS_EC config was a transitional Kconfig option to not break
> current defconfigs in the kernel. Now, this is not required anymore
> because all the defconfigs have been removed this option and migrated to
> enable the CrOS EC parts individually.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Applied for 5.10

Thanks,
 Enric

> ---
> 
>  drivers/platform/chrome/Kconfig | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index a056031dee81..ccc23d8686e8 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -3,16 +3,6 @@
>  # Platform support for Chrome OS hardware (Chromebooks and Chromeboxes)
>  #
>  
> -config MFD_CROS_EC
> -	tristate "Platform support for Chrome hardware (transitional)"
> -	select CHROME_PLATFORMS
> -	select CROS_EC
> -	select MFD_CROS_EC_DEV
> -	depends on X86 || ARM || ARM64 || COMPILE_TEST
> -	help
> -	  This is a transitional Kconfig option and will be removed after
> -	  everyone enables the parts individually.
> -
>  menuconfig CHROME_PLATFORMS
>  	bool "Platform support for Chrome hardware"
>  	depends on X86 || ARM || ARM64 || COMPILE_TEST
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-07 13:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 14:17 [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config Enric Balletbo i Serra
2020-09-03 15:02 ` Guenter Roeck
2020-09-03 20:39   ` Gwendal Grignou
2020-09-07 13:25 ` Enric Balletbo i Serra

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.