* [PATCH 0/2] staging: rtl8723bs: hal: Correct multi-line comments and typos in them
@ 2020-03-20 7:12 R Veera Kumar
2020-03-20 7:12 ` [PATCH 1/2] staging: rtl8723bs: hal: Correct multi-line comments as per coding style R Veera Kumar
2020-03-20 7:13 ` [PATCH 2/2] staging: rtl8723bs: hal: Correct typos in comments R Veera Kumar
0 siblings, 2 replies; 3+ messages in thread
From: R Veera Kumar @ 2020-03-20 7:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: R Veera Kumar, outreachy-kernel
Patch 1:
Correct multi-line comments as per coding style to respect
80 characters per line limit.
Amalgamate individual lines into single multi-line comment.
Reorganize it for readability.
Patch 2:
Correct typos in comments fixed in patch 1 as well as new
ones.
Please apply the patch in series.
---
R Veera Kumar (2):
staging: rtl8723bs: hal: Correct multi-line comments as per coding
style
staging: rtl8723bs: hal: Correct typos in comments
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 14 ++---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 58 +++++++++++---------
2 files changed, 40 insertions(+), 32 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] staging: rtl8723bs: hal: Correct multi-line comments as per coding style
2020-03-20 7:12 [PATCH 0/2] staging: rtl8723bs: hal: Correct multi-line comments and typos in them R Veera Kumar
@ 2020-03-20 7:12 ` R Veera Kumar
2020-03-20 7:13 ` [PATCH 2/2] staging: rtl8723bs: hal: Correct typos in comments R Veera Kumar
1 sibling, 0 replies; 3+ messages in thread
From: R Veera Kumar @ 2020-03-20 7:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: R Veera Kumar, outreachy-kernel
Correct multi-line comments as per coding style to respect
80 characters per line limit.
Amalgamate individual lines into single multiline comment.
Reorganize it for readability.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 56 +++++++++++---------
1 file changed, 32 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
index a69e8ae16565..11ddab1dce3b 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
@@ -823,8 +823,11 @@ static void ConstructProbeRsp(struct adapter *padapter, u8 *pframe, u32 *pLength
}
#endif /* CONFIG_AP_WOWLAN */
-/* To check if reserved page content is destroyed by beacon beacuse beacon is too large. */
-/* 2010.06.23. Added by tynli. */
+/*
+ * To check if reserved page content is destroyed by beacon beacuse beacon
+ * is too large.
+ */
+/* 2010.06.23. Added by tynli. */
void CheckFwRsvdPageContent(struct adapter *Adapter)
{
}
@@ -1409,16 +1412,20 @@ void rtl8723b_set_ap_wowlan_cmd(struct adapter *padapter, u8 enable)
}
#endif /* CONFIG_AP_WOWLAN */
-/* */
-/* Description: Fill the reserved packets that FW will use to RSVD page. */
-/* Now we just send 4 types packet to rsvd page. */
-/* (1)Beacon, (2)Ps-poll, (3)Null data, (4)ProbeRsp. */
-/* Input: */
-/* bDLFinished - false: At the first time we will send all the packets as a large packet to Hw, */
-/* so we need to set the packet length to total lengh. */
-/* true: At the second time, we should send the first packet (default:beacon) */
-/* to Hw again and set the lengh in descriptor to the real beacon lengh. */
-/* 2009.10.15 by tynli. */
+/*
+ * Description: Fill the reserved packets that FW will use to RSVD page.
+ * Now we just send 4 types packet to rsvd page.
+ * (1)Beacon, (2)Ps-poll, (3)Null data, (4)ProbeRsp.
+ *
+ * Input:
+ *
+ * bDLFinished - false: At the first time we will send all the packets as
+ * a large packet to Hw, so we need to set the packet length to total lengh.
+ *
+ * true: At the second time, we should send the first packet (default:beacon)
+ * to Hw again and set the lengh in descriptor to the real beacon lengh.
+ */
+/* 2009.10.15 by tynli. */
static void rtl8723b_set_FwRsvdPagePkt(
struct adapter *padapter, bool bDLFinished
)
@@ -1791,18 +1798,19 @@ static void rtl8723b_set_FwRsvdPagePkt(
}
#ifdef CONFIG_AP_WOWLAN
-/* */
-/* Description: Fill the reserved packets that FW will use to RSVD page. */
-/* Now we just send 2 types packet to rsvd page. (1)Beacon, (2)ProbeRsp. */
-/* */
-/* Input: bDLFinished */
-/* */
-/* false: At the first time we will send all the packets as a large packet to Hw, */
-/* so we need to set the packet length to total lengh. */
-/* */
-/* true: At the second time, we should send the first packet (default:beacon) */
-/* to Hw again and set the lengh in descriptor to the real beacon lengh. */
-/* 2009.10.15 by tynli. */
+/*
+ * Description: Fill the reserved packets that FW will use to RSVD page.
+ * Now we just send 2 types packet to rsvd page. (1)Beacon, (2)ProbeRsp.
+ *
+ * Input: bDLFinished
+ *
+ * false: At the first time we will send all the packets as a large packet to
+ * Hw, so we need to set the packet length to total lengh.
+ *
+ * true: At the second time, we should send the first packet (default:beacon)
+ * to Hw again and set the lengh in descriptor to the real beacon lengh.
+ */
+/* 2009.10.15 by tynli. */
static void rtl8723b_set_AP_FwRsvdPagePkt(
struct adapter *padapter, bool bDLFinished
)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] staging: rtl8723bs: hal: Correct typos in comments
2020-03-20 7:12 [PATCH 0/2] staging: rtl8723bs: hal: Correct multi-line comments and typos in them R Veera Kumar
2020-03-20 7:12 ` [PATCH 1/2] staging: rtl8723bs: hal: Correct multi-line comments as per coding style R Veera Kumar
@ 2020-03-20 7:13 ` R Veera Kumar
1 sibling, 0 replies; 3+ messages in thread
From: R Veera Kumar @ 2020-03-20 7:13 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: R Veera Kumar, outreachy-kernel
Correct typos in comments.
Misspellings found using checkpatch.pl.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 14 +++++++-------
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 12 ++++++------
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h b/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
index ce02457922b7..b9aca99478db 100644
--- a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
+++ b/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
@@ -415,13 +415,13 @@
#define IMR_BCNDMAINT3_8723B BIT23 /* Beacon DMA Interrupt 3 */
#define IMR_BCNDMAINT2_8723B BIT22 /* Beacon DMA Interrupt 2 */
#define IMR_BCNDMAINT1_8723B BIT21 /* Beacon DMA Interrupt 1 */
-#define IMR_BCNDOK7_8723B BIT20 /* Beacon Queue DMA OK Interrup 7 */
-#define IMR_BCNDOK6_8723B BIT19 /* Beacon Queue DMA OK Interrup 6 */
-#define IMR_BCNDOK5_8723B BIT18 /* Beacon Queue DMA OK Interrup 5 */
-#define IMR_BCNDOK4_8723B BIT17 /* Beacon Queue DMA OK Interrup 4 */
-#define IMR_BCNDOK3_8723B BIT16 /* Beacon Queue DMA OK Interrup 3 */
-#define IMR_BCNDOK2_8723B BIT15 /* Beacon Queue DMA OK Interrup 2 */
-#define IMR_BCNDOK1_8723B BIT14 /* Beacon Queue DMA OK Interrup 1 */
+#define IMR_BCNDOK7_8723B BIT20 /* Beacon Queue DMA OK Interrupt 7 */
+#define IMR_BCNDOK6_8723B BIT19 /* Beacon Queue DMA OK Interrupt 6 */
+#define IMR_BCNDOK5_8723B BIT18 /* Beacon Queue DMA OK Interrupt 5 */
+#define IMR_BCNDOK4_8723B BIT17 /* Beacon Queue DMA OK Interrupt 4 */
+#define IMR_BCNDOK3_8723B BIT16 /* Beacon Queue DMA OK Interrupt 3 */
+#define IMR_BCNDOK2_8723B BIT15 /* Beacon Queue DMA OK Interrupt 2 */
+#define IMR_BCNDOK1_8723B BIT14 /* Beacon Queue DMA OK Interrupt 1 */
#define IMR_ATIMEND_E_8723B BIT13 /* ATIM Window End Extension for Win7 */
#define IMR_TXERR_8723B BIT11 /* Tx Error Flag Interrupt Status, write 1 clear. */
#define IMR_RXERR_8723B BIT10 /* Rx Error Flag INT Status, Write 1 clear */
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
index 11ddab1dce3b..fd2b74003faf 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
@@ -824,7 +824,7 @@ static void ConstructProbeRsp(struct adapter *padapter, u8 *pframe, u32 *pLength
#endif /* CONFIG_AP_WOWLAN */
/*
- * To check if reserved page content is destroyed by beacon beacuse beacon
+ * To check if reserved page content is destroyed by beacon because beacon
* is too large.
*/
/* 2010.06.23. Added by tynli. */
@@ -1420,10 +1420,10 @@ void rtl8723b_set_ap_wowlan_cmd(struct adapter *padapter, u8 enable)
* Input:
*
* bDLFinished - false: At the first time we will send all the packets as
- * a large packet to Hw, so we need to set the packet length to total lengh.
+ * a large packet to Hw, so we need to set the packet length to total length.
*
* true: At the second time, we should send the first packet (default:beacon)
- * to Hw again and set the lengh in descriptor to the real beacon lengh.
+ * to Hw again and set the length in descriptor to the real beacon length.
*/
/* 2009.10.15 by tynli. */
static void rtl8723b_set_FwRsvdPagePkt(
@@ -1606,7 +1606,7 @@ static void rtl8723b_set_FwRsvdPagePkt(
#ifdef CONFIG_GTK_OL
BufIndex += (CurtPktPageNum*PageSize);
- /* if the ap staion info. exists, get the kek, kck from staion info. */
+ /* if the ap station info. exists, get the kek, kck from station info. */
psta = rtw_get_stainfo(pstapriv, get_bssid(pmlmepriv));
if (!psta) {
memset(kek, 0, RTW_KEK_LEN);
@@ -1805,10 +1805,10 @@ static void rtl8723b_set_FwRsvdPagePkt(
* Input: bDLFinished
*
* false: At the first time we will send all the packets as a large packet to
- * Hw, so we need to set the packet length to total lengh.
+ * Hw, so we need to set the packet length to total length.
*
* true: At the second time, we should send the first packet (default:beacon)
- * to Hw again and set the lengh in descriptor to the real beacon lengh.
+ * to Hw again and set the length in descriptor to the real beacon length.
*/
/* 2009.10.15 by tynli. */
static void rtl8723b_set_AP_FwRsvdPagePkt(
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-20 7:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 7:12 [PATCH 0/2] staging: rtl8723bs: hal: Correct multi-line comments and typos in them R Veera Kumar
2020-03-20 7:12 ` [PATCH 1/2] staging: rtl8723bs: hal: Correct multi-line comments as per coding style R Veera Kumar
2020-03-20 7:13 ` [PATCH 2/2] staging: rtl8723bs: hal: Correct typos in comments R Veera Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.