Re: r600/nir: enable soft-fp64 for evengreen class hardware - brake compilation of Mesa git

Re: r600/nir: enable soft-fp64 for evengreen class hardware - brake compilation of Mesa git

[Dieter Nützel]

Hello Gert,

new year, new luck,...;-)

mkdir build
cd build
meson ../ --strip --buildtype release -Ddri-drivers= -Dplatforms=x11 
-Dgallium-drivers=r600,radeonsi,swrast -Dvulkan-drivers=amd 
-Dgallium-nine=true -Dopencl-spirv=true -Dgallium-opencl=standalone 
-Dglvnd=true -Dgallium-va=enabled -Dgallium-xvmc=disabled 
-Dgallium-omx=disabled -Dgallium-xa=disabled


[1067/1508] Compiling C object 
src/gallium/auxiliary/libgallium.a.p/gallivm_lp_bld_format_s3tc.c.o
../src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c: In function 
‘lp_build_fetch_rgtc_rgba_aos’:
../src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c:2649:17: warning: 
‘green_hi’ may be used uninitialized in this function 
[-Wmaybe-uninitialized]
  2649 |          rgba = latc2_to_rgba_aos(gallivm, n, 
format_desc->format,
       |                 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  2650 |                                   red_lo, red_hi, green_lo, 
green_hi, i, j);
       |                                   
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c:2649:17: warning: 
‘green_lo’ may be used uninitialized in this function 
[-Wmaybe-uninitialized]
[1089/1508] Compiling C object 
src/gallium/auxiliary/libgallium.a.p/gallivm_lp_bld_nir.c.o
In file included from ../src/gallium/auxiliary/gallivm/lp_bld_nir.c:26:
../src/gallium/auxiliary/gallivm/lp_bld_nir.c: In function 
‘visit_cf_list.isra’:
../src/gallium/auxiliary/gallivm/lp_bld_nir.h:263:27: warning: ‘result’ 
may be used uninitialized in this function [-Wmaybe-uninitialized]
   263 |    LLVMTypeRef arr_type = LLVMArrayType(LLVMTypeOf(values[0]), 
value_count);
       |                           
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/gallium/auxiliary/gallivm/lp_bld_nir.c:175:4: warning: ‘undef’ 
may be used uninitialized in this function [-Wmaybe-uninitialized]
   175 |    assign_ssa(bld_base, ssa->index, ssa->num_components == 1 ? 
vals[0] : 
lp_nir_array_build_gather_values(bld_base->base.gallivm->builder, vals, 
ssa->num_components));
       |    
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[1254/1508] Compiling C++ object 
src/gallium/drivers/r600/libr600.a.p/sb_sb_sched.cpp.o
../src/gallium/drivers/r600/sb/sb_sched.cpp: In member function ‘void 
r600_sb::literal_tracker::reset()’:
../src/gallium/drivers/r600/sb/sb_sched.cpp:1953:26: warning: ‘void* 
memset(void*, int, size_t)’ clearing an object of non-trivial type 
‘struct r600_sb::literal’; use assignment or value-initialization 
instead [-Wclass-memaccess]
  1953 |  memset(lt, 0, sizeof(lt));
       |                          ^
In file included from ../src/gallium/drivers/r600/sb/sb_sched.cpp:35:
../src/gallium/drivers/r600/sb/sb_bc.h:409:8: note: ‘struct 
r600_sb::literal’ declared here
   409 | struct literal {
       |        ^~~~~~~
[1260/1508] Compiling C object 
src/gallium/drivers/r600/libr600.a.p/r600_state_common.c.o
../src/gallium/drivers/r600/r600_state_common.c: In function 
‘r600_create_shader_state’:
../src/gallium/drivers/r600/r600_state_common.c:960:39: warning: ‘sel’ 
may be used uninitialized in this function [-Wmaybe-uninitialized]
   960 |   sel->lds_patch_outputs_written_mask = 0;
       |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
../src/gallium/drivers/r600/r600_state_common.c: In function 
‘r600_create_tes_state’:
../src/gallium/drivers/r600/r600_state_common.c:947:10: warning: ‘sel’ 
may be used uninitialized in this function [-Wmaybe-uninitialized]
   947 |  sel->so = state->stream_output;
       |  ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
../src/gallium/drivers/r600/r600_state_common.c:937:36: note: ‘sel’ was 
declared here
   937 |  struct r600_pipe_shader_selector *sel;
       |                                    ^~~
../src/gallium/drivers/r600/r600_state_common.c: In function 
‘r600_create_ps_state’:
../src/gallium/drivers/r600/r600_state_common.c:947:10: warning: ‘sel’ 
may be used uninitialized in this function [-Wmaybe-uninitialized]
   947 |  sel->so = state->stream_output;
       |  ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
../src/gallium/drivers/r600/r600_state_common.c:937:36: note: ‘sel’ was 
declared here
   937 |  struct r600_pipe_shader_selector *sel;
       |                                    ^~~
../src/gallium/drivers/r600/r600_state_common.c: In function 
‘r600_create_gs_state’:
../src/gallium/drivers/r600/r600_state_common.c:951:23: warning: ‘sel’ 
may be used uninitialized in this function [-Wmaybe-uninitialized]
   951 |   sel->gs_output_prim =
       |   ~~~~~~~~~~~~~~~~~~~~^
   952 |    sel->info.properties[TGSI_PROPERTY_GS_OUTPUT_PRIM];
       |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/gallium/drivers/r600/r600_state_common.c:937:36: note: ‘sel’ was 
declared here
   937 |  struct r600_pipe_shader_selector *sel;
       |                                    ^~~
[1318/1508] Compiling C++ object 
src/gallium/drivers/r600/libr600.a.p/sfn_sfn_nir_lower_64bit.cpp.o
FAILED: 
src/gallium/drivers/r600/libr600.a.p/sfn_sfn_nir_lower_64bit.cpp.o
ccache c++ -Isrc/gallium/drivers/r600/libr600.a.p 
-Isrc/gallium/drivers/r600 -I../src/gallium/drivers/r600 -Isrc -I../src 
-Isrc/mapi -I../src/mapi -Isrc/mesa -I../src/mesa -Iinclude -I../include 
-Isrc/compiler -I../src/compiler -I../src/gallium/include 
-Isrc/gallium/auxiliary -I../src/gallium/auxiliary -Isrc/amd/common 
-I../src/amd/common -Isrc/gallium/drivers -I../src/gallium/drivers 
-Isrc/compiler/nir -I../src/compiler/nir -Isrc/util -I../src/util 
-I/usr/include/libdrm -fvisibility=hidden -fdiagnostics-color=always 
-DNDEBUG -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch 
-Wnon-virtual-dtor -std=c++14 -O3 -ffunction-sections -fdata-sections 
'-DPACKAGE_VERSION="21.0.0-devel"' 
'-DPACKAGE_BUGREPORT="https://gitlab.freedesktop.org/mesa/mesa/-/issues"' 
-DUSE_ELF_TLS -DHAVE_ST_VDPAU -DENABLE_ST_OMX_BELLAGIO=0 
-DENABLE_ST_OMX_TIZONIA=0 -DHAVE_X11_PLATFORM -DHAVE_XCB_PLATFORM 
-DGLX_INDIRECT_RENDERING -DGLX_DIRECT_RENDERING -DGLX_USE_DRM 
-DHAVE_DRM_PLATFORM -DENABLE_SHADER_CACHE -DHAVE___BUILTIN_BSWAP32 
-DHAVE___BUILTIN_BSWAP64 -DHAVE___BUILTIN_CLZ -DHAVE___BUILTIN_CLZLL 
-DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_EXPECT -DHAVE___BUILTIN_FFS 
-DHAVE___BUILTIN_FFSLL -DHAVE___BUILTIN_POPCOUNT 
-DHAVE___BUILTIN_POPCOUNTLL -DHAVE___BUILTIN_UNREACHABLE 
-DHAVE___BUILTIN_TYPES_COMPATIBLE_P -DHAVE_FUNC_ATTRIBUTE_CONST 
-DHAVE_FUNC_ATTRIBUTE_FLATTEN -DHAVE_FUNC_ATTRIBUTE_MALLOC 
-DHAVE_FUNC_ATTRIBUTE_PURE -DHAVE_FUNC_ATTRIBUTE_UNUSED 
-DHAVE_FUNC_ATTRIBUTE_WARN_UNUSED_RESULT -DHAVE_FUNC_ATTRIBUTE_WEAK 
-DHAVE_FUNC_ATTRIBUTE_FORMAT -DHAVE_FUNC_ATTRIBUTE_PACKED 
-DHAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL -DHAVE_FUNC_ATTRIBUTE_ALIAS 
-DHAVE_FUNC_ATTRIBUTE_NORETURN -DHAVE_FUNC_ATTRIBUTE_VISIBILITY 
-DHAVE_UINT128 -DUSE_SSE41 -DUSE_GCC_ATOMIC_BUILTINS -DUSE_X86_64_ASM 
-DMAJOR_IN_SYSMACROS -DHAVE_LINUX_FUTEX_H -DHAVE_ENDIAN_H -DHAVE_DLFCN_H 
-DHAVE_EXECINFO_H -DHAVE_SYS_SHM_H -DHAVE_CET_H -DHAVE_STRTOF 
-DHAVE_MKOSTEMP -DHAVE_TIMESPEC_GET -DHAVE_MEMFD_CREATE -DHAVE_RANDOM_R 
-DHAVE_FLOCK -DHAVE_STRTOK_R -DHAVE_GETRANDOM 
-DHAVE_PROGRAM_INVOCATION_NAME -DHAVE_POSIX_MEMALIGN 
-DHAVE_DIRENT_D_TYPE -DHAVE_STRTOD_L -DHAVE_DLADDR 
-DHAVE_DL_ITERATE_PHDR -DHAVE_ZLIB -DHAVE_ZSTD -DHAVE_PTHREAD 
-DHAVE_PTHREAD_SETAFFINITY -DHAVE_LIBDRM -DLLVM_AVAILABLE 
'-DMESA_LLVM_VERSION_STRING="12.0.0"' -DLLVM_IS_SHARED=1 
-DUSE_LIBGLVND=1 -DHAVE_LIBUNWIND -DHAVE_DRI3 -DHAVE_DRI3_MODIFIERS 
-DHAVE_LIBSENSORS=1 -Werror=return-type -Werror=empty-body 
-Wno-non-virtual-dtor -Wno-missing-field-initializers 
-Wno-format-truncation -fno-math-errno -fno-trapping-math 
-flifetime-dse=1 -Werror=format -Wformat-security -fPIC -pthread 
-D__STDC_LIMIT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_CONSTANT_MACROS 
-D_GNU_SOURCE -MD -MQ 
src/gallium/drivers/r600/libr600.a.p/sfn_sfn_nir_lower_64bit.cpp.o -MF 
src/gallium/drivers/r600/libr600.a.p/sfn_sfn_nir_lower_64bit.cpp.o.d -o 
src/gallium/drivers/r600/libr600.a.p/sfn_sfn_nir_lower_64bit.cpp.o -c 
../src/gallium/drivers/r600/sfn/sfn_nir_lower_64bit.cpp
../src/gallium/drivers/r600/sfn/sfn_nir_lower_64bit.cpp: In member 
function ‘nir_ssa_def* 
r600::LowerSplit64BitVar::split_double_store_deref(nir_intrinsic_instr*)’:
../src/gallium/drivers/r600/sfn/sfn_nir_lower_64bit.cpp:207:1: error: 
control reaches end of non-void function [-Werror=return-type]
   207 | }
       | ^
../src/gallium/drivers/r600/sfn/sfn_nir_lower_64bit.cpp: In member 
function ‘nir_ssa_def* 
r600::LowerSplit64BitVar::split_double_load_deref(nir_intrinsic_instr*)’:
../src/gallium/drivers/r600/sfn/sfn_nir_lower_64bit.cpp:220:27: error: 
control reaches end of non-void function [-Werror=return-type]
   220 |    m_old_stores.push_back(&intr->instr);
       |                           ^~~~~~~~~~~~
cc1plus: some warnings being treated as errors
[1327/1508] Compiling C++ object 
src/gallium/dri...r600/libr600.a.p/sfn_sfn_nir_lower_tess_io.cpp.o
ninja: build stopped: subcommand failed.
2332.881u 143.645s 5:45.31 717.1%       0+0k 244272+368600io 250pf+0w

Maybe I can do some testing with my Tursk for you.
Our son 'need' my Polaris 20 for his new own Ryzen 5 3600...;-)

Greetings,
Dieter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: r600/nir: enable soft-fp64 for evengreen class hardware - brake compilation of Mesa git

[Gert Wollny]

Hello Dieter, 

I guess you did a release build? The build failure should be fixed now,
someone else had already opened an issue. 

> Maybe I can do some testing with my Tursk for you.
Thanks, that always helps :) 

Best, 
Gert 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel