From: Rob Herring <robh@kernel.org>
To: enric.balletbo@collabora.com
Cc: Mark Rutland <mark.rutland@arm.com>,
Douglas Anderson <dianders@chromium.org>,
David Airlie <airlied@linux.ie>,
Catalin Marinas <catalin.marinas@arm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Klaus Goger <klaus.goger@theobroma-systems.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
kernel@collabora.com, linux-clk@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Brian Norris <briannorris@chromium.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Nickey Yang <nickey.yang@rock-chips.com>,
Jacob Chen <jacob-chen@iotwrt.com>,
devicetree@vger.kernel.org, Randy Li <ayaka@soulik.info>,
linux-pm@vger.kernel.org, Derek Basehore <dbasehore@chromium.org>,
Mark Yao <markyao0591@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Lin Huang <hl@rock-chips.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
robin.murphy@arm.com
Subject: Re: [PATCH 7/8] arm64: dts: rk3399: Add dfi and dmc nodes.
Date: Thu, 09 Aug 2018 16:41:22 -0600 [thread overview]
Message-ID: <5b6cc314.1c69fb81.96ced.16f7@mx.google.com> (raw)
In-Reply-To: <20180730081124.30698-8-enric.balletbo@collabora.com>
Hi, this is an automated email from Rob's (experimental) review bot. I
found a couple of common problems with your patch. Please see below.
On Mon, 30 Jul 2018 10:11:23 +0200, Enric Balletbo i Serra wrote:
> From: Lin Huang <hl@rock-chips.com>
>
> These are required to support DDR DVFS on rk3399 platform. The patch also
> introduces two new files (rk3399-dram.h and rk3399-dram-default-timing)
> with default DRAM settings.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
>
> Changes in v1:
> - [RFC 8/10] Move rk3399-dram.h to dt-includes.
> - [RFC 8/10] Put sdram default values under the dmc node.
> - [RFC 8/10] Removed rk3399-dram-default-timing.dts
>
> .../boot/dts/rockchip/rk3399-op1-opp.dtsi | 29 ++++++++
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 49 +++++++++++++
> include/dt-bindings/power/rk3399-dram.h | 73 +++++++++++++++++++
> 3 files changed, 151 insertions(+)
> create mode 100644 include/dt-bindings/power/rk3399-dram.h
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: enric.balletbo@collabora.com
Cc: , Mark Rutland <mark.rutland@arm.com>,
Douglas Anderson <dianders@chromium.org>,
David Airlie <airlied@linux.ie>,
Catalin Marinas <catalin.marinas@arm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Klaus Goger <klaus.goger@theobroma-systems.com>,
kernel@collabora.com, linux-clk@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Brian Norris <briannorris@chromium.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Nickey Yang <nickey.yang@rock-chips.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
devicetree@vger.kernel.org, Randy Li <ayaka@soulik.info>,
linux-pm@vger.kernel.org, Derek Basehore <dbasehore@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
Mark Yao <markyao0591@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Jacob Chen <jacob-chen@iotwrt.com>, Lin Huang <hl@rock-chips.com>,
Sandy Huang <hjc@rock-chips.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
robin.murphy@arm.com
Subject: Re: [PATCH 7/8] arm64: dts: rk3399: Add dfi and dmc nodes.
Date: Thu, 09 Aug 2018 16:41:22 -0600 [thread overview]
Message-ID: <5b6cc314.1c69fb81.96ced.16f7@mx.google.com> (raw)
In-Reply-To: <20180730081124.30698-8-enric.balletbo@collabora.com>
Hi, this is an automated email from Rob's (experimental) review bot. I
found a couple of common problems with your patch. Please see below.
On Mon, 30 Jul 2018 10:11:23 +0200, Enric Balletbo i Serra wrote:
> From: Lin Huang <hl@rock-chips.com>
>
> These are required to support DDR DVFS on rk3399 platform. The patch also
> introduces two new files (rk3399-dram.h and rk3399-dram-default-timing)
> with default DRAM settings.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
>
> Changes in v1:
> - [RFC 8/10] Move rk3399-dram.h to dt-includes.
> - [RFC 8/10] Put sdram default values under the dmc node.
> - [RFC 8/10] Removed rk3399-dram-default-timing.dts
>
> .../boot/dts/rockchip/rk3399-op1-opp.dtsi | 29 ++++++++
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 49 +++++++++++++
> include/dt-bindings/power/rk3399-dram.h | 73 +++++++++++++++++++
> 3 files changed, 151 insertions(+)
> create mode 100644 include/dt-bindings/power/rk3399-dram.h
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] arm64: dts: rk3399: Add dfi and dmc nodes.
Date: Thu, 09 Aug 2018 16:41:22 -0600 [thread overview]
Message-ID: <5b6cc314.1c69fb81.96ced.16f7@mx.google.com> (raw)
In-Reply-To: <20180730081124.30698-8-enric.balletbo@collabora.com>
Hi, this is an automated email from Rob's (experimental) review bot. I
found a couple of common problems with your patch. Please see below.
On Mon, 30 Jul 2018 10:11:23 +0200, Enric Balletbo i Serra wrote:
> From: Lin Huang <hl@rock-chips.com>
>
> These are required to support DDR DVFS on rk3399 platform. The patch also
> introduces two new files (rk3399-dram.h and rk3399-dram-default-timing)
> with default DRAM settings.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
>
> Changes in v1:
> - [RFC 8/10] Move rk3399-dram.h to dt-includes.
> - [RFC 8/10] Put sdram default values under the dmc node.
> - [RFC 8/10] Removed rk3399-dram-default-timing.dts
>
> .../boot/dts/rockchip/rk3399-op1-opp.dtsi | 29 ++++++++
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 49 +++++++++++++
> include/dt-bindings/power/rk3399-dram.h | 73 +++++++++++++++++++
> 3 files changed, 151 insertions(+)
> create mode 100644 include/dt-bindings/power/rk3399-dram.h
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
next prev parent reply other threads:[~2018-08-09 22:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 8:11 [PATCH 0/8] Add support for drm/rockchip to dynamically control the DDR frequency Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
2018-07-30 8:11 ` [PATCH 1/8] devfreq: rockchip-dfi: Move GRF definitions to a common place Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
2018-08-01 8:36 ` Chanwoo Choi
2018-08-01 8:36 ` Chanwoo Choi
2018-08-07 10:50 ` Enric Balletbo i Serra
2018-08-07 10:50 ` Enric Balletbo i Serra
2018-07-30 8:11 ` [PATCH 2/8] dt-bindings: devfreq: rk3399_dmc: Add rockchip,pmu phandle Enric Balletbo i Serra
2018-07-30 8:11 ` [PATCH 2/8] dt-bindings: devfreq: rk3399_dmc: Add rockchip, pmu phandle Enric Balletbo i Serra
2018-07-30 8:11 ` [PATCH 3/8] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
2018-08-01 9:08 ` Chanwoo Choi
2018-08-01 9:08 ` Chanwoo Choi
2018-07-30 8:11 ` [PATCH 4/8] devfreq: rk3399_dmc / clk: rockchip: Sync with vblank in the kernel for DDRfreq Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
2018-08-02 2:35 ` Chanwoo Choi
2018-08-02 2:35 ` Chanwoo Choi
2018-07-30 8:11 ` [PATCH 5/8] devfreq: rk3399_dmc / clk: rockchip: Disable DDR clk timeout on suspend Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
2018-07-30 8:11 ` [PATCH 6/8] drm: rockchip: Add DDR devfreq support Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
2018-07-30 8:11 ` [PATCH 7/8] arm64: dts: rk3399: Add dfi and dmc nodes Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
2018-08-09 22:41 ` Rob Herring [this message]
2018-08-09 22:41 ` Rob Herring
2018-08-09 22:41 ` Rob Herring
2018-07-30 8:11 ` [PATCH 8/8] arm64: dts: rockchip: Enable dmc and dfi nodes on gru Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
2018-07-30 8:11 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b6cc314.1c69fb81.96ced.16f7@mx.google.com \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=ayaka@soulik.info \
--cc=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=cw00.choi@samsung.com \
--cc=dbasehore@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=hl@rock-chips.com \
--cc=jacob-chen@iotwrt.com \
--cc=kernel@collabora.com \
--cc=klaus.goger@theobroma-systems.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=markyao0591@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=nickey.yang@rock-chips.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.