From: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Maxime Jourdan <maxi.jourdan@wanadoo.fr>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] drm/meson: convert to the new canvas module
Date: Thu, 09 Aug 2018 16:41:26 -0600 [thread overview]
Message-ID: <5b6cc316.1c69fb81.682d3.1216@mx.google.com> (raw)
In-Reply-To: <20180801185128.23440-5-maxi.jourdan@wanadoo.fr>
Hi, this is an automated email from Rob's (experimental) review bot. I
found a couple of common problems with your patch. Please see below.
On Wed, 1 Aug 2018 20:51:28 +0200, Maxime Jourdan wrote:
> This removes the meson_canvas files within the meson/drm layer
> and makes use of the new canvas module that is referenced in the dts.
>
> Canvases can be used by different IPs and modules, and it is as such
> preferable to rely on a module that can safely dispatch canvases on
> demand.
>
> Signed-off-by: Maxime Jourdan <maxi.jourdan@wanadoo.fr>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> .../bindings/display/amlogic,meson-vpu.txt | 9 +--
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 7 +-
> drivers/gpu/drm/meson/Kconfig | 1 +
> drivers/gpu/drm/meson/Makefile | 2 +-
> drivers/gpu/drm/meson/meson_canvas.c | 70 -------------------
> drivers/gpu/drm/meson/meson_canvas.h | 42 -----------
> drivers/gpu/drm/meson/meson_crtc.c | 5 +-
> drivers/gpu/drm/meson/meson_drv.c | 35 ++++++----
> drivers/gpu/drm/meson/meson_drv.h | 5 +-
> drivers/gpu/drm/meson/meson_plane.c | 3 +-
> drivers/gpu/drm/meson/meson_viu.c | 1 -
> 11 files changed, 39 insertions(+), 141 deletions(-)
> delete mode 100644 drivers/gpu/drm/meson/meson_canvas.c
> delete mode 100644 drivers/gpu/drm/meson/meson_canvas.h
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] drm/meson: convert to the new canvas module
Date: Thu, 09 Aug 2018 16:41:26 -0600 [thread overview]
Message-ID: <5b6cc316.1c69fb81.682d3.1216@mx.google.com> (raw)
In-Reply-To: <20180801185128.23440-5-maxi.jourdan@wanadoo.fr>
Hi, this is an automated email from Rob's (experimental) review bot. I
found a couple of common problems with your patch. Please see below.
On Wed, 1 Aug 2018 20:51:28 +0200, Maxime Jourdan wrote:
> This removes the meson_canvas files within the meson/drm layer
> and makes use of the new canvas module that is referenced in the dts.
>
> Canvases can be used by different IPs and modules, and it is as such
> preferable to rely on a module that can safely dispatch canvases on
> demand.
>
> Signed-off-by: Maxime Jourdan <maxi.jourdan@wanadoo.fr>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> .../bindings/display/amlogic,meson-vpu.txt | 9 +--
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 7 +-
> drivers/gpu/drm/meson/Kconfig | 1 +
> drivers/gpu/drm/meson/Makefile | 2 +-
> drivers/gpu/drm/meson/meson_canvas.c | 70 -------------------
> drivers/gpu/drm/meson/meson_canvas.h | 42 -----------
> drivers/gpu/drm/meson/meson_crtc.c | 5 +-
> drivers/gpu/drm/meson/meson_drv.c | 35 ++++++----
> drivers/gpu/drm/meson/meson_drv.h | 5 +-
> drivers/gpu/drm/meson/meson_plane.c | 3 +-
> drivers/gpu/drm/meson/meson_viu.c | 1 -
> 11 files changed, 39 insertions(+), 141 deletions(-)
> delete mode 100644 drivers/gpu/drm/meson/meson_canvas.c
> delete mode 100644 drivers/gpu/drm/meson/meson_canvas.h
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 4/4] drm/meson: convert to the new canvas module
Date: Thu, 09 Aug 2018 16:41:26 -0600 [thread overview]
Message-ID: <5b6cc316.1c69fb81.682d3.1216@mx.google.com> (raw)
In-Reply-To: <20180801185128.23440-5-maxi.jourdan@wanadoo.fr>
Hi, this is an automated email from Rob's (experimental) review bot. I
found a couple of common problems with your patch. Please see below.
On Wed, 1 Aug 2018 20:51:28 +0200, Maxime Jourdan wrote:
> This removes the meson_canvas files within the meson/drm layer
> and makes use of the new canvas module that is referenced in the dts.
>
> Canvases can be used by different IPs and modules, and it is as such
> preferable to rely on a module that can safely dispatch canvases on
> demand.
>
> Signed-off-by: Maxime Jourdan <maxi.jourdan@wanadoo.fr>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> .../bindings/display/amlogic,meson-vpu.txt | 9 +--
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 7 +-
> drivers/gpu/drm/meson/Kconfig | 1 +
> drivers/gpu/drm/meson/Makefile | 2 +-
> drivers/gpu/drm/meson/meson_canvas.c | 70 -------------------
> drivers/gpu/drm/meson/meson_canvas.h | 42 -----------
> drivers/gpu/drm/meson/meson_crtc.c | 5 +-
> drivers/gpu/drm/meson/meson_drv.c | 35 ++++++----
> drivers/gpu/drm/meson/meson_drv.h | 5 +-
> drivers/gpu/drm/meson/meson_plane.c | 3 +-
> drivers/gpu/drm/meson/meson_viu.c | 1 -
> 11 files changed, 39 insertions(+), 141 deletions(-)
> delete mode 100644 drivers/gpu/drm/meson/meson_canvas.c
> delete mode 100644 drivers/gpu/drm/meson/meson_canvas.h
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
next prev parent reply other threads:[~2018-08-09 22:41 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 18:51 [PATCH 0/4] soc: amlogic: add meson-canvas driver Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-01 18:51 ` [PATCH 1/4] " Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-02 8:38 ` Neil Armstrong
2018-08-02 8:38 ` Neil Armstrong
2018-08-02 8:38 ` Neil Armstrong
2018-08-02 8:52 ` Neil Armstrong
2018-08-02 8:52 ` Neil Armstrong
2018-08-02 8:52 ` Neil Armstrong
2018-08-02 13:14 ` Maxime Jourdan
2018-08-02 13:14 ` Maxime Jourdan
2018-08-02 13:14 ` Maxime Jourdan
2018-08-03 14:14 ` Yixun Lan
2018-08-03 14:14 ` Yixun Lan
2018-08-03 14:14 ` Yixun Lan
2018-08-03 21:47 ` Maxime Jourdan
2018-08-03 21:47 ` Maxime Jourdan
2018-08-03 21:47 ` Maxime Jourdan
2018-08-01 18:51 ` [PATCH 2/4] dt-bindings: soc: amlogic: add meson-canvas documentation Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-01 18:51 ` [PATCH 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-03 13:50 ` Yixun Lan
2018-08-03 13:50 ` Yixun Lan
2018-08-03 13:50 ` Yixun Lan
2018-08-04 20:02 ` Maxime Jourdan
2018-08-04 20:02 ` Maxime Jourdan
2018-08-04 20:02 ` Maxime Jourdan
2018-08-04 20:02 ` Maxime Jourdan
2018-08-07 1:29 ` Yixun Lan
2018-08-07 1:29 ` Yixun Lan
2018-08-07 1:29 ` Yixun Lan
2018-08-01 18:51 ` [PATCH 4/4] drm/meson: convert to the new canvas module Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-01 18:51 ` Maxime Jourdan
2018-08-02 8:39 ` Jerome Brunet
2018-08-02 8:39 ` Jerome Brunet
2018-08-02 8:39 ` Jerome Brunet
2018-08-02 12:34 ` Maxime Jourdan
2018-08-02 12:34 ` Maxime Jourdan
2018-08-02 12:34 ` Maxime Jourdan
2018-08-02 13:01 ` Jerome Brunet
2018-08-02 13:01 ` Jerome Brunet
2018-08-02 13:01 ` Jerome Brunet
2018-08-02 13:09 ` Maxime Jourdan
2018-08-02 13:09 ` Maxime Jourdan
2018-08-02 13:09 ` Maxime Jourdan
2018-08-09 22:41 ` Rob Herring [this message]
2018-08-09 22:41 ` Rob Herring
2018-08-09 22:41 ` Rob Herring
2018-08-10 6:35 ` Maxime Jourdan
2018-08-10 6:35 ` Maxime Jourdan
2018-08-10 6:35 ` Maxime Jourdan
2018-08-10 7:49 ` Neil Armstrong
2018-08-10 7:49 ` Neil Armstrong
2018-08-10 7:49 ` Neil Armstrong
2018-08-10 7:49 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b6cc316.1c69fb81.682d3.1216@mx.google.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxi.jourdan@wanadoo.fr \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.